All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] net: mdio: Supply appropriate devices for dev_dgb calls
Date: Wed, 16 Sep 2020 21:44:42 -0600	[thread overview]
Message-ID: <CAPnjgZ0dCvMwt9TofU-xfXj8qC0u9QAC+8sMFuhXppDjsaGJqQ@mail.gmail.com> (raw)
In-Reply-To: <9fb560bc-9901-ec5c-737f-b5ae8822fa9a@gmail.com>

Hi Sean,

On Wed, 16 Sep 2020 at 19:40, Sean Anderson <seanga2@gmail.com> wrote:
>
>
> On 9/16/20 9:09 PM, Simon Glass wrote:
> > On Sat, 12 Sep 2020 at 18:28, Sean Anderson <seanga2@gmail.com> wrote:
> >>
> >> The name of the device we are working on is `ethdev` and not just `dev`.
> >>
> >> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> >> ---
> >>
> >>  net/mdio-uclass.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > BTW I really like using 'dev' for the struct udevice if there is only
> > one, and other names for other things (e.g. edev for Ethernet, udev
> > for USB).
> >
>
> Yeah, I think it is only really necessary when disambiguating between
> several different devices. However, I am trying to make these patches as
> minimal as possible, so I would like to keep the variable names the same
> where possible.

Yes definitely better the way you have the patches now.

  reply	other threads:[~2020-09-17  3:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  0:28 [PATCH 0/4] dm: Print device name in dev_xxx() like Linux Sean Anderson
2020-09-13  0:28 ` [PATCH 1/4] remoteproc: Remove unused function rproc_elf_sanity_check Sean Anderson
2020-09-17  1:09   ` Simon Glass
2020-09-13  0:28 ` [PATCH 2/4] net: mdio: Supply appropriate devices for dev_dgb calls Sean Anderson
2020-09-17  1:09   ` Simon Glass
2020-09-17  1:40     ` Sean Anderson
2020-09-17  3:44       ` Simon Glass [this message]
2020-09-13  0:28 ` [PATCH 3/4] dm: Use symbolic constants for log levels in dev_xxx() Sean Anderson
2020-09-17  1:09   ` Simon Glass
2020-09-13  0:28 ` [PATCH 4/4] dm: Print device name in dev_xxx() like Linux Sean Anderson
2020-09-13  1:43 ` [PATCH 0/4] " Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ0dCvMwt9TofU-xfXj8qC0u9QAC+8sMFuhXppDjsaGJqQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.