All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v3 0/2] Detect and reject new ad-hoc CONFIG options
@ 2016-09-14  3:44 Simon Glass
  2016-09-14  3:44 ` [U-Boot] [PATCH v3 1/2] Kconfig: Add a whitelist of " Simon Glass
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Simon Glass @ 2016-09-14  3:44 UTC (permalink / raw)
  To: u-boot

Despite the availability of Kconfig, the number of ad-hoc CONFIG options in
U-Boot is still at over 8000.

In February 2015 (commit 741e58e0) there were around 8387 ad-hoc CONFIGs.
As of this patch there are about 8336, only a little fewer.

One problem is that new ones are still being added, admittedly at a slower
rate. This series adds a Makefile check to detect that and produce a build
error. This provides immediate feedback that new CONFIG options should go in
Kconfig.

Changes in v3:
- Update the whitelist with mainline
- Fix the match partern to exclude .py files, not anything containing "py"
- Handle Kconfig files with extensions (e.g. Kconfig.64)
- Handle CONFIG_SYS_EXTRA_OPTIONS containing lower case
- Include lower-case letters in the CONFIG match string
- Write error output to stderr so that buildman shows it
- Handle Kconfig files with extensions (e.g. Kconfig.64)
- Handle extra whitespace after 'config' / 'menuconfig'

Changes in v2:
- Rebase to mainline
- Fix scripts so that there are no errors
- Add the 'build-whitelist.sh' script to the tree

Simon Glass (2):
  Kconfig: Add a whitelist of ad-hoc CONFIG options
  Makefile: Give a build error if ad-hoc CONFIG options are added

 Makefile                     |   10 +-
 scripts/build-whitelist.sh   |   51 +
 scripts/check-config.sh      |   55 +
 scripts/config_whitelist.txt | 8420 ++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 8535 insertions(+), 1 deletion(-)
 create mode 100755 scripts/build-whitelist.sh
 create mode 100755 scripts/check-config.sh
 create mode 100644 scripts/config_whitelist.txt

-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-18 16:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  3:44 [U-Boot] [PATCH v3 0/2] Detect and reject new ad-hoc CONFIG options Simon Glass
2016-09-14  3:44 ` [U-Boot] [PATCH v3 1/2] Kconfig: Add a whitelist of " Simon Glass
2016-09-18 16:01   ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-09-14  3:44 ` [U-Boot] [PATCH v3 2/2] Makefile: Give a build error if ad-hoc CONFIG options are added Simon Glass
2016-09-18 16:01   ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-09-14  3:46 ` [U-Boot] [PATCH v3 0/2] Detect and reject new ad-hoc CONFIG options Simon Glass
2016-09-14 19:13   ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.