All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] image: fix select_ramdisk for raw initrd
@ 2021-10-15 10:15 Artem Lapkin
  2021-10-31 23:47 ` Simon Glass
       [not found] ` <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
  0 siblings, 2 replies; 4+ messages in thread
From: Artem Lapkin @ 2021-10-15 10:15 UTC (permalink / raw)
  To: sjg
  Cc: trini, narmstrong, twarren, andre.przywara, u-boot,
	u-boot-amlogic, art, nick, gouwa

Problem

We have unbootable raw initrd images because, select_ramdisk for raw
initrd images ignore submited select addr and setup rd_datap value to 0

Solution: setup rd_datap value from select

Signed-off-by: Artem Lapkin <art@khadas.com>
---
 common/image-board.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/image-board.c b/common/image-board.c
index e7660352e9..e3c6ea806a 100644
--- a/common/image-board.c
+++ b/common/image-board.c
@@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
 				end = strchr(select, ':');
 			if (end) {
 				*rd_lenp = hextoul(++end, NULL);
-				*rd_datap = rd_addr;
+				*rd_datap = hextoul(select, NULL);
 				processed = true;
 			}
 		}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] image: fix select_ramdisk for raw initrd
  2021-10-15 10:15 [PATCH] image: fix select_ramdisk for raw initrd Artem Lapkin
@ 2021-10-31 23:47 ` Simon Glass
       [not found] ` <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-10-31 23:47 UTC (permalink / raw)
  To: Artem Lapkin
  Cc: trini, narmstrong, TWarren, andre.przywara, u-boot,
	u-boot-amlogic, art, nick, gouwa

Hi Artem,

On Fri, 15 Oct 2021 at 04:15, Artem Lapkin <email2tema@gmail.com> wrote:
>
> Problem
>
> We have unbootable raw initrd images because, select_ramdisk for raw
> initrd images ignore submited select addr and setup rd_datap value to 0
>
> Solution: setup rd_datap value from select
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  common/image-board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Do we need this patch as well as the other one? If so, can you combine them?

Also, is it possible to drop the assignment to rd_addr at the top of
the function?

>
> diff --git a/common/image-board.c b/common/image-board.c
> index e7660352e9..e3c6ea806a 100644
> --- a/common/image-board.c
> +++ b/common/image-board.c
> @@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
>                                 end = strchr(select, ':');
>                         if (end) {
>                                 *rd_lenp = hextoul(++end, NULL);
> -                               *rd_datap = rd_addr;
> +                               *rd_datap = hextoul(select, NULL);
>                                 processed = true;
>                         }
>                 }
> --
> 2.25.1
>

Regards,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] image: fix select_ramdisk for raw initrd
       [not found] ` <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
@ 2021-11-01  7:00   ` Art Nikpal
  0 siblings, 0 replies; 4+ messages in thread
From: Art Nikpal @ 2021-11-01  7:00 UTC (permalink / raw)
  To: Simon Glass
  Cc: Tom Rini, Neil Armstrong, Tom Warren, Andre Przywara,
	U-Boot Mailing List, u-boot-amlogic, Artem Lapkin, Nick Xie,
	Gouwa Wang

Hi Simon, Tom , and ...

> Do we need this patch as well as the other one? If so, can you combine them?
> Also, is it possible to drop the assignment to rd_addr at the top of
the function?

this patch must be replaced by another one
https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-art@khadas.com/
( last patch will be enough alone)

On Mon, Nov 1, 2021 at 7:47 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Artem,
>
> On Fri, 15 Oct 2021 at 04:15, Artem Lapkin <email2tema@gmail.com> wrote:
> >
> > Problem
> >
> > We have unbootable raw initrd images because, select_ramdisk for raw
> > initrd images ignore submited select addr and setup rd_datap value to 0
> >
> > Solution: setup rd_datap value from select
> >
> > Signed-off-by: Artem Lapkin <art@khadas.com>
> > ---
> >  common/image-board.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Do we need this patch as well as the other one? If so, can you combine them?
>
> Also, is it possible to drop the assignment to rd_addr at the top of
> the function?
>
> >
> > diff --git a/common/image-board.c b/common/image-board.c
> > index e7660352e9..e3c6ea806a 100644
> > --- a/common/image-board.c
> > +++ b/common/image-board.c
> > @@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
> >                                 end = strchr(select, ':');
> >                         if (end) {
> >                                 *rd_lenp = hextoul(++end, NULL);
> > -                               *rd_datap = rd_addr;
> > +                               *rd_datap = hextoul(select, NULL);
> >                                 processed = true;
> >                         }
> >                 }
> > --
> > 2.25.1
> >
>
> Regards,
> Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] image: fix select_ramdisk for raw initrd
       [not found] <AGsABQADINEbmE0Dy93f3qrc.9.1634292918431.Hmail.art@khadas.com>
@ 2021-10-16  5:24 ` Art Nikpal
  0 siblings, 0 replies; 4+ messages in thread
From: Art Nikpal @ 2021-10-16  5:24 UTC (permalink / raw)
  To: Simon Glass
  Cc: Tom Rini, Neil Armstrong, Tom Warren, Andre Przywara,
	U-Boot Mailing List, u-boot-amlogic, Artem Lapkin, Nick Xie,
	Gouwa Wang

Hi Simon
plz ignore this patch
proper solution problem there >
https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-art@khadas.com/

On Fri, Oct 15, 2021 at 6:15 PM Artem Lapkin <email2tema@gmail.com> wrote:
>
> Problem
>
> We have unbootable raw initrd images because, select_ramdisk for raw
> initrd images ignore submited select addr and setup rd_datap value to 0
>
> Solution: setup rd_datap value from select
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  common/image-board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/image-board.c b/common/image-board.c
> index e7660352e9..e3c6ea806a 100644
> --- a/common/image-board.c
> +++ b/common/image-board.c
> @@ -439,7 +439,7 @@ static int select_ramdisk(bootm_headers_t *images, const char *select, u8 arch,
>                                 end = strchr(select, ':');
>                         if (end) {
>                                 *rd_lenp = hextoul(++end, NULL);
> -                               *rd_datap = rd_addr;
> +                               *rd_datap = hextoul(select, NULL);
>                                 processed = true;
>                         }
>                 }
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-01  7:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 10:15 [PATCH] image: fix select_ramdisk for raw initrd Artem Lapkin
2021-10-31 23:47 ` Simon Glass
     [not found] ` <AN6A0QAgIIdLnqeOIKHW84rw.9.1635724039553.Hmail.art@khadas.com>
2021-11-01  7:00   ` Art Nikpal
     [not found] <AGsABQADINEbmE0Dy93f3qrc.9.1634292918431.Hmail.art@khadas.com>
2021-10-16  5:24 ` Art Nikpal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.