[U-Boot] [PATCH 0/3] RK3399: Add support for Ficus board

[U-Boot] [PATCH 0/3] RK3399: Add support for Ficus board

[Ezequiel Garcia]

Add support for a new RK3399-based board. The RK3399 Ficus
board is an Enterprise Edition board manufactured by Vamrs Ltd.,
based on the Rockchip RK3399 SoC.

While here, we extend the evb_rk3399/README document
with instructions for SD/MMC boot.

The devicetree file for this board has been already merged
in Linux maintainer's tree:

https://kernel.googlesource.com/pub/scm/linux/kernel/git/mmind/linux-rockchip/+/v4.19-armsoc/dts64/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts

Ezequiel Garcia (2):
  ARM: add RK3399 Ficus board
  rockchip: rk3399: Add more instructions to the README

Randy Li (1):
  arm: dts: rockchip: add some common pin-settings to rk3399

 arch/arm/dts/Makefile            |   1 +
 arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
 arch/arm/dts/rk3399.dtsi         |  55 ++-
 board/rockchip/evb_rk3399/README |  57 +++-
 configs/ficus-rk3399_defconfig   |  71 ++++
 5 files changed, 740 insertions(+), 8 deletions(-)
 create mode 100644 arch/arm/dts/rk3399-ficus.dts
 create mode 100644 configs/ficus-rk3399_defconfig

-- 
2.18.0

[U-Boot] [PATCH 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Ezequiel Garcia]

From: Randy Li <ayaka@soulik.info>

Those pins would be used by many boards.

Signed-off-by: Randy Li <ayaka@soulik.info>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 49 insertions(+), 6 deletions(-)

diff --git a/arch/arm/dts/rk3399.dtsi b/arch/arm/dts/rk3399.dtsi
index 83c257b1228b..8349451b03dc 100644
--- a/arch/arm/dts/rk3399.dtsi
+++ b/arch/arm/dts/rk3399.dtsi
@@ -1602,19 +1602,49 @@
 			drive-strength = <12>;
 		};
 
+		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
+			bias-disable;
+			drive-strength = <13>;
+		};
+
+		pcfg_pull_none_18ma: pcfg-pull-none-18ma {
+			bias-disable;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_none_20ma: pcfg-pull-none-20ma {
+			bias-disable;
+			drive-strength = <20>;
+		};
+
+		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
+			bias-pull-up;
+			drive-strength = <2>;
+		};
+
 		pcfg_pull_up_8ma: pcfg-pull-up-8ma {
 			bias-pull-up;
 			drive-strength = <8>;
 		};
 
+		pcfg_pull_up_18ma: pcfg-pull-up-18ma {
+			bias-pull-up;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_up_20ma: pcfg-pull-up-20ma {
+			bias-pull-up;
+			drive-strength = <20>;
+		};
+
 		pcfg_pull_down_4ma: pcfg-pull-down-4ma {
 			bias-pull-down;
 			drive-strength = <4>;
 		};
 
-		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
-			bias-pull-up;
-			drive-strength = <2>;
+		pcfg_pull_down_8ma: pcfg-pull-down-8ma {
+			bias-pull-down;
+			drive-strength = <8>;
 		};
 
 		pcfg_pull_down_12ma: pcfg-pull-down-12ma {
@@ -1622,9 +1652,22 @@
 			drive-strength = <12>;
 		};
 
-		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
-			bias-disable;
-			drive-strength = <13>;
+		pcfg_pull_down_18ma: pcfg-pull-down-18ma {
+			bias-pull-down;
+			drive-strength = <18>;
+		};
+
+		pcfg_pull_down_20ma: pcfg-pull-down-20ma {
+			bias-pull-down;
+			drive-strength = <20>;
+		};
+
+		pcfg_output_high: pcfg-output-high {
+			output-high;
+		};
+
+		pcfg_output_low: pcfg-output-low {
+			output-low;
 		};
 
 		clock {
-- 
2.18.0

[U-Boot] [PATCH 2/3] ARM: add RK3399 Ficus board

[Ezequiel Garcia]

This commit adds support for RK3399 Ficus board,
aka ROCK960 Enterprise Edition.

Following peripherals are tested and known to work:
* Gigabit Ethernet
* USB 2.0
* MMC

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 arch/arm/dts/Makefile            |   1 +
 arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
 board/rockchip/evb_rk3399/README |   2 +
 configs/ficus-rk3399_defconfig   |  71 ++++
 4 files changed, 638 insertions(+)
 create mode 100644 arch/arm/dts/rk3399-ficus.dts
 create mode 100644 configs/ficus-rk3399_defconfig

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 946023093df6..fbce68d9a2eb 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -47,6 +47,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rk3368-geekbox.dtb \
 	rk3368-px5-evb.dtb \
 	rk3399-evb.dtb \
+	rk3399-ficus.dtb \
 	rk3399-firefly.dtb \
 	rk3399-puma-ddr1333.dtb \
 	rk3399-puma-ddr1600.dtb \
diff --git a/arch/arm/dts/rk3399-ficus.dts b/arch/arm/dts/rk3399-ficus.dts
new file mode 100644
index 000000000000..ccccdb015a26
--- /dev/null
+++ b/arch/arm/dts/rk3399-ficus.dts
@@ -0,0 +1,564 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 Collabora Ltd.
+ * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd.
+ *
+ * Schematics available at https://dl.vamrs.com/products/ficus/docs/hw
+ */
+
+/dts-v1/;
+#include <dt-bindings/pinctrl/rockchip.h>
+#include "rk3399.dtsi"
+#include "rk3399-sdram-ddr3-1600.dtsi"
+
+/ {
+	model = "96boards RK3399 Ficus";
+	compatible = "vamrs,ficus", "rockchip,rk3399";
+
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
+	clkin_gmac: external-gmac-clock {
+		compatible = "fixed-clock";
+		clock-frequency = <125000000>;
+		clock-output-names = "clkin_gmac";
+		#clock-cells = <0>;
+	};
+
+	vcc1v8_s0: vcc1v8-s0 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8_s0";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+	};
+
+	vcc_sys: vcc-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_sys";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
+	vcc3v3_sys: vcc3v3-sys {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc3v3_sys";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		vin-supply = <&vcc_sys>;
+	};
+
+	vcc3v3_pcie: vcc3v3-pcie-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pcie_drv>;
+		regulator-boot-on;
+		regulator-name = "vcc3v3_pcie";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc3v3_sys>;
+	};
+
+	vcc5v0_host: vcc5v0-host-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio4 27 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&host_vbus_drv>;
+		regulator-name = "vcc5v0_host";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+		vin-supply = <&vcc_sys>;
+	};
+
+	vdd_log: vdd-log {
+		compatible = "pwm-regulator";
+		pwms = <&pwm2 0 25000 0>;
+		regulator-name = "vdd_log";
+		regulator-min-microvolt = <800000>;
+		regulator-max-microvolt = <1400000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vcc_sys>;
+	};
+};
+
+&cpu_l0 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l1 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l2 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_l3 {
+	cpu-supply = <&vdd_cpu_l>;
+};
+
+&cpu_b0 {
+	cpu-supply = <&vdd_cpu_b>;
+};
+
+&cpu_b1 {
+	cpu-supply = <&vdd_cpu_b>;
+};
+
+&emmc_phy {
+	status = "okay";
+};
+
+&gmac {
+	assigned-clocks = <&cru SCLK_RMII_SRC>;
+	assigned-clock-parents = <&clkin_gmac>;
+	clock_in_out = "input";
+	phy-supply = <&vcc3v3_sys>;
+	phy-mode = "rgmii";
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>;
+	snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>;
+	snps,reset-active-low;
+	snps,reset-delays-us = <0 10000 50000>;
+	tx_delay = <0x28>;
+	rx_delay = <0x11>;
+	status = "okay";
+};
+
+&hdmi {
+	status = "okay";
+};
+
+&i2c0 {
+	clock-frequency = <400000>;
+	i2c-scl-rising-time-ns = <168>;
+	i2c-scl-falling-time-ns = <4>;
+	status = "okay";
+
+	vdd_cpu_b: regulator at 40 {
+		compatible = "silergy,syr827";
+		reg = <0x40>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_cpu_b";
+		regulator-min-microvolt = <712500>;
+		regulator-max-microvolt = <1500000>;
+		regulator-ramp-delay = <1000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vcc_sys>;
+		status = "okay";
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+
+	vdd_gpu: regulator at 41 {
+		compatible = "silergy,syr828";
+		reg = <0x41>;
+		fcs,suspend-voltage-selector = <1>;
+		regulator-name = "vdd_gpu";
+		regulator-min-microvolt = <712500>;
+		regulator-max-microvolt = <1500000>;
+		regulator-ramp-delay = <1000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vcc_sys>;
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
+
+	rk808: pmic at 1b {
+		compatible = "rockchip,rk808";
+		reg = <0x1b>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pmic_int_l>;
+		rockchip,system-power-controller;
+		wakeup-source;
+		#clock-cells = <1>;
+		clock-output-names = "xin32k", "rk808-clkout2";
+
+		vcc1-supply = <&vcc_sys>;
+		vcc2-supply = <&vcc_sys>;
+		vcc3-supply = <&vcc_sys>;
+		vcc4-supply = <&vcc_sys>;
+		vcc6-supply = <&vcc_sys>;
+		vcc7-supply = <&vcc_sys>;
+		vcc8-supply = <&vcc3v3_sys>;
+		vcc9-supply = <&vcc_sys>;
+		vcc10-supply = <&vcc_sys>;
+		vcc11-supply = <&vcc_sys>;
+		vcc12-supply = <&vcc3v3_sys>;
+		vddio-supply = <&vcc_1v8>;
+
+		regulators {
+			vdd_center: DCDC_REG1 {
+				regulator-name = "vdd_center";
+				regulator-min-microvolt = <750000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vdd_cpu_l: DCDC_REG2 {
+				regulator-name = "vdd_cpu_l";
+				regulator-min-microvolt = <750000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+
+			vcc_ddr: DCDC_REG3 {
+				regulator-name = "vcc_ddr";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+
+			vcc_1v8: DCDC_REG4 {
+				regulator-name = "vcc_1v8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcc1v8_dvp: LDO_REG1 {
+				regulator-name = "vcc1v8_dvp";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcca1v8_hdmi: LDO_REG2 {
+				regulator-name = "vcca1v8_hdmi";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcca_1v8: LDO_REG3 {
+				regulator-name = "vcca_1v8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1800000>;
+				};
+			};
+
+			vcc_sd: LDO_REG4 {
+				regulator-name = "vcc_sd";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <3300000>;
+				};
+			};
+
+			vcc3v0_sd: LDO_REG5 {
+				regulator-name = "vcc3v0_sd";
+				regulator-min-microvolt = <3000000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <3000000>;
+				};
+			};
+
+			vcc_1v5: LDO_REG6 {
+				regulator-name = "vcc_1v5";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <1500000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <1500000>;
+				};
+			};
+
+			vcca0v9_hdmi: LDO_REG7 {
+				regulator-name = "vcca0v9_hdmi";
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <900000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <900000>;
+				};
+			};
+
+			vcc_3v0: LDO_REG8 {
+				regulator-name = "vcc_3v0";
+				regulator-min-microvolt = <3000000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+					regulator-suspend-microvolt = <3000000>;
+				};
+			};
+
+			vcc3v3_s3: SWITCH_REG1 {
+				regulator-name = "vcc3v3_s3";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+
+			vcc3v3_s0: SWITCH_REG2 {
+				regulator-name = "vcc3v3_s0";
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-state-mem {
+					regulator-on-in-suspend;
+				};
+			};
+		};
+	};
+};
+
+&i2c1 {
+	status = "okay";
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c3 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+};
+
+&io_domains {
+	bt656-supply = <&vcc1v8_s0>; /* bt656_gpio2ab_ms */
+	audio-supply = <&vcc1v8_s0>; /* audio_gpio3d4a_ms */
+	sdmmc-supply = <&vcc_sd>; /* sdmmc_gpio4b_ms */
+	gpio1830-supply = <&vcc_3v0>; /* gpio1833_gpio4cd_ms */
+	status = "okay";
+};
+
+&pcie_phy {
+	status = "okay";
+};
+
+&pcie0 {
+	ep-gpios = <&gpio4 RK_PD4 GPIO_ACTIVE_HIGH>;
+	num-lanes = <4>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie_clkreqn_cpm>;
+	vpcie3v3-supply = <&vcc3v3_pcie>;
+	status = "okay";
+};
+
+&pmu_io_domains {
+	pmu1830-supply = <&vcc_1v8>;
+	status = "okay";
+};
+
+&pinctrl {
+	gmac {
+		rgmii_sleep_pins: rgmii-sleep-pins {
+			rockchip,pins =
+				<3 15 RK_FUNC_GPIO &pcfg_output_low>;
+		};
+	};
+
+	sdmmc {
+		sdmmc_bus1: sdmmc-bus1 {
+			rockchip,pins =
+				<4 8 RK_FUNC_1 &pcfg_pull_up_8ma>;
+		};
+
+		sdmmc_bus4: sdmmc-bus4 {
+			rockchip,pins =
+				<4 8 RK_FUNC_1 &pcfg_pull_up_8ma>,
+				<4 9 RK_FUNC_1 &pcfg_pull_up_8ma>,
+				<4 10 RK_FUNC_1 &pcfg_pull_up_8ma>,
+				<4 11 RK_FUNC_1 &pcfg_pull_up_8ma>;
+		};
+
+		sdmmc_clk: sdmmc-clk {
+			rockchip,pins =
+				<4 12 RK_FUNC_1 &pcfg_pull_none_18ma>;
+		};
+
+		sdmmc_cmd: sdmmc-cmd {
+			rockchip,pins =
+				<4 13 RK_FUNC_1 &pcfg_pull_up_8ma>;
+		};
+	};
+
+	pcie {
+		pcie_drv: pcie-drv {
+			rockchip,pins =
+				<1 24 RK_FUNC_GPIO &pcfg_pull_none>;
+			};
+	};
+
+	pmic {
+		pmic_int_l: pmic-int-l {
+			rockchip,pins =
+				<1 21 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+
+		vsel1_gpio: vsel1-gpio {
+			rockchip,pins =
+				<1 17 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+
+		vsel2_gpio: vsel2-gpio {
+			rockchip,pins =
+				<1 14 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+	};
+
+	usb2 {
+		host_vbus_drv: host-vbus-drv {
+			rockchip,pins =
+				<4 27 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
+&pwm2 {
+	status = "okay";
+};
+
+&pwm3 {
+	status = "okay";
+};
+
+&sdhci {
+	bus-width = <8>;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
+	non-removable;
+	status = "okay";
+};
+
+&sdmmc {
+	u-boot,dm-pre-reloc;
+
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	clock-frequency = <100000000>;
+	clock-freq-min-max = <100000 100000000>;
+	disable-wp;
+	sd-uhs-sdr104;
+	vqmmc-supply = <&vcc_sd>;
+	card-detect-delay = <800>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_cd &sdmmc_bus4>;
+	status = "okay";
+};
+
+&u2phy0 {
+	status = "okay";
+};
+
+&u2phy1 {
+	status = "okay";
+};
+
+&u2phy0_host {
+	phy-supply = <&vcc5v0_host>;
+	status = "okay";
+};
+
+&u2phy1_host {
+	phy-supply = <&vcc5v0_host>;
+	status = "okay";
+};
+
+&u2phy0_otg {
+	status = "okay";
+};
+
+&u2phy1_otg {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_xfer &uart0_cts>;
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
+
+&usb_host0_ehci {
+	status = "okay";
+};
+
+&usb_host0_ohci {
+	status = "okay";
+};
+
+&usb_host1_ehci {
+	status = "okay";
+};
+
+&usb_host1_ohci {
+	status = "okay";
+};
+
+&vopb {
+	status = "okay";
+};
+
+&vopl {
+	status = "okay";
+};
diff --git a/board/rockchip/evb_rk3399/README b/board/rockchip/evb_rk3399/README
index ada8ca7f3c15..0b4c6d19ad39 100644
--- a/board/rockchip/evb_rk3399/README
+++ b/board/rockchip/evb_rk3399/README
@@ -57,6 +57,8 @@ Compile the U-Boot
   > make evb-rk3399_defconfig
   for firefly-rk3399, use below instead:
   > make firefly-rk3399_defconfig
+  for ficus-rk3399, use below instead:
+  > make ficus-rk3399_defconfig
   > make
   > make u-boot.itb
 
diff --git a/configs/ficus-rk3399_defconfig b/configs/ficus-rk3399_defconfig
new file mode 100644
index 000000000000..d7606280e373
--- /dev/null
+++ b/configs/ficus-rk3399_defconfig
@@ -0,0 +1,71 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_TEXT_BASE=0x00200000
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_SYS_MALLOC_F_LEN=0x4000
+CONFIG_ROCKCHIP_RK3399=y
+CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x4000
+CONFIG_DEBUG_UART_BASE=0xFF1A0000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_SPL_STACK_R_ADDR=0x80000
+CONFIG_DEFAULT_DEVICE_TREE="rk3399-ficus"
+CONFIG_DEBUG_UART=y
+CONFIG_FIT=y
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py"
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
+CONFIG_SPL_ATF=y
+CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
+CONFIG_CMD_BOOTZ=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_TIME=y
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_REGMAP=y
+CONFIG_SPL_REGMAP=y
+CONFIG_SYSCON=y
+CONFIG_SPL_SYSCON=y
+CONFIG_CLK=y
+CONFIG_SPL_CLK=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_DM_ETH=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_RGMII=y
+CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PINCTRL=y
+CONFIG_SPL_PINCTRL=y
+CONFIG_PINCTRL_ROCKCHIP_RK3399=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_PWM=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_REGULATOR_RK8XX=y
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_RAM=y
+CONFIG_SPL_RAM=y
+CONFIG_BAUDRATE=1500000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_ROCKCHIP_USB2_PHY=y
+CONFIG_USB_STORAGE=y
+CONFIG_USE_TINY_PRINTF=y
+CONFIG_ERRNO_STR=y
-- 
2.18.0

[U-Boot] [PATCH 3/3] rockchip: rk3399: Add more instructions to the README

[Ezequiel Garcia]

This commit adds a content section and also instructions
on how to create a bootable SD/MMC device for RK3399 boards.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 board/rockchip/evb_rk3399/README | 55 ++++++++++++++++++++++++++++++--
 1 file changed, 53 insertions(+), 2 deletions(-)

diff --git a/board/rockchip/evb_rk3399/README b/board/rockchip/evb_rk3399/README
index 0b4c6d19ad39..3775d3ff447f 100644
--- a/board/rockchip/evb_rk3399/README
+++ b/board/rockchip/evb_rk3399/README
@@ -1,3 +1,21 @@
+Contents
+========
+
+1. Introduction
+2. Get the Source and prebuild binary
+3. Compile the ATF
+4. Compile the U-Boot
+5. Compile the rkdeveloptool
+6. Package the image
+   6.1. Package the image for U-Boot SPL(option 1)
+   6.2. Package the image for Rockchip miniloader(option 2)
+7. Bootloader storage options
+8. Flash the image to eMMC
+   8.1. Flash the image with U-Boot SPL(option 1)
+   8.2. Flash the image with Rockchip miniloader(option 2)
+9. Create a bootable SD/MMC
+10. And that is it
+
 Introduction
 ============
 
@@ -97,6 +115,12 @@ Package the image for Rockchip miniloader(option 2)
 
   Get trust.img and uboot.img in this step.
 
+Bootloader storage options
+==========================
+
+There are a few different storage options for the bootloader.
+This document explores two of these: eMMC and removable SD/MMC.
+
 Flash the image to eMMC
 =======================
 
@@ -117,6 +141,33 @@ Power on(or reset with RESET KEY) with MASKROM KEY preesed, and then:
   > rkdeveloptool wl 0x6000 u-boot/trust.img
   > rkdeveloptool rd
 
+Create a bootable SD/MMC
+========================
+
+The idbspl.img contains the first stage, and the u-boot.img the second stage.
+As explained in the Rockchip partition table reference [2], the first stage
+(aka loader1) start sector is 64, and the second stage start sector is 16384.
+
+Each sector is 512 bytes, which means the first stage offset is 32 KiB,
+and the second stage offset is 8 MiB.
+
+Note: the second stage location is actually not as per the spec,
+but defined by the SPL. Mainline SPL defines an 8 MiB offset for the second
+stage.
+
+Assuming the SD card is exposed by device /dev/mmcblk0, the commands
+to write the two stages are:
+
+  > dd if=idbspl.img of=/dev/mmcblk0 bs=1k seek=32
+  > dd if=u-boot.itb of=/dev/mmcblk0 bs=1k seek=8192
+
+Setting up the kernel and rootfs is beyond the scope of this document.
+
+And that is it
+==============
+
 You should be able to get U-Boot log in console/UART2(baurdrate 1500000)
-For more detail, please reference to:
-http://opensource.rock-chips.com/wiki_Boot_option
+For more detail, please reference [2].
+
+[1] http://opensource.rock-chips.com/wiki_Partitions
+[2] http://opensource.rock-chips.com/wiki_Boot_option
-- 
2.18.0

[U-Boot] [PATCH 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Simon Glass]

On 16 July 2018 at 13:41, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> From: Randy Li <ayaka@soulik.info>
>
> Those pins would be used by many boards.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 49 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH 2/3] ARM: add RK3399 Ficus board

[Simon Glass]

On 16 July 2018 at 13:41, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> This commit adds support for RK3399 Ficus board,
> aka ROCK960 Enterprise Edition.
>
> Following peripherals are tested and known to work:
> * Gigabit Ethernet
> * USB 2.0
> * MMC
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  arch/arm/dts/Makefile            |   1 +
>  arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>  board/rockchip/evb_rk3399/README |   2 +
>  configs/ficus-rk3399_defconfig   |  71 ++++
>  4 files changed, 638 insertions(+)
>  create mode 100644 arch/arm/dts/rk3399-ficus.dts
>  create mode 100644 configs/ficus-rk3399_defconfig

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH 3/3] rockchip: rk3399: Add more instructions to the README

[Simon Glass]

On 16 July 2018 at 13:41, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> This commit adds a content section and also instructions
> on how to create a bootable SD/MMC device for RK3399 boards.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  board/rockchip/evb_rk3399/README | 55 ++++++++++++++++++++++++++++++--
>  1 file changed, 53 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Hmm, we should convert all of rockchip to use binman I think.

- Simon

[U-Boot] [PATCH 3/3] rockchip: rk3399: Add more instructions to the README

[Ezequiel Garcia]

On Wed, 2018-07-18 at 19:32 -0600, Simon Glass wrote:
> On 16 July 2018 at 13:41, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> > This commit adds a content section and also instructions
> > on how to create a bootable SD/MMC device for RK3399 boards.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> >  board/rockchip/evb_rk3399/README | 55 ++++++++++++++++++++++++++++++--
> >  1 file changed, 53 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Hmm, we should convert all of rockchip to use binman I think.
> 

Yeah, that would be sweet.

[U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Philipp Tomsich]

On Mon, 16 Jul 2018, Ezequiel Garcia wrote:

> From: Randy Li <ayaka@soulik.info>
>
> Those pins would be used by many boards.

The Rockchip pinctrl driver in U-Boot does not (yet) read the DTS for pin 
configuration information.

Is this a sync of the Linux DTS (which seems unlikely, as I'd expect more 
changes) or why are we doing this as part of this series?

>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
> 1 file changed, 49 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399.dtsi b/arch/arm/dts/rk3399.dtsi
> index 83c257b1228b..8349451b03dc 100644
> --- a/arch/arm/dts/rk3399.dtsi
> +++ b/arch/arm/dts/rk3399.dtsi
> @@ -1602,19 +1602,49 @@
> 			drive-strength = <12>;
> 		};
>
> +		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
> +			bias-disable;
> +			drive-strength = <13>;
> +		};
> +
> +		pcfg_pull_none_18ma: pcfg-pull-none-18ma {
> +			bias-disable;
> +			drive-strength = <18>;
> +		};
> +
> +		pcfg_pull_none_20ma: pcfg-pull-none-20ma {
> +			bias-disable;
> +			drive-strength = <20>;
> +		};
> +
> +		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
> +			bias-pull-up;
> +			drive-strength = <2>;
> +		};
> +
> 		pcfg_pull_up_8ma: pcfg-pull-up-8ma {
> 			bias-pull-up;
> 			drive-strength = <8>;
> 		};
>
> +		pcfg_pull_up_18ma: pcfg-pull-up-18ma {
> +			bias-pull-up;
> +			drive-strength = <18>;
> +		};
> +
> +		pcfg_pull_up_20ma: pcfg-pull-up-20ma {
> +			bias-pull-up;
> +			drive-strength = <20>;
> +		};
> +
> 		pcfg_pull_down_4ma: pcfg-pull-down-4ma {
> 			bias-pull-down;
> 			drive-strength = <4>;
> 		};
>
> -		pcfg_pull_up_2ma: pcfg-pull-up-2ma {
> -			bias-pull-up;
> -			drive-strength = <2>;
> +		pcfg_pull_down_8ma: pcfg-pull-down-8ma {
> +			bias-pull-down;
> +			drive-strength = <8>;
> 		};
>
> 		pcfg_pull_down_12ma: pcfg-pull-down-12ma {
> @@ -1622,9 +1652,22 @@
> 			drive-strength = <12>;
> 		};
>
> -		pcfg_pull_none_13ma: pcfg-pull-none-13ma {
> -			bias-disable;
> -			drive-strength = <13>;
> +		pcfg_pull_down_18ma: pcfg-pull-down-18ma {
> +			bias-pull-down;
> +			drive-strength = <18>;
> +		};
> +
> +		pcfg_pull_down_20ma: pcfg-pull-down-20ma {
> +			bias-pull-down;
> +			drive-strength = <20>;
> +		};
> +
> +		pcfg_output_high: pcfg-output-high {
> +			output-high;
> +		};
> +
> +		pcfg_output_low: pcfg-output-low {
> +			output-low;
> 		};
>
> 		clock {
>

[U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

[Philipp Tomsich]

On Mon, 16 Jul 2018, Ezequiel Garcia wrote:

> This commit adds a content section and also instructions
> on how to create a bootable SD/MMC device for RK3399 boards.

Are any of these instructions Ficus-specific?  We have our own README for 
our own boards, as these have different instructions from the EVB boards.

Just wondering, as I'd have expected this to come in as part of the ficus 
board-directory...

> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

> ---
> board/rockchip/evb_rk3399/README | 55 ++++++++++++++++++++++++++++++--
> 1 file changed, 53 insertions(+), 2 deletions(-)
>
> diff --git a/board/rockchip/evb_rk3399/README b/board/rockchip/evb_rk3399/README
> index 0b4c6d19ad39..3775d3ff447f 100644
> --- a/board/rockchip/evb_rk3399/README
> +++ b/board/rockchip/evb_rk3399/README
> @@ -1,3 +1,21 @@
> +Contents
> +========
> +
> +1. Introduction
> +2. Get the Source and prebuild binary
> +3. Compile the ATF
> +4. Compile the U-Boot
> +5. Compile the rkdeveloptool
> +6. Package the image
> +   6.1. Package the image for U-Boot SPL(option 1)
> +   6.2. Package the image for Rockchip miniloader(option 2)
> +7. Bootloader storage options
> +8. Flash the image to eMMC
> +   8.1. Flash the image with U-Boot SPL(option 1)
> +   8.2. Flash the image with Rockchip miniloader(option 2)
> +9. Create a bootable SD/MMC
> +10. And that is it
> +
> Introduction
> ============
>
> @@ -97,6 +115,12 @@ Package the image for Rockchip miniloader(option 2)
>
>   Get trust.img and uboot.img in this step.
>
> +Bootloader storage options
> +==========================
> +
> +There are a few different storage options for the bootloader.
> +This document explores two of these: eMMC and removable SD/MMC.
> +
> Flash the image to eMMC
> =======================
>
> @@ -117,6 +141,33 @@ Power on(or reset with RESET KEY) with MASKROM KEY preesed, and then:
>   > rkdeveloptool wl 0x6000 u-boot/trust.img
>   > rkdeveloptool rd
>
> +Create a bootable SD/MMC
> +========================
> +
> +The idbspl.img contains the first stage, and the u-boot.img the second stage.
> +As explained in the Rockchip partition table reference [2], the first stage
> +(aka loader1) start sector is 64, and the second stage start sector is 16384.
> +
> +Each sector is 512 bytes, which means the first stage offset is 32 KiB,
> +and the second stage offset is 8 MiB.
> +
> +Note: the second stage location is actually not as per the spec,
> +but defined by the SPL. Mainline SPL defines an 8 MiB offset for the second
> +stage.
> +
> +Assuming the SD card is exposed by device /dev/mmcblk0, the commands
> +to write the two stages are:
> +
> +  > dd if=idbspl.img of=/dev/mmcblk0 bs=1k seek=32
> +  > dd if=u-boot.itb of=/dev/mmcblk0 bs=1k seek=8192
> +
> +Setting up the kernel and rootfs is beyond the scope of this document.
> +
> +And that is it
> +==============
> +
> You should be able to get U-Boot log in console/UART2(baurdrate 1500000)
> -For more detail, please reference to:
> -http://opensource.rock-chips.com/wiki_Boot_option
> +For more detail, please reference [2].
> +
> +[1] http://opensource.rock-chips.com/wiki_Partitions
> +[2] http://opensource.rock-chips.com/wiki_Boot_option
>

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Philipp Tomsich]

> This commit adds support for RK3399 Ficus board,
> aka ROCK960 Enterprise Edition.
> 
> Following peripherals are tested and known to work:
> * Gigabit Ethernet
> * USB 2.0
> * MMC
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>  arch/arm/dts/Makefile            |   1 +
>  arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>  board/rockchip/evb_rk3399/README |   2 +
>  configs/ficus-rk3399_defconfig   |  71 ++++
>  4 files changed, 638 insertions(+)
>  create mode 100644 arch/arm/dts/rk3399-ficus.dts
>  create mode 100644 configs/ficus-rk3399_defconfig
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

[Ezequiel Garcia]

On Fri, 2018-07-20 at 18:28 +0200, Philipp Tomsich wrote:
> 
> On Mon, 16 Jul 2018, Ezequiel Garcia wrote:
> 
> > This commit adds a content section and also instructions
> > on how to create a bootable SD/MMC device for RK3399 boards.
> 
> Are any of these instructions Ficus-specific?  We have our own README for 
> our own boards, as these have different instructions from the EVB boards.
> 

Nope, it applies to any rk3399 board. And the rest of the file as well,
as long as the board has eMMC.

> Just wondering, as I'd have expected this to come in as part of the ficus 
> board-directory...
> 

Yeah, but all the instructions on this file applied to the Ficus
(and to many others) so I decided to just extend it for now.

If it needs moving to some generic doc, I think we can do that as a follow up patch.

> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> 

Thanks for the review!
Eze

[U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

[Dr. Philipp Tomsich]

Thanks for the clarification, I’ll take this as-is.

> On 20 Jul 2018, at 19:09, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> 
> On Fri, 2018-07-20 at 18:28 +0200, Philipp Tomsich wrote:
>> 
>> On Mon, 16 Jul 2018, Ezequiel Garcia wrote:
>> 
>>> This commit adds a content section and also instructions
>>> on how to create a bootable SD/MMC device for RK3399 boards.
>> 
>> Are any of these instructions Ficus-specific?  We have our own README for 
>> our own boards, as these have different instructions from the EVB boards.
>> 
> 
> Nope, it applies to any rk3399 board. And the rest of the file as well,
> as long as the board has eMMC.
> 
>> Just wondering, as I'd have expected this to come in as part of the ficus 
>> board-directory...
>> 
> 
> Yeah, but all the instructions on this file applied to the Ficus
> (and to many others) so I decided to just extend it for now.
> 
> If it needs moving to some generic doc, I think we can do that as a follow up patch.
> 
>>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> 
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> 
> 
> Thanks for the review!
> Eze

[U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Ezequiel Garcia]

On Fri, 2018-07-20 at 18:26 +0200, Philipp Tomsich wrote:
> 
> On Mon, 16 Jul 2018, Ezequiel Garcia wrote:
> 
> > From: Randy Li <ayaka@soulik.info>
> > 
> > Those pins would be used by many boards.
> 
> The Rockchip pinctrl driver in U-Boot does not (yet) read the DTS for pin 
> configuration information.
> 
> Is this a sync of the Linux DTS (which seems unlikely, as I'd expect more 
> changes) or why are we doing this as part of this series?
> 

As a matter of fact, it is a sync. It is literally this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.19-armsoc/dts64&id=b41023282d07b61a53e2c9b9508912b1e7ce7b4f

It's just needed so that at least the ficus.dts file compiles.

Thanks,
Eze

[U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Dr. Philipp Tomsich]

> On 20 Jul 2018, at 19:14, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> 
> On Fri, 2018-07-20 at 18:26 +0200, Philipp Tomsich wrote:
>> 
>> On Mon, 16 Jul 2018, Ezequiel Garcia wrote:
>> 
>>> From: Randy Li <ayaka@soulik.info>
>>> 
>>> Those pins would be used by many boards.
>> 
>> The Rockchip pinctrl driver in U-Boot does not (yet) read the DTS for pin 
>> configuration information.
>> 
>> Is this a sync of the Linux DTS (which seems unlikely, as I'd expect more 
>> changes) or why are we doing this as part of this series?
>> 
> 
> As a matter of fact, it is a sync. It is literally this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.19-armsoc/dts64&id=b41023282d07b61a53e2c9b9508912b1e7ce7b4f
> 
> It's just needed so that at least the ficus.dts file compiles.
> 
> Thanks,
> Eze

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Philipp Tomsich]

> This commit adds support for RK3399 Ficus board,
> aka ROCK960 Enterprise Edition.
> 
> Following peripherals are tested and known to work:
> * Gigabit Ethernet
> * USB 2.0
> * MMC
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  arch/arm/dts/Makefile            |   1 +
>  arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>  board/rockchip/evb_rk3399/README |   2 +
>  configs/ficus-rk3399_defconfig   |  71 ++++
>  4 files changed, 638 insertions(+)
>  create mode 100644 arch/arm/dts/rk3399-ficus.dts
>  create mode 100644 configs/ficus-rk3399_defconfig
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

[Philipp Tomsich]

> From: Randy Li <ayaka@soulik.info>
> 
> Those pins would be used by many boards.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  arch/arm/dts/rk3399.dtsi | 55 +++++++++++++++++++++++++++++++++++-----
>  1 file changed, 49 insertions(+), 6 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

[Philipp Tomsich]

> This commit adds a content section and also instructions
> on how to create a bootable SD/MMC device for RK3399 boards.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  board/rockchip/evb_rk3399/README | 55 ++++++++++++++++++++++++++++++--
>  1 file changed, 53 insertions(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Dr. Philipp Tomsich]

Ezequiel,

This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695).
Did you test with Travis prior to submitting?

When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag …

Thanks,
Philipp.


> On 20 Jul 2018, at 19:30, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
> 
>> This commit adds support for RK3399 Ficus board,
>> aka ROCK960 Enterprise Edition.
>> 
>> Following peripherals are tested and known to work:
>> * Gigabit Ethernet
>> * USB 2.0
>> * MMC
>> 
>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>> arch/arm/dts/Makefile            |   1 +
>> arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>> board/rockchip/evb_rk3399/README |   2 +
>> configs/ficus-rk3399_defconfig   |  71 ++++
>> 4 files changed, 638 insertions(+)
>> create mode 100644 arch/arm/dts/rk3399-ficus.dts
>> create mode 100644 configs/ficus-rk3399_defconfig
>> 
> 
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Ezequiel Garcia]

On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote:
> Ezequiel,
> 
> This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695).
> Did you test with Travis prior to submitting?
> 

No, I haven't. It's quite odd, as the README patch just adds some documentation.
I am having a hard time figuring out how could it break the build,
and I do not see any logs in the travis-ci link either.

Any ideas?

> When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag …
> 

OK, I will.

> Thanks,
> Philipp.
> 
> 
> > On 20 Jul 2018, at 19:30, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
> > 
> > > This commit adds support for RK3399 Ficus board,
> > > aka ROCK960 Enterprise Edition.
> > > 
> > > Following peripherals are tested and known to work:
> > > * Gigabit Ethernet
> > > * USB 2.0
> > > * MMC
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > > ---
> > > arch/arm/dts/Makefile            |   1 +
> > > arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
> > > board/rockchip/evb_rk3399/README |   2 +
> > > configs/ficus-rk3399_defconfig   |  71 ++++
> > > 4 files changed, 638 insertions(+)
> > > create mode 100644 arch/arm/dts/rk3399-ficus.dts
> > > create mode 100644 configs/ficus-rk3399_defconfig
> > > 
> > 
> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> 
> 

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Dr. Philipp Tomsich]

Ezequiel,

> On 25 Jul 2018, at 22:31, Ezequiel Garcia <ezequiel@collabora.com> wrote:
> 
> On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote:
>> Ezequiel,
>> 
>> This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695).
>> Did you test with Travis prior to submitting?
>> 
> 
> No, I haven't. It's quite odd, as the README patch just adds some documentation.

I responded to this mail, as there’s no cover letter.
It’s the series breaking the build, not the README change.

> I am having a hard time figuring out how could it break the build,
> and I do not see any logs in the travis-ci link either.

Does the direct link to the line with the error work for you:
	https://travis-ci.org/ptomsich/u-boot-rockchip/jobs/406351815#L1330

If not, I’ll have to copy this into a mail manually...

> 
> Any ideas?
> 
>> When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag …
>> 
> 
> OK, I will.
> 
>> Thanks,
>> Philipp.
>> 
>> 
>>> On 20 Jul 2018, at 19:30, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>>> 
>>>> This commit adds support for RK3399 Ficus board,
>>>> aka ROCK960 Enterprise Edition.
>>>> 
>>>> Following peripherals are tested and known to work:
>>>> * Gigabit Ethernet
>>>> * USB 2.0
>>>> * MMC
>>>> 
>>>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>> ---
>>>> arch/arm/dts/Makefile            |   1 +
>>>> arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>>>> board/rockchip/evb_rk3399/README |   2 +
>>>> configs/ficus-rk3399_defconfig   |  71 ++++
>>>> 4 files changed, 638 insertions(+)
>>>> create mode 100644 arch/arm/dts/rk3399-ficus.dts
>>>> create mode 100644 configs/ficus-rk3399_defconfig
>>>> 
>>> 
>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> https://lists.denx.de/listinfo/u-boot
>> 
>> 
> 

[U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

[Ezequiel Garcia]

On 25 July 2018 at 18:20, Dr. Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Ezequiel,
>
>> On 25 Jul 2018, at 22:31, Ezequiel Garcia <ezequiel@collabora.com> wrote:
>>
>> On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote:
>>> Ezequiel,
>>>
>>> This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695).
>>> Did you test with Travis prior to submitting?
>>>
>>
>> No, I haven't. It's quite odd, as the README patch just adds some documentation.
>
> I responded to this mail, as there’s no cover letter.
> It’s the series breaking the build, not the README change.
>
>> I am having a hard time figuring out how could it break the build,
>> and I do not see any logs in the travis-ci link either.
>
> Does the direct link to the line with the error work for you:
>         https://travis-ci.org/ptomsich/u-boot-rockchip/jobs/406351815#L1330
>
> If not, I’ll have to copy this into a mail manually...
>

Right, I see it now. Thanks!


+drivers/usb/phy/rockchip_usb2_phy.c: In function 'property_enable':
+arch/arm/include/asm/io.h:49:29: error: cast to pointer from integer
of different size [-Werror=int-to-pointer-cast]
+ #define __arch_putl(v,a)  (*(volatile unsigned int *)(a) = (v))
+                             ^
+arch/arm/include/asm/io.h:117:48: note: in expansion of macro '__arch_putl'
+ #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; })
+                                                ^~~~~~~~~~~
+drivers/usb/phy/rockchip_usb2_phy.c:61:2: note: in expansion of macro 'writel'
+  writel(val, pdata->regs_phy + reg->offset);
+  ^~~~~~

So, it seems that since the defconfig is enabling this USB PHY driver,
it's causing
the failure.

I'll see if I can fix this issue and send a patch, but it seems
totally orthogonal to the Ficus
patchset.

>>
>> Any ideas?
>>
>>> When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag …
>>>
>>
>> OK, I will.
>>
>>> Thanks,
>>> Philipp.
>>>
>>>
>>>> On 20 Jul 2018, at 19:30, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>>>>
>>>>> This commit adds support for RK3399 Ficus board,
>>>>> aka ROCK960 Enterprise Edition.
>>>>>
>>>>> Following peripherals are tested and known to work:
>>>>> * Gigabit Ethernet
>>>>> * USB 2.0
>>>>> * MMC
>>>>>
>>>>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>>> ---
>>>>> arch/arm/dts/Makefile            |   1 +
>>>>> arch/arm/dts/rk3399-ficus.dts    | 564 +++++++++++++++++++++++++++++++
>>>>> board/rockchip/evb_rk3399/README |   2 +
>>>>> configs/ficus-rk3399_defconfig   |  71 ++++
>>>>> 4 files changed, 638 insertions(+)
>>>>> create mode 100644 arch/arm/dts/rk3399-ficus.dts
>>>>> create mode 100644 configs/ficus-rk3399_defconfig
>>>>>
>>>>
>>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>> _______________________________________________
>>>> U-Boot mailing list
>>>> U-Boot at lists.denx.de
>>>> https://lists.denx.de/listinfo/u-boot
>>>
>>>
>>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar