* [U-Boot] [PATCH] fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS
@ 2018-07-20 2:04 Masahiro Yamada
2018-07-26 20:17 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2018-07-20 2:04 UTC (permalink / raw)
To: u-boot
fdt_fixup_mtdparts() calls mtdparts_init() and device_find(),
which are defined in cmd/mtdparts.c
The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n
emits the following link error:
common/fdt_support.c:903: undefined reference to `mtdparts_init'
common/fdt_support.c:914: undefined reference to `device_find'
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
lib/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index a77bf1c..622f3c2 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -334,7 +334,7 @@ config SPL_OF_LIBFDT
config FDT_FIXUP_PARTITIONS
bool "overwrite MTD partitions in DTS through defined in 'mtdparts'"
depends on OF_LIBFDT
- default n
+ depends on CMD_MTDPARTS
help
Allow overwriting defined partitions in the device tree blob
using partition info defined in the 'mtdparts' environment
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS
2018-07-20 2:04 [U-Boot] [PATCH] fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS Masahiro Yamada
@ 2018-07-26 20:17 ` Simon Glass
2018-07-27 0:36 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2018-07-26 20:17 UTC (permalink / raw)
To: u-boot
On 19 July 2018 at 20:04, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> fdt_fixup_mtdparts() calls mtdparts_init() and device_find(),
> which are defined in cmd/mtdparts.c
>
> The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n
> emits the following link error:
>
> common/fdt_support.c:903: undefined reference to `mtdparts_init'
> common/fdt_support.c:914: undefined reference to `device_find'
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> lib/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS
2018-07-26 20:17 ` Simon Glass
@ 2018-07-27 0:36 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2018-07-27 0:36 UTC (permalink / raw)
To: u-boot
On 26 July 2018 at 14:17, Simon Glass <sjg@chromium.org> wrote:
> On 19 July 2018 at 20:04, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>> fdt_fixup_mtdparts() calls mtdparts_init() and device_find(),
>> which are defined in cmd/mtdparts.c
>>
>> The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n
>> emits the following link error:
>>
>> common/fdt_support.c:903: undefined reference to `mtdparts_init'
>> common/fdt_support.c:914: undefined reference to `device_find'
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> lib/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-27 0:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 2:04 [U-Boot] [PATCH] fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS Masahiro Yamada
2018-07-26 20:17 ` Simon Glass
2018-07-27 0:36 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.