All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] common: env: add kconfig entry for env storage
@ 2016-10-08  9:06 Peng Fan
  2016-10-17 22:17 ` Simon Glass
  0 siblings, 1 reply; 4+ messages in thread
From: Peng Fan @ 2016-10-08  9:06 UTC (permalink / raw)
  To: u-boot

Add Kconfig entry for ENV storage

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
Cc: Francois Retief <fgretief@spaceteq.co.za>
---
 common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/common/Kconfig b/common/Kconfig
index c69c141..a630924 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -158,6 +158,79 @@ config SPI_BOOT
 
 endmenu
 
+menu "ENV storage media"
+
+config ENV_IS_IN_DATAFLASH
+	bool "env stored in dataflash"
+	help
+	  env stored in dataflash
+
+config ENV_IS_IN_EEPROM
+	bool "env stored in eeprom"
+	help
+	  env stored in eeprom
+
+config ENV_IS_EMBEDDED
+	bool "env is embedded"
+	help
+	  env is embedded
+
+config ENV_IS_IN_FLASH
+	bool "env stored in flash"
+	help
+	  env stored in flash
+
+config ENV_IS_IN_MMC
+	bool "env stored in sd/mmc card"
+	help
+	  env stored in sd/mmc card
+
+config ENV_IS_IN_NAND
+	bool "env stored in nand flash"
+	help
+	  env stored in nand flash
+
+config ENV_IS_IN_NVRAM
+	bool "env stored in nvram"
+	help
+	  env stored in nvram
+
+config ENV_IS_IN_ONENAND
+	bool "env stored in onenand"
+	help
+	  env stored in onenand
+
+config ENV_IS_IN_SATA
+	bool "env stored in sata"
+	help
+	  env stored in sata
+
+config ENV_IS_IN_SPI_FLASH
+	bool "env stored in spi flash"
+	help
+	  env stored in spi flash
+
+config ENV_IS_IN_FAT
+	bool "env stored in a fat file"
+	help
+	  env stored in a fat file
+
+config ENV_IS_IN_UBI
+	bool "env stored in a ubi file"
+	help
+	  env stored in a ubi file
+
+config ENV_IS_IN_REMOTE
+	bool "env stored in remote"
+	help
+	  env stored in remote
+
+config ENV_IS_NOWHERE
+	bool "env is nowhere"
+	help
+	  env is nowhere
+endmenu
+
 config BOOTDELAY
 	int "delay in seconds before automatically booting"
 	default 2
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] common: env: add kconfig entry for env storage
  2016-10-08  9:06 [U-Boot] [PATCH] common: env: add kconfig entry for env storage Peng Fan
@ 2016-10-17 22:17 ` Simon Glass
  2016-10-17 22:55   ` Tom Rini
  0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2016-10-17 22:17 UTC (permalink / raw)
  To: u-boot

Hi Peng,

On 8 October 2016 at 03:06, Peng Fan <peng.fan@nxp.com> wrote:
> Add Kconfig entry for ENV storage
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> Cc: Francois Retief <fgretief@spaceteq.co.za>
> ---
>  common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index c69c141..a630924 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -158,6 +158,79 @@ config SPI_BOOT
>
>  endmenu
>
> +menu "ENV storage media"
> +
> +config ENV_IS_IN_DATAFLASH
> +       bool "env stored in dataflash"
> +       help
> +         env stored in dataflash

Can you add a little more help detail on this? Also I suspect we
should have CONFIG_ENV as well, to enable the actual environment
(independent of where it is stored).

Also, can you migrate the existing configs with moveconfig? That would
be a big step forward and may inspire me to move it to linker lists.

Regards,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] common: env: add kconfig entry for env storage
  2016-10-17 22:17 ` Simon Glass
@ 2016-10-17 22:55   ` Tom Rini
  2016-10-18  5:17     ` Heiko Schocher
  0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2016-10-17 22:55 UTC (permalink / raw)
  To: u-boot

On Mon, Oct 17, 2016 at 04:17:06PM -0600, Simon Glass wrote:
> Hi Peng,
> 
> On 8 October 2016 at 03:06, Peng Fan <peng.fan@nxp.com> wrote:
> > Add Kconfig entry for ENV storage
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> > Cc: Francois Retief <fgretief@spaceteq.co.za>
> > ---
> >  common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 73 insertions(+)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index c69c141..a630924 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -158,6 +158,79 @@ config SPI_BOOT
> >
> >  endmenu
> >
> > +menu "ENV storage media"
> > +
> > +config ENV_IS_IN_DATAFLASH
> > +       bool "env stored in dataflash"
> > +       help
> > +         env stored in dataflash
> 
> Can you add a little more help detail on this? Also I suspect we
> should have CONFIG_ENV as well, to enable the actual environment
> (independent of where it is stored).

Yes, please add a bit more to the text.

> Also, can you migrate the existing configs with moveconfig? That would
> be a big step forward and may inspire me to move it to linker lists.

Actually, I bet this is going to be messy enough that I'm fine running
the moveconfig myself right before I merge it in.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161017/92dc6a76/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] common: env: add kconfig entry for env storage
  2016-10-17 22:55   ` Tom Rini
@ 2016-10-18  5:17     ` Heiko Schocher
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2016-10-18  5:17 UTC (permalink / raw)
  To: u-boot

Hello Tom,

Am 18.10.2016 um 00:55 schrieb Tom Rini:
> On Mon, Oct 17, 2016 at 04:17:06PM -0600, Simon Glass wrote:
>> Hi Peng,
>>
>> On 8 October 2016 at 03:06, Peng Fan <peng.fan@nxp.com> wrote:
>>> Add Kconfig entry for ENV storage
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Heiko Schocher <hs@denx.de>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> Cc: Stefan Roese <sr@denx.de>
>>> Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>> Cc: Francois Retief <fgretief@spaceteq.co.za>
>>> ---
>>>   common/Kconfig | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 73 insertions(+)
>>>
>>> diff --git a/common/Kconfig b/common/Kconfig
>>> index c69c141..a630924 100644
>>> --- a/common/Kconfig
>>> +++ b/common/Kconfig
>>> @@ -158,6 +158,79 @@ config SPI_BOOT
>>>
>>>   endmenu
>>>
>>> +menu "ENV storage media"
>>> +
>>> +config ENV_IS_IN_DATAFLASH
>>> +       bool "env stored in dataflash"
>>> +       help
>>> +         env stored in dataflash
>>
>> Can you add a little more help detail on this? Also I suspect we
>> should have CONFIG_ENV as well, to enable the actual environment
>> (independent of where it is stored).
>
> Yes, please add a bit more to the text.
>
>> Also, can you migrate the existing configs with moveconfig? That would
>> be a big step forward and may inspire me to move it to linker lists.
>
> Actually, I bet this is going to be messy enough that I'm fine running
> the moveconfig myself right before I merge it in.

Feel free to give me the patch for running the tbot test [1], that the
patch does not change binaries ...

bye,
Heiko

[1] https://github.com/hsdenx/tbot/blob/master/src/tc/uboot/tc_uboot_check_kconfig.py
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-18  5:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-08  9:06 [U-Boot] [PATCH] common: env: add kconfig entry for env storage Peng Fan
2016-10-17 22:17 ` Simon Glass
2016-10-17 22:55   ` Tom Rini
2016-10-18  5:17     ` Heiko Schocher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.