[PATCH 1/1] cmd: inconsistent return type of command_process()

* [PATCH 1/1] cmd: inconsistent return type of command_process()
@ 2022-08-01 13:17 Heinrich Schuchardt
  2022-08-01 19:13 ` Simon Glass
  2022-08-10 21:51 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2022-08-01 13:17 UTC (permalink / raw)
  To: Tom Rini
  Cc: Simon Glass, Jagan Teki, u-boot, Heinrich Schuchardt, Sergei Antonov

The declarations in the header and in the implementation must match.

Reported-by: Sergei Antonov <saproj@gmail.com>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 include/command.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/command.h b/include/command.h
index 44c91f655d..8917da8b21 100644
--- a/include/command.h
+++ b/include/command.h
@@ -229,10 +229,10 @@ enum command_ret_t {
  *			is left unchanged.
  * @param ticks		If ticks is not null, this function set it to the
  *			number of ticks the command took to complete.
- * Return: 0 if the command succeeded, 1 if it failed
+ * Return: 0 if command succeeded, else non-zero (CMD_RET_...)
  */
-int cmd_process(int flag, int argc, char *const argv[], int *repeatable,
-		unsigned long *ticks);
+enum command_ret_t cmd_process(int flag, int argc, char *const argv[],
+			       int *repeatable, unsigned long *ticks);
 
 void fixup_cmdtable(struct cmd_tbl *cmdtp, int size);
 
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread