* [U-Boot] [PATCH 1/1] test: fix typo in cmd_ut_category() description
@ 2018-08-27 20:04 Heinrich Schuchardt
2018-08-30 0:28 ` Simon Glass
2018-08-31 21:07 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2018-08-27 20:04 UTC (permalink / raw)
To: u-boot
argc = 1: all tests are run
argc > 1: only argv[1] is run
So we need argc >= 1.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/test/suites.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/test/suites.h b/include/test/suites.h
index 8e4eac60eb..abb3a4b816 100644
--- a/include/test/suites.h
+++ b/include/test/suites.h
@@ -15,7 +15,7 @@ struct unit_test;
* @name: Category name
* @tests: List of tests to run
* @n_ents: Number of tests in @tests
- * @argc: Argument count provided. Must be <= 1. If this is 1 then all
+ * @argc: Argument count provided. Must be >= 1. If this is 1 then all
* tests are run, otherwise only the one named @argv[1] is run.
* @argv: Arguments: argv[1] is the test to run (if @argc >= 2)
* @return 0 if OK, CMD_RET_FAILURE on failure
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] test: fix typo in cmd_ut_category() description
2018-08-27 20:04 [U-Boot] [PATCH 1/1] test: fix typo in cmd_ut_category() description Heinrich Schuchardt
@ 2018-08-30 0:28 ` Simon Glass
2018-08-31 21:07 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2018-08-30 0:28 UTC (permalink / raw)
To: u-boot
On 27 August 2018 at 14:04, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> argc = 1: all tests are run
> argc > 1: only argv[1] is run
>
> So we need argc >= 1.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/test/suites.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot, 1/1] test: fix typo in cmd_ut_category() description
2018-08-27 20:04 [U-Boot] [PATCH 1/1] test: fix typo in cmd_ut_category() description Heinrich Schuchardt
2018-08-30 0:28 ` Simon Glass
@ 2018-08-31 21:07 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-08-31 21:07 UTC (permalink / raw)
To: u-boot
On Mon, Aug 27, 2018 at 10:04:10PM +0200, Heinrich Schuchardt wrote:
> argc = 1: all tests are run
> argc > 1: only argv[1] is run
>
> So we need argc >= 1.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180831/508c2b9a/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-31 21:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 20:04 [U-Boot] [PATCH 1/1] test: fix typo in cmd_ut_category() description Heinrich Schuchardt
2018-08-30 0:28 ` Simon Glass
2018-08-31 21:07 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.