All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Dave Martin <dave.martin@linaro.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Olof Johansson <olof@lixom.net>,
	Stephen Boyd <sboyd@codeaurora.org>,
	anish singh <anish198519851985@gmail.com>,
	lak <linux-arm-kernel@lists.infradead.org>,
	Tony Lindgren <tony@atomide.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Joe Perches <joe@perches.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Alexander Shishkin <virtuoso@slind.org>,
	Phil Carmody <ext-phil.2.carmody@nokia.com>,
	Rabin Vincent <rabin@rab.in>, lk <linux-kernel@vger.kernel.org>,
	Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: Re: [PATCH v4] ARM: Use generic BUG() handler
Date: Mon, 11 Jul 2011 17:01:22 -0700	[thread overview]
Message-ID: <CAPnjgZ1-wPW1WyR0nC1R5BkLSwc54evb5gV0dpSEOM4duS4omg@mail.gmail.com> (raw)
In-Reply-To: <20110707092802.GA2486@arm.com>

[Resent, without html, sorry]

Hi Russell & Dave,

On Thu, Jul 7, 2011 at 2:28 AM, Dave Martin <dave.martin@linaro.org> wrote:
> On Wed, Jul 06, 2011 at 09:06:07PM +0100, Russell King - ARM Linux wrote:
>>
>> Sorry, I've finally got back to looking at this.
>>
>> +               ".pushsection .rodata.str, \"aMS\", 1\n"        \
>>
>> According to my gas manual:
>>
>> | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]'
>> | ...
[snip]
>> It appears that the TYPE argument is missing.  As the GAS manual says
>> its required, then I think it really ought to be there.  Any comment?
>
> I guess type should be %progbits.  That's what the compiler generates for
> the assembler input in similar situations.
>
> Interestingly, gas does not require this argument and seems to default to
> progbits anyway ... but it seems best to do what the manual says.
>

Thanks for this. I will update the patch and resend to the list.

Regards,
Simon

> Cheers
> ---Dave
>

WARNING: multiple messages have this Message-ID (diff)
From: sjg@chromium.org (Simon Glass)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: Use generic BUG() handler
Date: Mon, 11 Jul 2011 17:01:22 -0700	[thread overview]
Message-ID: <CAPnjgZ1-wPW1WyR0nC1R5BkLSwc54evb5gV0dpSEOM4duS4omg@mail.gmail.com> (raw)
In-Reply-To: <20110707092802.GA2486@arm.com>

[Resent, without html, sorry]

Hi Russell & Dave,

On Thu, Jul 7, 2011 at 2:28 AM, Dave Martin <dave.martin@linaro.org> wrote:
> On Wed, Jul 06, 2011 at 09:06:07PM +0100, Russell King - ARM Linux wrote:
>>
>> Sorry, I've finally got back to looking at this.
>>
>> + ? ? ? ? ? ? ? ".pushsection .rodata.str, \"aMS\", 1\n" ? ? ? ?\
>>
>> According to my gas manual:
>>
>> | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]'
>> | ...
[snip]
>> It appears that the TYPE argument is missing. ?As the GAS manual says
>> its required, then I think it really ought to be there. ?Any comment?
>
> I guess type should be %progbits. ?That's what the compiler generates for
> the assembler input in similar situations.
>
> Interestingly, gas does not require this argument and seems to default to
> progbits anyway ... but it seems best to do what the manual says.
>

Thanks for this. I will update the patch and resend to the list.

Regards,
Simon

> Cheers
> ---Dave
>

  reply	other threads:[~2011-07-12  0:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14 23:00 [PATCH v4] ARM: Use generic BUG() handler Simon Glass
2011-04-14 23:00 ` Simon Glass
2011-04-15  2:10 ` Stephen Boyd
2011-04-15  2:10   ` Stephen Boyd
2011-04-20  2:40   ` Simon Glass
2011-04-20  2:40     ` Simon Glass
2011-04-20  4:43     ` anish singh
2011-04-20 18:01       ` Stephen Boyd
2011-04-20 18:01         ` Stephen Boyd
2011-04-20 18:37         ` Ramirez Luna, Omar
2011-04-20 18:37           ` Ramirez Luna, Omar
2011-04-26  1:47         ` Olof Johansson
2011-04-26  1:47           ` Olof Johansson
2011-05-20  5:24           ` Simon Glass
2011-05-20  5:24             ` Simon Glass
2011-07-06 20:06             ` Russell King - ARM Linux
2011-07-06 20:06               ` Russell King - ARM Linux
2011-07-07  9:28               ` Dave Martin
2011-07-07  9:28                 ` Dave Martin
2011-07-12  0:01                 ` Simon Glass [this message]
2011-07-12  0:01                   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1-wPW1WyR0nC1R5BkLSwc54evb5gV0dpSEOM4duS4omg@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=anish198519851985@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=dave.martin@linaro.org \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=joe@perches.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.pitre@linaro.org \
    --cc=olof@lixom.net \
    --cc=omar.ramirez@ti.com \
    --cc=rabin@rab.in \
    --cc=sboyd@codeaurora.org \
    --cc=tony@atomide.com \
    --cc=virtuoso@slind.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.