* [PATCH 0/2] Drop useless call to debug_uart_init
@ 2023-08-02 17:05 Massimo Pegorer
2023-08-02 17:05 ` [PATCH 1/2] rockchip: spl: " Massimo Pegorer
2023-08-02 17:05 ` [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init Massimo Pegorer
0 siblings, 2 replies; 7+ messages in thread
From: Massimo Pegorer @ 2023-08-02 17:05 UTC (permalink / raw)
To: u-boot, Simon Glass, Philipp Tomsich, Kever Yang; +Cc: Massimo Pegorer
Since commit 0dba45864b2a ("arm: Init the debug UART") function
debug_uart_init is called in crt files _main before calling
board_init_f.
Therefore, there is no need to call it again inside board_init_f
implementation as was done in arch/arm/mach-rockchip/spl.c.
Remove also debug message related to debug uart initializazion
in board_init_f. If an earliest-as-possible message after debug
uart initialization is needed, enable DEBUG_UART_ANNOUNCE Kconfig
option, instead.
Massimo Pegorer (2):
rockchip: spl: Drop useless call to debug_uart_init
rockchip: spl: Drop out of scope debug message related to uart init
arch/arm/mach-rockchip/spl.c | 13 -------------
1 file changed, 13 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init
2023-08-02 17:05 [PATCH 0/2] Drop useless call to debug_uart_init Massimo Pegorer
@ 2023-08-02 17:05 ` Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
2023-08-02 17:05 ` [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init Massimo Pegorer
1 sibling, 2 replies; 7+ messages in thread
From: Massimo Pegorer @ 2023-08-02 17:05 UTC (permalink / raw)
To: u-boot, Simon Glass, Philipp Tomsich, Kever Yang; +Cc: Massimo Pegorer
Since commit 0dba45864b2a ("arm: Init the debug UART") function
debug_uart_init is called in crt files _main before calling
board_init_f. Therefore, there is no need to call it again
inside board_init_f implementation in arm/mach-rockchip/spl.c.
Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
arch/arm/mach-rockchip/spl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c
index 30be640425..a6396b3c42 100644
--- a/arch/arm/mach-rockchip/spl.c
+++ b/arch/arm/mach-rockchip/spl.c
@@ -116,12 +116,10 @@ void board_init_f(ulong dummy)
/*
* Debug UART can be used from here if required:
*
- * debug_uart_init();
* printch('a');
* printhex8(0x1234);
* printascii("string");
*/
- debug_uart_init();
debug("\nspl:debug uart enabled in %s\n", __func__);
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init
2023-08-02 17:05 [PATCH 0/2] Drop useless call to debug_uart_init Massimo Pegorer
2023-08-02 17:05 ` [PATCH 1/2] rockchip: spl: " Massimo Pegorer
@ 2023-08-02 17:05 ` Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
1 sibling, 2 replies; 7+ messages in thread
From: Massimo Pegorer @ 2023-08-02 17:05 UTC (permalink / raw)
To: u-boot, Simon Glass, Philipp Tomsich, Kever Yang; +Cc: Massimo Pegorer
Debug uart is no more inited in board_init_f function: remove this
debug message from board_init_f. If an earliest-as-possible message
after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE
Kconfig option, instead.
Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
arch/arm/mach-rockchip/spl.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c
index a6396b3c42..87280e2ba7 100644
--- a/arch/arm/mach-rockchip/spl.c
+++ b/arch/arm/mach-rockchip/spl.c
@@ -112,17 +112,6 @@ void board_init_f(ulong dummy)
{
int ret;
-#ifdef CONFIG_DEBUG_UART
- /*
- * Debug UART can be used from here if required:
- *
- * printch('a');
- * printhex8(0x1234);
- * printascii("string");
- */
- debug("\nspl:debug uart enabled in %s\n", __func__);
-#endif
-
board_early_init_f();
ret = spl_early_init();
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init
2023-08-02 17:05 ` [PATCH 1/2] rockchip: spl: " Massimo Pegorer
@ 2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
1 sibling, 0 replies; 7+ messages in thread
From: Simon Glass @ 2023-08-02 21:31 UTC (permalink / raw)
To: Massimo Pegorer; +Cc: u-boot, Philipp Tomsich, Kever Yang, Massimo Pegorer
On Wed, 2 Aug 2023 at 11:05, Massimo Pegorer <massimo.pegorer@gmail.com> wrote:
>
> Since commit 0dba45864b2a ("arm: Init the debug UART") function
> debug_uart_init is called in crt files _main before calling
> board_init_f. Therefore, there is no need to call it again
> inside board_init_f implementation in arm/mach-rockchip/spl.c.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> ---
> arch/arm/mach-rockchip/spl.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init
2023-08-02 17:05 ` [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init Massimo Pegorer
@ 2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
1 sibling, 0 replies; 7+ messages in thread
From: Simon Glass @ 2023-08-02 21:31 UTC (permalink / raw)
To: Massimo Pegorer; +Cc: u-boot, Philipp Tomsich, Kever Yang, Massimo Pegorer
On Wed, 2 Aug 2023 at 11:05, Massimo Pegorer <massimo.pegorer@gmail.com> wrote:
>
> Debug uart is no more inited in board_init_f function: remove this
> debug message from board_init_f. If an earliest-as-possible message
> after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE
> Kconfig option, instead.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> ---
> arch/arm/mach-rockchip/spl.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init
2023-08-02 17:05 ` [PATCH 1/2] rockchip: spl: " Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
@ 2023-08-12 2:36 ` Kever Yang
1 sibling, 0 replies; 7+ messages in thread
From: Kever Yang @ 2023-08-12 2:36 UTC (permalink / raw)
To: Massimo Pegorer, u-boot, Simon Glass, Philipp Tomsich; +Cc: Massimo Pegorer
On 2023/8/3 01:05, Massimo Pegorer wrote:
> Since commit 0dba45864b2a ("arm: Init the debug UART") function
> debug_uart_init is called in crt files _main before calling
> board_init_f. Therefore, there is no need to call it again
> inside board_init_f implementation in arm/mach-rockchip/spl.c.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/mach-rockchip/spl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c
> index 30be640425..a6396b3c42 100644
> --- a/arch/arm/mach-rockchip/spl.c
> +++ b/arch/arm/mach-rockchip/spl.c
> @@ -116,12 +116,10 @@ void board_init_f(ulong dummy)
> /*
> * Debug UART can be used from here if required:
> *
> - * debug_uart_init();
> * printch('a');
> * printhex8(0x1234);
> * printascii("string");
> */
> - debug_uart_init();
> debug("\nspl:debug uart enabled in %s\n", __func__);
> #endif
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init
2023-08-02 17:05 ` [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
@ 2023-08-12 2:36 ` Kever Yang
1 sibling, 0 replies; 7+ messages in thread
From: Kever Yang @ 2023-08-12 2:36 UTC (permalink / raw)
To: Massimo Pegorer, u-boot, Simon Glass, Philipp Tomsich; +Cc: Massimo Pegorer
On 2023/8/3 01:05, Massimo Pegorer wrote:
> Debug uart is no more inited in board_init_f function: remove this
> debug message from board_init_f. If an earliest-as-possible message
> after debug uart initialization is needed, enable DEBUG_UART_ANNOUNCE
> Kconfig option, instead.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/mach-rockchip/spl.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c
> index a6396b3c42..87280e2ba7 100644
> --- a/arch/arm/mach-rockchip/spl.c
> +++ b/arch/arm/mach-rockchip/spl.c
> @@ -112,17 +112,6 @@ void board_init_f(ulong dummy)
> {
> int ret;
>
> -#ifdef CONFIG_DEBUG_UART
> - /*
> - * Debug UART can be used from here if required:
> - *
> - * printch('a');
> - * printhex8(0x1234);
> - * printascii("string");
> - */
> - debug("\nspl:debug uart enabled in %s\n", __func__);
> -#endif
> -
> board_early_init_f();
>
> ret = spl_early_init();
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-12 2:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 17:05 [PATCH 0/2] Drop useless call to debug_uart_init Massimo Pegorer
2023-08-02 17:05 ` [PATCH 1/2] rockchip: spl: " Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
2023-08-02 17:05 ` [PATCH 2/2] rockchip: spl: Drop out of scope debug message related to uart init Massimo Pegorer
2023-08-02 21:31 ` Simon Glass
2023-08-12 2:36 ` Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.