* [U-Boot] [PATCH] pci: correct a function description
@ 2017-03-22 8:07 Zhiqiang Hou
2017-03-22 8:52 ` Bin Meng
0 siblings, 1 reply; 4+ messages in thread
From: Zhiqiang Hou @ 2017-03-22 8:07 UTC (permalink / raw)
To: u-boot
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
In the description of function pci_match_one_id(), there are some
problems on arguments list and return value description, so correct
them.
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
drivers/pci/pci-uclass.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index a1408f5..40f59c0 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -551,9 +551,10 @@ int dm_pci_hose_probe_bus(struct udevice *bus)
* pci_match_one_device - Tell if a PCI device structure has a matching
* PCI device id structure
* @id: single PCI device id structure to match
- * @dev: the PCI device structure to match against
+ * @find: the PCI device id structure to match against
*
- * Returns the matching pci_device_id structure or %NULL if there is no match.
+ * Returns true if the finding pci_device_id structure matched or false if
+ * there is no match.
*/
static bool pci_match_one_id(const struct pci_device_id *id,
const struct pci_device_id *find)
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] pci: correct a function description
2017-03-22 8:07 [U-Boot] [PATCH] pci: correct a function description Zhiqiang Hou
@ 2017-03-22 8:52 ` Bin Meng
2017-03-22 9:12 ` Z.Q. Hou
0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2017-03-22 8:52 UTC (permalink / raw)
To: u-boot
On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> In the description of function pci_match_one_id(), there are some
> problems on arguments list and return value description, so correct
> them.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> drivers/pci/pci-uclass.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] pci: correct a function description
2017-03-22 8:52 ` Bin Meng
@ 2017-03-22 9:12 ` Z.Q. Hou
2017-03-27 2:27 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Z.Q. Hou @ 2017-03-22 9:12 UTC (permalink / raw)
To: u-boot
Hi Bin,
Thanks for your review.
- Zhiqiang
> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: 2017年3月22日 16:52
> To: Z.Q. Hou <zhiqiang.hou@nxp.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Simon Glass
> <sjg@chromium.org>
> Subject: Re: [PATCH] pci: correct a function description
>
> On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
> wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > In the description of function pci_match_one_id(), there are some
> > problems on arguments list and return value description, so correct
> > them.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > drivers/pci/pci-uclass.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] pci: correct a function description
2017-03-22 9:12 ` Z.Q. Hou
@ 2017-03-27 2:27 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2017-03-27 2:27 UTC (permalink / raw)
To: u-boot
On 22 March 2017 at 03:12, Z.Q. Hou <zhiqiang.hou@nxp.com> wrote:
> Hi Bin,
>
> Thanks for your review.
>
> - Zhiqiang
>
>> -----Original Message-----
>> From: Bin Meng [mailto:bmeng.cn at gmail.com]
>> Sent: 2017年3月22日 16:52
>> To: Z.Q. Hou <zhiqiang.hou@nxp.com>
>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Simon Glass
>> <sjg@chromium.org>
>> Subject: Re: [PATCH] pci: correct a function description
>>
>> On Wed, Mar 22, 2017 at 4:07 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
>> wrote:
>> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> >
>> > In the description of function pci_match_one_id(), there are some
>> > problems on arguments list and return value description, so correct
>> > them.
>> >
>> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> > ---
>> > drivers/pci/pci-uclass.c | 5 +++--
>> > 1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>>
>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-27 2:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 8:07 [U-Boot] [PATCH] pci: correct a function description Zhiqiang Hou
2017-03-22 8:52 ` Bin Meng
2017-03-22 9:12 ` Z.Q. Hou
2017-03-27 2:27 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.