* [PATCH 1/1] test: test field truncation in snprint()
@ 2022-01-29 15:33 Heinrich Schuchardt
2022-02-11 15:05 ` Simon Glass
2022-02-11 17:06 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2022-01-29 15:33 UTC (permalink / raw)
To: Simon Glass
Cc: Artem Lapkin, Bin Meng, Sean Anderson, Pali Rohár, u-boot,
Heinrich Schuchardt
The output size for snprint() should not only be respected for whole fields
but also with fields. Add more tests.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
test/print_ut.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/test/print_ut.c b/test/print_ut.c
index 194387f169..8b3e0ea418 100644
--- a/test/print_ut.c
+++ b/test/print_ut.c
@@ -370,6 +370,18 @@ static int snprint(struct unit_test_state *uts)
char buf[10] = "xxxxxxxxx";
int ret;
+ ret = snprintf(buf, 5, "%d", 12345678);
+ ut_asserteq_str("1234", buf);
+ ut_asserteq(8, ret);
+ ret = snprintf(buf, 5, "0x%x", 0x1234);
+ ut_asserteq_str("0x12", buf);
+ ut_asserteq(6, ret);
+ ret = snprintf(buf, 5, "0x%08x", 0x1234);
+ ut_asserteq_str("0x00", buf);
+ ut_asserteq(10, ret);
+ ret = snprintf(buf, 3, "%s", "abc");
+ ut_asserteq_str("ab", buf);
+ ut_asserteq(3, ret);
ret = snprintf(buf, 4, "%s:%s", "abc", "def");
ut_asserteq(0, buf[3]);
ut_asserteq(7, ret);
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] test: test field truncation in snprint()
2022-01-29 15:33 [PATCH 1/1] test: test field truncation in snprint() Heinrich Schuchardt
@ 2022-02-11 15:05 ` Simon Glass
2022-02-11 17:06 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-02-11 15:05 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Artem Lapkin, Bin Meng, Sean Anderson, Pali Rohár,
U-Boot Mailing List
On Sat, 29 Jan 2022 at 08:33, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> The output size for snprint() should not only be respected for whole fields
> but also with fields. Add more tests.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> test/print_ut.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] test: test field truncation in snprint()
2022-01-29 15:33 [PATCH 1/1] test: test field truncation in snprint() Heinrich Schuchardt
2022-02-11 15:05 ` Simon Glass
@ 2022-02-11 17:06 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-02-11 17:06 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Simon Glass, Artem Lapkin, Bin Meng, Sean Anderson,
Pali Rohár, u-boot
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
On Sat, Jan 29, 2022 at 04:33:16PM +0100, Heinrich Schuchardt wrote:
> The output size for snprint() should not only be respected for whole fields
> but also with fields. Add more tests.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-11 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 15:33 [PATCH 1/1] test: test field truncation in snprint() Heinrich Schuchardt
2022-02-11 15:05 ` Simon Glass
2022-02-11 17:06 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.