* [PATCH] dm: core: Correct comment on uclass_id_foreach_dev()
@ 2020-06-14 14:48 Simon Glass
2020-06-14 15:00 ` Michael Nazzareno Trimarchi
2020-07-06 1:31 ` Simon Glass
0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2020-06-14 14:48 UTC (permalink / raw)
To: u-boot
This parameter should be a struct uclass, not struct udevice. Correct it.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
include/dm/uclass.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dm/uclass.h b/include/dm/uclass.h
index 70fca79b44..67ff7466c8 100644
--- a/include/dm/uclass.h
+++ b/include/dm/uclass.h
@@ -390,7 +390,7 @@ int uclass_resolve_seq(struct udevice *dev);
* @id: enum uclass_id ID to use
* @pos: struct udevice * to hold the current device. Set to NULL when there
* are no more devices.
- * @uc: temporary uclass variable (struct udevice *)
+ * @uc: temporary uclass variable (struct uclass *)
*/
#define uclass_id_foreach_dev(id, pos, uc) \
if (!uclass_get(id, &uc)) \
--
2.27.0.290.gba653c62da-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dm: core: Correct comment on uclass_id_foreach_dev()
2020-06-14 14:48 [PATCH] dm: core: Correct comment on uclass_id_foreach_dev() Simon Glass
@ 2020-06-14 15:00 ` Michael Nazzareno Trimarchi
2020-07-06 1:31 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Michael Nazzareno Trimarchi @ 2020-06-14 15:00 UTC (permalink / raw)
To: u-boot
On Sun, Jun 14, 2020 at 4:49 PM Simon Glass <sjg@chromium.org> wrote:
>
> This parameter should be a struct uclass, not struct udevice. Correct it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> include/dm/uclass.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dm/uclass.h b/include/dm/uclass.h
> index 70fca79b44..67ff7466c8 100644
> --- a/include/dm/uclass.h
> +++ b/include/dm/uclass.h
> @@ -390,7 +390,7 @@ int uclass_resolve_seq(struct udevice *dev);
> * @id: enum uclass_id ID to use
> * @pos: struct udevice * to hold the current device. Set to NULL when there
> * are no more devices.
> - * @uc: temporary uclass variable (struct udevice *)
> + * @uc: temporary uclass variable (struct uclass *)
> */
> #define uclass_id_foreach_dev(id, pos, uc) \
> if (!uclass_get(id, &uc)) \
> --
> 2.27.0.290.gba653c62da-goog
>
Reviewed-By: Michael Trimarchi <michael@amarulasolutions.com>
--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dm: core: Correct comment on uclass_id_foreach_dev()
2020-06-14 14:48 [PATCH] dm: core: Correct comment on uclass_id_foreach_dev() Simon Glass
2020-06-14 15:00 ` Michael Nazzareno Trimarchi
@ 2020-07-06 1:31 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-07-06 1:31 UTC (permalink / raw)
To: u-boot
On Sun, Jun 14, 2020 at 4:49 PM Simon Glass <sjg@chromium.org> wrote:
>
> This parameter should be a struct uclass, not struct udevice. Correct it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> include/dm/uclass.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-dm/next, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 14:48 [PATCH] dm: core: Correct comment on uclass_id_foreach_dev() Simon Glass
2020-06-14 15:00 ` Michael Nazzareno Trimarchi
2020-07-06 1:31 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.