[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Marek Vasut]

Tweak the tiny printf code to also provide similarly tiny sprintf()
implementation. This is not comformant with POSIX for sure, but it
keeps the size down while still behaving rather reasonably.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 lib/tiny-printf.c | 38 +++++++++++++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 5 deletions(-)

diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c
index a06abed..b9fba97 100644
--- a/lib/tiny-printf.c
+++ b/lib/tiny-printf.c
@@ -40,7 +40,17 @@ static void div_out(unsigned int *num, unsigned int div)
 		out_dgt(dgt);
 }
 
-int vprintf(const char *fmt, va_list va)
+#ifdef CONFIG_USE_TINY_SPRINTF
+#define local_putc(pbuf, ch)			\
+	if (pbuf)				\
+		*(pbuf)++ = (ch);		\
+	else					\
+		putc(ch);
+#else
+	#define local_putc(pbuf, ch)	putc(ch)
+#endif
+
+static int local_xprintf(char *pbuf, const char *fmt, va_list va)
 {
 	char ch;
 	char *p;
@@ -50,7 +60,7 @@ int vprintf(const char *fmt, va_list va)
 
 	while ((ch = *(fmt++))) {
 		if (ch != '%') {
-			putc(ch);
+			local_putc(pbuf, ch);
 		} else {
 			char lz = 0;
 			char w = 0;
@@ -115,10 +125,10 @@ int vprintf(const char *fmt, va_list va)
 			while (*bf++ && w > 0)
 				w--;
 			while (w-- > 0)
-				putc(lz ? '0' : ' ');
+				local_putc(pbuf, lz ? '0' : ' ');
 			if (p) {
 				while ((ch = *p++))
-					putc(ch);
+					local_putc(pbuf, ch);
 			}
 		}
 	}
@@ -127,13 +137,31 @@ abort:
 	return 0;
 }
 
+
+int vprintf(const char *fmt, va_list va)
+{
+	return local_xprintf(NULL, fmt, va);
+}
+
 int printf(const char *fmt, ...)
 {
 	va_list va;
 	int ret;
 
 	va_start(va, fmt);
-	ret = vprintf(fmt, va);
+	ret = local_xprintf(NULL, fmt, va);
+	va_end(va);
+
+	return ret;
+}
+
+int sprintf(char *buf, const char *fmt, ...)
+{
+	va_list va;
+	int ret;
+
+	va_start(va, fmt);
+	ret = local_xprintf(buf, fmt, va);
 	va_end(va);
 
 	return ret;
-- 
2.7.0

[U-Boot] [PATCH 2/2] [RFC] ARM: omap: Enable tiny printf/sprintf on omap3_logic

[Marek Vasut]

Enable support for tiny printf and tiny sprintf on the omap3_logic
board to trim down the SPL size. This makes the SPL actually build
again and fit into the SRAM.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 include/configs/omap3_logic.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/configs/omap3_logic.h b/include/configs/omap3_logic.h
index 3c11e2a..8ff5f66 100644
--- a/include/configs/omap3_logic.h
+++ b/include/configs/omap3_logic.h
@@ -290,6 +290,11 @@
 
 #define CONFIG_SPL_OMAP3_ID_NAND
 
+#ifdef CONFIG_SPL_BUILD
+#define CONFIG_USE_TINY_PRINTF
+#define CONFIG_USE_TINY_SPRINTF
+#endif
+
 /* NAND: SPL falcon mode configs */
 #ifdef CONFIG_SPL_OS_BOOT
 #define CONFIG_CMD_SPL_NAND_OFS		0x240000
-- 
2.7.0

[U-Boot] [PATCH 2/2] [RFC] ARM: omap: Enable tiny printf/sprintf on omap3_logic

[Tom Rini]

On Thu, May 26, 2016 at 06:00:25PM +0200, Marek Vasut wrote:

> Enable support for tiny printf and tiny sprintf on the omap3_logic
> board to trim down the SPL size. This makes the SPL actually build
> again and fit into the SRAM.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

... but can you Kconfig this after? :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160530/0e0f42b8/attachment.sig>

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Tom Rini]

On Thu, May 26, 2016 at 06:00:24PM +0200, Marek Vasut wrote:

> Tweak the tiny printf code to also provide similarly tiny sprintf()
> implementation. This is not comformant with POSIX for sure, but it
> keeps the size down while still behaving rather reasonably.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160530/125c3f77/attachment.sig>

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Marek Vasut]

On 05/30/2016 07:55 PM, Tom Rini wrote:
> On Thu, May 26, 2016 at 06:00:24PM +0200, Marek Vasut wrote:
> 
>> Tweak the tiny printf code to also provide similarly tiny sprintf()
>> implementation. This is not comformant with POSIX for sure, but it
>> keeps the size down while still behaving rather reasonably.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
Mind you, I really dislike how I "implemented" this, it's really more of
a vulgar hack. Do you have any comments on this patch ?

-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 2/2] [RFC] ARM: omap: Enable tiny printf/sprintf on omap3_logic

[Marek Vasut]

On 05/30/2016 07:55 PM, Tom Rini wrote:
> On Thu, May 26, 2016 at 06:00:25PM +0200, Marek Vasut wrote:
> 
>> Enable support for tiny printf and tiny sprintf on the omap3_logic
>> board to trim down the SPL size. This makes the SPL actually build
>> again and fit into the SRAM.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> ... but can you Kconfig this after? :)
> 
I can, but I'd like comments on patch 1/2 . Are you OK with this stuff ?

-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Simon Glass]

Hi,

On 31 May 2016 at 05:55, Tom Rini <trini@konsulko.com> wrote:
> On Thu, May 26, 2016 at 06:00:24PM +0200, Marek Vasut wrote:
>
>> Tweak the tiny printf code to also provide similarly tiny sprintf()
>> implementation. This is not comformant with POSIX for sure, but it
>> keeps the size down while still behaving rather reasonably.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Also please see this one:

http://patchwork.ozlabs.org/patch/622267/

It uses a function passed in.

Regards,
Simon

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Marek Vasut]

On 05/31/2016 08:19 PM, Simon Glass wrote:
> Hi,
> 
> On 31 May 2016 at 05:55, Tom Rini <trini@konsulko.com> wrote:
>> On Thu, May 26, 2016 at 06:00:24PM +0200, Marek Vasut wrote:
>>
>>> Tweak the tiny printf code to also provide similarly tiny sprintf()
>>> implementation. This is not comformant with POSIX for sure, but it
>>> keeps the size down while still behaving rather reasonably.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Tom Rini <trini@konsulko.com>
>>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> Also please see this one:
> 
> http://patchwork.ozlabs.org/patch/622267/
> 
> It uses a function passed in.

Oh, I knew I saw some s*printf() stuff from you. Works for me :)

-- 
Best regards,
Marek Vasut

[U-Boot] [PATCH 1/2] [RFC] lib: Implement support for tiny sprintf()

[Simon Glass]

Hi Marek,

On 1 June 2016 at 07:36, Marek Vasut <marex@denx.de> wrote:
> On 05/31/2016 08:19 PM, Simon Glass wrote:
>> Hi,
>>
>> On 31 May 2016 at 05:55, Tom Rini <trini@konsulko.com> wrote:
>>> On Thu, May 26, 2016 at 06:00:24PM +0200, Marek Vasut wrote:
>>>
>>>> Tweak the tiny printf code to also provide similarly tiny sprintf()
>>>> implementation. This is not comformant with POSIX for sure, but it
>>>> keeps the size down while still behaving rather reasonably.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>
>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>
>> Also please see this one:
>>
>> http://patchwork.ozlabs.org/patch/622267/
>>
>> It uses a function passed in.
>
> Oh, I knew I saw some s*printf() stuff from you. Works for me :)

OK good. It works for me too but I'm sure it can be improved (code
size, use of division, etc.), so see how you go.

Regards,
Simon