* [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM
2016-12-15 9:21 [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Jaehoon Chung
@ 2016-12-15 9:21 ` Jaehoon Chung
2016-12-17 13:36 ` Minkyu Kang
2016-12-17 22:47 ` Simon Glass
2016-12-15 9:21 ` [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM Jaehoon Chung
` (2 subsequent siblings)
3 siblings, 2 replies; 13+ messages in thread
From: Jaehoon Chung @ 2016-12-15 9:21 UTC (permalink / raw)
To: u-boot
Add the max8998 controller for Driver model.
Samsung S5P series are using max8998 pmic controller.
In future, it should be supported the regulator framework.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/power/pmic/Kconfig | 7 +++++
drivers/power/pmic/Makefile | 1 +
drivers/power/pmic/max8998.c | 61 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 69 insertions(+)
create mode 100644 drivers/power/pmic/max8998.c
diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
index ce204b3..5e244c8 100644
--- a/drivers/power/pmic/Kconfig
+++ b/drivers/power/pmic/Kconfig
@@ -54,6 +54,13 @@ config DM_PMIC_MAX77686
This config enables implementation of driver-model pmic uclass features
for PMIC MAX77686. The driver implements read/write operations.
+config DM_PMIC_MAX8998
+ bool "Enable Driver Model for PMIC MAX8998"
+ depends on DM_PMIC
+ ---help---
+ This config enables implementation of driver-model pmic uclass features
+ for PMIC MAX8998. The driver implements read/write operations.
+
config PMIC_PM8916
bool "Enable Driver Model for Qualcomm PM8916 PMIC"
depends on DM_PMIC
diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
index cd1c694..b4ac7d2 100644
--- a/drivers/power/pmic/Makefile
+++ b/drivers/power/pmic/Makefile
@@ -7,6 +7,7 @@
obj-$(CONFIG_DM_PMIC) += pmic-uclass.o
obj-$(CONFIG_DM_PMIC_MAX77686) += max77686.o
+obj-$(CONFIG_DM_PMIC_MAX8998) += max8998.o
obj-$(CONFIG_DM_PMIC_PFUZE100) += pfuze100.o
obj-$(CONFIG_PMIC_S2MPS11) += s2mps11.o
obj-$(CONFIG_DM_PMIC_SANDBOX) += sandbox.o i2c_pmic_emul.o
diff --git a/drivers/power/pmic/max8998.c b/drivers/power/pmic/max8998.c
new file mode 100644
index 0000000..3baa8da
--- /dev/null
+++ b/drivers/power/pmic/max8998.c
@@ -0,0 +1,61 @@
+/*
+ * Copyright (C) 2016 Samsung Electronics
+ * Jaehoon Chung <jh80.chung@samsung.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <i2c.h>
+#include <power/pmic.h>
+#include <power/max8998_pmic.h>
+#include <errno.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static int max8998_reg_count(struct udevice *dev)
+{
+ return PMIC_NUM_OF_REGS;
+}
+
+static int max8998_write(struct udevice *dev, uint reg, const uint8_t *buff,
+ int len)
+{
+ int ret;
+
+ ret = dm_i2c_write(dev, reg, buff, len);
+ if (ret)
+ error("write error to device: %p register: %#x!", dev, reg);
+
+ return ret;
+}
+
+static int max8998_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
+{
+ int ret;
+
+ ret = dm_i2c_read(dev, reg, buff, len);
+ if (ret)
+ error("read error from device: %p register: %#x!", dev, reg);
+
+ return ret;
+}
+
+static struct dm_pmic_ops max8998_ops = {
+ .reg_count = max8998_reg_count,
+ .read = max8998_read,
+ .write = max8998_write,
+};
+
+static const struct udevice_id max8998_ids[] = {
+ { .compatible = "maxim,max8998" },
+ { }
+};
+
+U_BOOT_DRIVER(pmic_max8998) = {
+ .name = "max8998_pmic",
+ .id = UCLASS_PMIC,
+ .of_match = max8998_ids,
+ .ops = &max8998_ops,
+};
--
2.10.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM
2016-12-15 9:21 ` [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM Jaehoon Chung
@ 2016-12-17 13:36 ` Minkyu Kang
2016-12-17 22:47 ` Simon Glass
1 sibling, 0 replies; 13+ messages in thread
From: Minkyu Kang @ 2016-12-17 13:36 UTC (permalink / raw)
To: u-boot
Hi,
On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Add the max8998 controller for Driver model.
> Samsung S5P series are using max8998 pmic controller.
> In future, it should be supported the regulator framework.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/power/pmic/Kconfig | 7 +++++
> drivers/power/pmic/Makefile | 1 +
> drivers/power/pmic/max8998.c | 61 ++++++++++++++++++++++++++++++
> ++++++++++++++
> 3 files changed, 69 insertions(+)
> create mode 100644 drivers/power/pmic/max8998.c
>
>
>
Reviewed-by: Minkyu Kang <mk7.kang@samsung.com>
Thanks,
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM
2016-12-15 9:21 ` [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM Jaehoon Chung
2016-12-17 13:36 ` Minkyu Kang
@ 2016-12-17 22:47 ` Simon Glass
1 sibling, 0 replies; 13+ messages in thread
From: Simon Glass @ 2016-12-17 22:47 UTC (permalink / raw)
To: u-boot
On 15 December 2016 at 02:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Add the max8998 controller for Driver model.
> Samsung S5P series are using max8998 pmic controller.
> In future, it should be supported the regulator framework.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/power/pmic/Kconfig | 7 +++++
> drivers/power/pmic/Makefile | 1 +
> drivers/power/pmic/max8998.c | 61 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 69 insertions(+)
> create mode 100644 drivers/power/pmic/max8998.c
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM
2016-12-15 9:21 [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Jaehoon Chung
2016-12-15 9:21 ` [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM Jaehoon Chung
@ 2016-12-15 9:21 ` Jaehoon Chung
2016-12-17 13:37 ` Minkyu Kang
2016-12-17 22:47 ` Simon Glass
2016-12-15 9:21 ` [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic Jaehoon Chung
2016-12-21 14:54 ` [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Minkyu Kang
3 siblings, 2 replies; 13+ messages in thread
From: Jaehoon Chung @ 2016-12-15 9:21 UTC (permalink / raw)
To: u-boot
To use driver-model adds the pmic node for max8998.
This is used as kerel device-tree in Linux.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 165 insertions(+)
diff --git a/arch/arm/dts/s5pc1xx-goni.dts b/arch/arm/dts/s5pc1xx-goni.dts
index 7bbfe59..e80132d 100644
--- a/arch/arm/dts/s5pc1xx-goni.dts
+++ b/arch/arm/dts/s5pc1xx-goni.dts
@@ -19,6 +19,7 @@
serial2 = "/serial at e2900800";
console = "/serial at e2900800";
pinctrl0 = &pinctrl0;
+ i2c3 = &i2c_pmic;
};
pinctrl0: pinctrl at e0200000 {
@@ -32,4 +33,168 @@
id = <2>;
};
+ i2c_pmic: i2c-pmic {
+ compatible = "i2c-gpio";
+ gpios = <&gpj4 0 0>, /* sda */
+ <&gpj4 3 0>; /* scl */
+ i2c-gpio,delay-us = <2>; /* ~100 kHz */
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ pmic at 66 {
+ compatible = "maxim,max8998";
+ reg = <0x66 0 0>;
+
+ voltage-regulators {
+ ldo2_reg: LDO2 {
+ regulator-compatible = "LDO2";
+ regulator-name = "VALIVE_1.1V";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-always-on;
+ };
+
+ ldo3_reg: LDO3 {
+ regulator-compatible = "LDO3";
+ regulator-name = "VUSB+MIPI_1.1V";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-always-on;
+ };
+
+ ldo4_reg: LDO4 {
+ regulator-compatible = "LDO4";
+ regulator-name = "VADC_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo5_reg: LDO5 {
+ regulator-compatible = "LDO5";
+ regulator-name = "VTF_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+
+ ldo6_reg: LDO6 {
+ regulator-compatible = "LDO6";
+ regulator-name = "VCC_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo7_reg: LDO7 {
+ regulator-compatible = "LDO7";
+ regulator-name = "VLCD_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo8_reg: LDO8 {
+ regulator-compatible = "LDO8";
+ regulator-name = "VUSB+VDAC_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo9_reg: LDO9 {
+ regulator-compatible = "LDO9";
+ regulator-name = "VCC+VCAM_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+
+ ldo10_reg: LDO10 {
+ regulator-compatible = "LDO10";
+ regulator-name = "VPLL_1.1V";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-boot-on;
+ };
+
+ ldo11_reg: LDO11 {
+ regulator-compatible = "LDO11";
+ regulator-name = "CAM_IO_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+
+ ldo12_reg: LDO12 {
+ regulator-compatible = "LDO12";
+ regulator-name = "CAM_ISP_1.2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ ldo13_reg: LDO13 {
+ regulator-compatible = "LDO13";
+ regulator-name = "CAM_A_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+
+ ldo14_reg: LDO14 {
+ regulator-compatible = "LDO14";
+ regulator-name = "CAM_CIF_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ ldo15_reg: LDO15 {
+ regulator-compatible = "LDO15";
+ regulator-name = "CAM_AF_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo16_reg: LDO16 {
+ regulator-compatible = "LDO16";
+ regulator-name = "VMIPI_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ ldo17_reg: LDO17 {
+ regulator-compatible = "LDO17";
+ regulator-name = "CAM_8M_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ buck1_reg: BUCK1 {
+ regulator-compatible = "BUCK1";
+ regulator-name = "VARM_1.2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ buck2_reg: BUCK2 {
+ regulator-compatible = "BUCK2";
+ regulator-name = "VINT_1.2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+
+ buck3_reg: BUCK3 {
+ regulator-compatible = "BUCK3";
+ regulator-name = "VCC_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ buck4_reg: BUCK4 {
+ regulator-compatible = "BUCK4";
+ regulator-name = "CAM_CORE_1.2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ };
+ };
+ };
+ };
+
};
--
2.10.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM
2016-12-15 9:21 ` [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM Jaehoon Chung
@ 2016-12-17 13:37 ` Minkyu Kang
2016-12-17 22:47 ` Simon Glass
1 sibling, 0 replies; 13+ messages in thread
From: Minkyu Kang @ 2016-12-17 13:37 UTC (permalink / raw)
To: u-boot
Hi,
On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> To use driver-model adds the pmic node for max8998.
> This is used as kerel device-tree in Linux.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++
> ++++++++++++
> 1 file changed, 165 insertions(+)
>
> diff --git a/arch/arm/dts/s5pc1xx-goni.dts b/arch/arm/dts/s5pc1xx-goni.dts
> index 7bbfe59..e80132d 100644
> --- a/arch/arm/dts/s5pc1xx-goni.dts
> +++ b/arch/arm/dts/s5pc1xx-goni.dts
> @@ -19,6 +19,7 @@
> serial2 = "/serial at e2900800";
> console = "/serial at e2900800";
> pinctrl0 = &pinctrl0;
> + i2c3 = &i2c_pmic;
> };
>
> pinctrl0: pinctrl at e0200000 {
> @@ -32,4 +33,168 @@
> id = <2>;
> };
>
> + i2c_pmic: i2c-pmic {
> + compatible = "i2c-gpio";
> + gpios = <&gpj4 0 0>, /* sda */
> + <&gpj4 3 0>; /* scl */
> + i2c-gpio,delay-us = <2>; /* ~100 kHz */
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + pmic at 66 {
> + compatible = "maxim,max8998";
> + reg = <0x66 0 0>;
> +
> + voltage-regulators {
> + ldo2_reg: LDO2 {
> + regulator-compatible = "LDO2";
> + regulator-name = "VALIVE_1.1V";
> + regulator-min-microvolt =
> <1100000>;
> + regulator-max-microvolt =
> <1100000>;
> + regulator-always-on;
> + };
> +
> + ldo3_reg: LDO3 {
> + regulator-compatible = "LDO3";
> + regulator-name = "VUSB+MIPI_1.1V";
> + regulator-min-microvolt =
> <1100000>;
> + regulator-max-microvolt =
> <1100000>;
> + regulator-always-on;
> + };
> +
> + ldo4_reg: LDO4 {
> + regulator-compatible = "LDO4";
> + regulator-name = "VADC_3.3V";
> + regulator-min-microvolt =
> <3300000>;
> + regulator-max-microvolt =
> <3300000>;
> + };
> +
> + ldo5_reg: LDO5 {
> + regulator-compatible = "LDO5";
> + regulator-name = "VTF_2.8V";
> + regulator-min-microvolt =
> <2800000>;
> + regulator-max-microvolt =
> <2800000>;
> + };
> +
> + ldo6_reg: LDO6 {
> + regulator-compatible = "LDO6";
> + regulator-name = "VCC_3.3V";
> + regulator-min-microvolt =
> <3300000>;
> + regulator-max-microvolt =
> <3300000>;
> + };
> +
> + ldo7_reg: LDO7 {
> + regulator-compatible = "LDO7";
> + regulator-name = "VLCD_1.8V";
> + regulator-min-microvolt =
> <1800000>;
> + regulator-max-microvolt =
> <1800000>;
> + regulator-always-on;
> + };
> +
> + ldo8_reg: LDO8 {
> + regulator-compatible = "LDO8";
> + regulator-name = "VUSB+VDAC_3.3V";
> + regulator-min-microvolt =
> <3300000>;
> + regulator-max-microvolt =
> <3300000>;
> + };
> +
> + ldo9_reg: LDO9 {
> + regulator-compatible = "LDO9";
> + regulator-name = "VCC+VCAM_2.8V";
> + regulator-min-microvolt =
> <2800000>;
> + regulator-max-microvolt =
> <2800000>;
> + };
> +
> + ldo10_reg: LDO10 {
> + regulator-compatible = "LDO10";
> + regulator-name = "VPLL_1.1V";
> + regulator-min-microvolt =
> <1100000>;
> + regulator-max-microvolt =
> <1100000>;
> + regulator-boot-on;
> + };
> +
> + ldo11_reg: LDO11 {
> + regulator-compatible = "LDO11";
> + regulator-name = "CAM_IO_2.8V";
> + regulator-min-microvolt =
> <2800000>;
> + regulator-max-microvolt =
> <2800000>;
> + };
> +
> + ldo12_reg: LDO12 {
> + regulator-compatible = "LDO12";
> + regulator-name = "CAM_ISP_1.2V";
> + regulator-min-microvolt =
> <1200000>;
> + regulator-max-microvolt =
> <1200000>;
> + };
> +
> + ldo13_reg: LDO13 {
> + regulator-compatible = "LDO13";
> + regulator-name = "CAM_A_2.8V";
> + regulator-min-microvolt =
> <2800000>;
> + regulator-max-microvolt =
> <2800000>;
> + };
> +
> + ldo14_reg: LDO14 {
> + regulator-compatible = "LDO14";
> + regulator-name = "CAM_CIF_1.8V";
> + regulator-min-microvolt =
> <1800000>;
> + regulator-max-microvolt =
> <1800000>;
> + };
> +
> + ldo15_reg: LDO15 {
> + regulator-compatible = "LDO15";
> + regulator-name = "CAM_AF_3.3V";
> + regulator-min-microvolt =
> <3300000>;
> + regulator-max-microvolt =
> <3300000>;
> + };
> +
> + ldo16_reg: LDO16 {
> + regulator-compatible = "LDO16";
> + regulator-name = "VMIPI_1.8V";
> + regulator-min-microvolt =
> <1800000>;
> + regulator-max-microvolt =
> <1800000>;
> + };
> +
> + ldo17_reg: LDO17 {
> + regulator-compatible = "LDO17";
> + regulator-name = "CAM_8M_1.8V";
> + regulator-min-microvolt =
> <1800000>;
> + regulator-max-microvolt =
> <1800000>;
> + regulator-always-on;
> + };
> +
> + buck1_reg: BUCK1 {
> + regulator-compatible = "BUCK1";
> + regulator-name = "VARM_1.2V";
> + regulator-min-microvolt =
> <1200000>;
> + regulator-max-microvolt =
> <1200000>;
> + };
> +
> + buck2_reg: BUCK2 {
> + regulator-compatible = "BUCK2";
> + regulator-name = "VINT_1.2V";
> + regulator-min-microvolt =
> <1200000>;
> + regulator-max-microvolt =
> <1200000>;
> + };
> +
> + buck3_reg: BUCK3 {
> + regulator-compatible = "BUCK3";
> + regulator-name = "VCC_1.8V";
> + regulator-min-microvolt =
> <1800000>;
> + regulator-max-microvolt =
> <1800000>;
> + regulator-always-on;
> + };
> +
> + buck4_reg: BUCK4 {
> + regulator-compatible = "BUCK4";
> + regulator-name = "CAM_CORE_1.2V";
> + regulator-min-microvolt =
> <1200000>;
> + regulator-max-microvolt =
> <1200000>;
> + regulator-always-on;
> + };
> + };
> + };
> + };
> +
> };
> --
> 2.10.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Reviewed-by: Minkyu Kang <mk7.kang@samsung.com>
Thanks,
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM
2016-12-15 9:21 ` [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM Jaehoon Chung
2016-12-17 13:37 ` Minkyu Kang
@ 2016-12-17 22:47 ` Simon Glass
1 sibling, 0 replies; 13+ messages in thread
From: Simon Glass @ 2016-12-17 22:47 UTC (permalink / raw)
To: u-boot
On 15 December 2016 at 02:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> To use driver-model adds the pmic node for max8998.
> This is used as kerel device-tree in Linux.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 165 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
2016-12-15 9:21 [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Jaehoon Chung
2016-12-15 9:21 ` [U-Boot] [PATCH 1/3] power: pmic: add the max8998 controller for DM Jaehoon Chung
2016-12-15 9:21 ` [U-Boot] [PATCH 2/3] arm: dts: s5pc1xx-goni: add the pmic node for using DM Jaehoon Chung
@ 2016-12-15 9:21 ` Jaehoon Chung
2016-12-17 13:38 ` Minkyu Kang
2016-12-21 14:54 ` [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Minkyu Kang
3 siblings, 1 reply; 13+ messages in thread
From: Jaehoon Chung @ 2016-12-15 9:21 UTC (permalink / raw)
To: u-boot
Enable the DM_PMIC and DM_I2C_GPIO for using max8998 pmic.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
configs/s5p_goni_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/s5p_goni_defconfig b/configs/s5p_goni_defconfig
index 4cbf022..aa61ef4 100644
--- a/configs/s5p_goni_defconfig
+++ b/configs/s5p_goni_defconfig
@@ -29,3 +29,6 @@ CONFIG_USB_GADGET_DOWNLOAD=y
CONFIG_G_DNL_MANUFACTURER="Samsung"
CONFIG_G_DNL_VENDOR_NUM=0x04e8
CONFIG_G_DNL_PRODUCT_NUM=0x6601
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_MAX8998=y
+CONFIG_DM_I2C_GPIO=y
--
2.10.2
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
2016-12-15 9:21 ` [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic Jaehoon Chung
@ 2016-12-17 13:38 ` Minkyu Kang
2016-12-17 22:48 ` Simon Glass
0 siblings, 1 reply; 13+ messages in thread
From: Minkyu Kang @ 2016-12-17 13:38 UTC (permalink / raw)
To: u-boot
Hi,
On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Enable the DM_PMIC and DM_I2C_GPIO for using max8998 pmic.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> configs/s5p_goni_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configs/s5p_goni_defconfig b/configs/s5p_goni_defconfig
> index 4cbf022..aa61ef4 100644
> --- a/configs/s5p_goni_defconfig
> +++ b/configs/s5p_goni_defconfig
> @@ -29,3 +29,6 @@ CONFIG_USB_GADGET_DOWNLOAD=y
> CONFIG_G_DNL_MANUFACTURER="Samsung"
> CONFIG_G_DNL_VENDOR_NUM=0x04e8
> CONFIG_G_DNL_PRODUCT_NUM=0x6601
> +CONFIG_DM_PMIC=y
> +CONFIG_DM_PMIC_MAX8998=y
> +CONFIG_DM_I2C_GPIO=y
> --
> 2.10.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Reviewed-by: Minkyu Kang <mk7.kang@samsung.com>
Thanks,
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
2016-12-17 13:38 ` Minkyu Kang
@ 2016-12-17 22:48 ` Simon Glass
0 siblings, 0 replies; 13+ messages in thread
From: Simon Glass @ 2016-12-17 22:48 UTC (permalink / raw)
To: u-boot
On 17 December 2016 at 06:38, Minkyu Kang <promsoft@gmail.com> wrote:
> Hi,
>
> On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
>> Enable the DM_PMIC and DM_I2C_GPIO for using max8998 pmic.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> configs/s5p_goni_defconfig | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/configs/s5p_goni_defconfig b/configs/s5p_goni_defconfig
>> index 4cbf022..aa61ef4 100644
>> --- a/configs/s5p_goni_defconfig
>> +++ b/configs/s5p_goni_defconfig
>> @@ -29,3 +29,6 @@ CONFIG_USB_GADGET_DOWNLOAD=y
>> CONFIG_G_DNL_MANUFACTURER="Samsung"
>> CONFIG_G_DNL_VENDOR_NUM=0x04e8
>> CONFIG_G_DNL_PRODUCT_NUM=0x6601
>> +CONFIG_DM_PMIC=y
>> +CONFIG_DM_PMIC_MAX8998=y
>> +CONFIG_DM_I2C_GPIO=y
>> --
>> 2.10.2
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
> Reviewed-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC
2016-12-15 9:21 [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Jaehoon Chung
` (2 preceding siblings ...)
2016-12-15 9:21 ` [U-Boot] [PATCH 3/3] configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic Jaehoon Chung
@ 2016-12-21 14:54 ` Minkyu Kang
2016-12-21 22:03 ` Jaehoon Chung
3 siblings, 1 reply; 13+ messages in thread
From: Minkyu Kang @ 2016-12-21 14:54 UTC (permalink / raw)
To: u-boot
Hi,
On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> This patchest is for supporting pmic driver-model on Goni board.
> (Goni board is S5PC110.)
>
> For using that, add the new file as max8998.c for only driver-model.
> pmic_max8998.c is remained for legacy.
> In future, it might be removed. Instead, max8998 should be used.
>
> *dm tree
> serial [ + ] |-- serial at e2900800
> i2c [ ] `-- i2c-pmic
> pmic [ ] `-- pmic at 66
>
> *dm uclass
> uclass 20: i2c
> - * i2c-pmic @ 47f6c6d0, seq 3, (req 3)
>
> uclass 22: i2c_generic
> uclass 42: pmic
> - * pmic at 66 @ 47f6c748, seq 0, (req -1)
>
> * After using pmic command.
> Goni # pmic list
> | Name | Parent name | Parent uclass @
> seq
> | pmic at 66 | i2c-pmic | i2c @ 3
>
> Node, it needs to implement the regulator driver for using regulator
> framework.
>
> Jaehoon Chung (3):
> power: pmic: add the max8998 controller for DM
> arm: dts: s5pc1xx-goni: add the pmic node for using DM
> configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
>
> arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++
> ++++++++++++
> configs/s5p_goni_defconfig | 3 +
> drivers/power/pmic/Kconfig | 7 ++
> drivers/power/pmic/Makefile | 1 +
> drivers/power/pmic/max8998.c | 61 ++++++++++++++++
> 5 files changed, 237 insertions(+)
> create mode 100644 drivers/power/pmic/max8998.c
>
> --
> 2.10.2
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
This patchset seems to ready to submit.
Who will pick this up? power? DM? or samsang?
Thanks,
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC
2016-12-21 14:54 ` [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC Minkyu Kang
@ 2016-12-21 22:03 ` Jaehoon Chung
2016-12-22 9:22 ` Minkyu Kang
0 siblings, 1 reply; 13+ messages in thread
From: Jaehoon Chung @ 2016-12-21 22:03 UTC (permalink / raw)
To: u-boot
Hi,
On 12/21/2016 11:54 PM, Minkyu Kang wrote:
> Hi,
>
> On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
>> This patchest is for supporting pmic driver-model on Goni board.
>> (Goni board is S5PC110.)
>>
>> For using that, add the new file as max8998.c for only driver-model.
>> pmic_max8998.c is remained for legacy.
>> In future, it might be removed. Instead, max8998 should be used.
>>
>> *dm tree
>> serial [ + ] |-- serial at e2900800
>> i2c [ ] `-- i2c-pmic
>> pmic [ ] `-- pmic at 66
>>
>> *dm uclass
>> uclass 20: i2c
>> - * i2c-pmic @ 47f6c6d0, seq 3, (req 3)
>>
>> uclass 22: i2c_generic
>> uclass 42: pmic
>> - * pmic at 66 @ 47f6c748, seq 0, (req -1)
>>
>> * After using pmic command.
>> Goni # pmic list
>> | Name | Parent name | Parent uclass @
>> seq
>> | pmic at 66 | i2c-pmic | i2c @ 3
>>
>> Node, it needs to implement the regulator driver for using regulator
>> framework.
>>
>> Jaehoon Chung (3):
>> power: pmic: add the max8998 controller for DM
>> arm: dts: s5pc1xx-goni: add the pmic node for using DM
>> configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
>>
>> arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++
>> ++++++++++++
>> configs/s5p_goni_defconfig | 3 +
>> drivers/power/pmic/Kconfig | 7 ++
>> drivers/power/pmic/Makefile | 1 +
>> drivers/power/pmic/max8998.c | 61 ++++++++++++++++
>> 5 files changed, 237 insertions(+)
>> create mode 100644 drivers/power/pmic/max8998.c
>>
>> --
>> 2.10.2
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
>
> This patchset seems to ready to submit.
> Who will pick this up? power? DM? or samsang?
Delegated to you (Minkyu), Could you apply on u-boot-samsung?
There is no Power maintainer, now.
I sent the patch for updating Power maintainer, but i didn't reply anything.
Best Regards,
Jaehoon Chung
>
>
> Thanks,
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 0/3] dm: goni: support the DM PMIC
2016-12-21 22:03 ` Jaehoon Chung
@ 2016-12-22 9:22 ` Minkyu Kang
0 siblings, 0 replies; 13+ messages in thread
From: Minkyu Kang @ 2016-12-22 9:22 UTC (permalink / raw)
To: u-boot
2016? 12? 22? (?) 07:03, Jaehoon Chung <jh80.chung@samsung.com>?? ??:
> Hi,
>
>
>
> On 12/21/2016 11:54 PM, Minkyu Kang wrote:
>
> > Hi,
>
> >
>
> > On 15 December 2016 at 18:21, Jaehoon Chung <jh80.chung@samsung.com>
> wrote:
>
> >
>
> >> This patchest is for supporting pmic driver-model on Goni board.
>
> >> (Goni board is S5PC110.)
>
> >>
>
> >> For using that, add the new file as max8998.c for only driver-model.
>
> >> pmic_max8998.c is remained for legacy.
>
> >> In future, it might be removed. Instead, max8998 should be used.
>
> >>
>
> >> *dm tree
>
> >> serial [ + ] |-- serial at e2900800
>
> >> i2c [ ] `-- i2c-pmic
>
> >> pmic [ ] `-- pmic at 66
>
> >>
>
> >> *dm uclass
>
> >> uclass 20: i2c
>
> >> - * i2c-pmic @ 47f6c6d0, seq 3, (req 3)
>
> >>
>
> >> uclass 22: i2c_generic
>
> >> uclass 42: pmic
>
> >> - * pmic at 66 @ 47f6c748, seq 0, (req -1)
>
> >>
>
> >> * After using pmic command.
>
> >> Goni # pmic list
>
> >> | Name | Parent name | Parent uclass
> @
>
> >> seq
>
> >> | pmic at 66 | i2c-pmic | i2c @ 3
>
> >>
>
> >> Node, it needs to implement the regulator driver for using regulator
>
> >> framework.
>
> >>
>
> >> Jaehoon Chung (3):
>
> >> power: pmic: add the max8998 controller for DM
>
> >> arm: dts: s5pc1xx-goni: add the pmic node for using DM
>
> >> configs: enable the DM_PMIC and DM_I2C_GPIO for max8998 pmic
>
> >>
>
> >> arch/arm/dts/s5pc1xx-goni.dts | 165 ++++++++++++++++++++++++++++++
>
> >> ++++++++++++
>
> >> configs/s5p_goni_defconfig | 3 +
>
> >> drivers/power/pmic/Kconfig | 7 ++
>
> >> drivers/power/pmic/Makefile | 1 +
>
> >> drivers/power/pmic/max8998.c | 61 ++++++++++++++++
>
> >> 5 files changed, 237 insertions(+)
>
> >> create mode 100644 drivers/power/pmic/max8998.c
>
> >>
>
> >> --
>
> >> 2.10.2
>
> >>
>
> >> _______________________________________________
>
> >> U-Boot mailing list
>
> >> U-Boot at lists.denx.de
>
> >> http://lists.denx.de/mailman/listinfo/u-boot
>
> >>
>
> >
>
> >
>
> > This patchset seems to ready to submit.
>
> > Who will pick this up? power? DM? or samsang?
>
>
>
> Delegated to you (Minkyu), Could you apply on u-boot-samsung?
>
> There is no Power maintainer, now.
>
> I sent the patch for updating Power maintainer, but i didn't reply
> anything.
>
>
>
> Best Regards,
>
> Jaehoon Chung
>
>
>
> >
>
> >
>
> > Thanks,
>
> >
> applied to u-boot-samsung
> Thanks
Minkyu Kang.
>
>
>
> --
Thanks. Minkyu Kang.
^ permalink raw reply [flat|nested] 13+ messages in thread