* [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs
@ 2018-12-30 9:11 Heinrich Schuchardt
2019-01-05 1:56 ` Simon Glass
2019-01-07 8:19 ` Patrice CHOTARD
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2018-12-30 9:11 UTC (permalink / raw)
To: u-boot
It should not be necessary to adjust CMD_BOOTEFI_HELLO_COMPILE in config
files.
arch/arm/lib/crt0_arm_efi.S cannot be compiled in thumbs mode. We can
disable CMD_BOOTEFI_HELLO_COMPILE for CONFIG_CPU_V7M. So there is no longer
a need to disable it in stm32 configs.
helloworld.efi can be built without problems on x86_64. So there is no need
to disable it in chromebook_link64_defconfig and qemu-x86_64_defconfig.
Same is true for ARM V7A. So do not disable CMD_BOOTEFI_HELLO_COMPILE in
kp_imx6q_tpc_defconfig.
Some architecture checks are already make for EFI_LOADER. There is no need
to repeat them for CMD_BOOTEFI_HELLO_COMPILE
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
cmd/Kconfig | 2 +-
configs/chromebook_link64_defconfig | 1 -
configs/kp_imx6q_tpc_defconfig | 1 -
configs/qemu-x86_64_defconfig | 1 -
configs/stm32f429-discovery_defconfig | 1 -
configs/stm32f429-evaluation_defconfig | 1 -
configs/stm32f469-discovery_defconfig | 1 -
7 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index ea1a325eb3..3ea42e4256 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -226,7 +226,7 @@ config CMD_BOOTEFI
config CMD_BOOTEFI_HELLO_COMPILE
bool "Compile a standard EFI hello world binary for testing"
- depends on CMD_BOOTEFI && (ARM || X86 || RISCV)
+ depends on CMD_BOOTEFI && !CPU_V7M && !SANDBOX
default y
help
This compiles a standard EFI hello world application with U-Boot so
diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
index 074d333dd4..12f26570af 100644
--- a/configs/chromebook_link64_defconfig
+++ b/configs/chromebook_link64_defconfig
@@ -38,7 +38,6 @@ CONFIG_SPL_PCH_SUPPORT=y
CONFIG_SPL_RTC_SUPPORT=y
CONFIG_HUSH_PARSER=y
CONFIG_CMD_CPU=y
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
# CONFIG_CMD_FLASH is not set
CONFIG_CMD_GPIO=y
CONFIG_CMD_SF=y
diff --git a/configs/kp_imx6q_tpc_defconfig b/configs/kp_imx6q_tpc_defconfig
index 5ebbe1dc7c..7689f71101 100644
--- a/configs/kp_imx6q_tpc_defconfig
+++ b/configs/kp_imx6q_tpc_defconfig
@@ -20,7 +20,6 @@ CONFIG_SPL_RAW_IMAGE_SUPPORT=y
CONFIG_SPL_WATCHDOG_SUPPORT=y
CONFIG_AUTOBOOT_KEYED=y
CONFIG_AUTOBOOT_STOP_STR="."
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
# CONFIG_CMD_ELF is not set
# CONFIG_CMD_FLASH is not set
CONFIG_CMD_GPIO=y
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 8d43acd480..34acc09317 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -36,7 +36,6 @@ CONFIG_SPL_PCH_SUPPORT=y
CONFIG_SPL_RTC_SUPPORT=y
CONFIG_HUSH_PARSER=y
CONFIG_CMD_CPU=y
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
CONFIG_CMD_BOOTEFI_SELFTEST=y
# CONFIG_CMD_FLASH is not set
CONFIG_CMD_IDE=y
diff --git a/configs/stm32f429-discovery_defconfig b/configs/stm32f429-discovery_defconfig
index ef0f6f7373..52fa31ffe5 100644
--- a/configs/stm32f429-discovery_defconfig
+++ b/configs/stm32f429-discovery_defconfig
@@ -15,7 +15,6 @@ CONFIG_MISC_INIT_R=y
CONFIG_BOARD_EARLY_INIT_F=y
CONFIG_HUSH_PARSER=y
CONFIG_SYS_PROMPT="U-Boot > "
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
CONFIG_CMD_IMLS=y
# CONFIG_CMD_SETEXPR is not set
CONFIG_CMD_TIMER=y
diff --git a/configs/stm32f429-evaluation_defconfig b/configs/stm32f429-evaluation_defconfig
index 6a2ed2a9b0..cb11b5230d 100644
--- a/configs/stm32f429-evaluation_defconfig
+++ b/configs/stm32f429-evaluation_defconfig
@@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_BOARD_EARLY_INIT_F=y
CONFIG_SYS_PROMPT="U-Boot > "
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
CONFIG_CMD_IMLS=y
CONFIG_CMD_GPT=y
# CONFIG_RANDOM_UUID is not set
diff --git a/configs/stm32f469-discovery_defconfig b/configs/stm32f469-discovery_defconfig
index 0b36c0fc58..5e40df225b 100644
--- a/configs/stm32f469-discovery_defconfig
+++ b/configs/stm32f469-discovery_defconfig
@@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
# CONFIG_DISPLAY_CPUINFO is not set
CONFIG_BOARD_EARLY_INIT_F=y
CONFIG_SYS_PROMPT="U-Boot > "
-# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
CONFIG_CMD_IMLS=y
CONFIG_CMD_GPT=y
# CONFIG_RANDOM_UUID is not set
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs
2018-12-30 9:11 [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs Heinrich Schuchardt
@ 2019-01-05 1:56 ` Simon Glass
2019-01-07 8:19 ` Patrice CHOTARD
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2019-01-05 1:56 UTC (permalink / raw)
To: u-boot
On Sun, 30 Dec 2018 at 02:12, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> It should not be necessary to adjust CMD_BOOTEFI_HELLO_COMPILE in config
> files.
>
> arch/arm/lib/crt0_arm_efi.S cannot be compiled in thumbs mode. We can
> disable CMD_BOOTEFI_HELLO_COMPILE for CONFIG_CPU_V7M. So there is no longer
> a need to disable it in stm32 configs.
>
> helloworld.efi can be built without problems on x86_64. So there is no need
> to disable it in chromebook_link64_defconfig and qemu-x86_64_defconfig.
>
> Same is true for ARM V7A. So do not disable CMD_BOOTEFI_HELLO_COMPILE in
> kp_imx6q_tpc_defconfig.
>
> Some architecture checks are already make for EFI_LOADER. There is no need
> to repeat them for CMD_BOOTEFI_HELLO_COMPILE
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/Kconfig | 2 +-
> configs/chromebook_link64_defconfig | 1 -
For this board:
Reviewed-by: Simon Glass <sjg@chromium.org>
> configs/kp_imx6q_tpc_defconfig | 1 -
> configs/qemu-x86_64_defconfig | 1 -
> configs/stm32f429-discovery_defconfig | 1 -
> configs/stm32f429-evaluation_defconfig | 1 -
> configs/stm32f469-discovery_defconfig | 1 -
> 7 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index ea1a325eb3..3ea42e4256 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -226,7 +226,7 @@ config CMD_BOOTEFI
>
> config CMD_BOOTEFI_HELLO_COMPILE
> bool "Compile a standard EFI hello world binary for testing"
> - depends on CMD_BOOTEFI && (ARM || X86 || RISCV)
> + depends on CMD_BOOTEFI && !CPU_V7M && !SANDBOX
> default y
> help
> This compiles a standard EFI hello world application with U-Boot so
> diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
> index 074d333dd4..12f26570af 100644
> --- a/configs/chromebook_link64_defconfig
> +++ b/configs/chromebook_link64_defconfig
> @@ -38,7 +38,6 @@ CONFIG_SPL_PCH_SUPPORT=y
> CONFIG_SPL_RTC_SUPPORT=y
> CONFIG_HUSH_PARSER=y
> CONFIG_CMD_CPU=y
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_GPIO=y
> CONFIG_CMD_SF=y
> diff --git a/configs/kp_imx6q_tpc_defconfig b/configs/kp_imx6q_tpc_defconfig
> index 5ebbe1dc7c..7689f71101 100644
> --- a/configs/kp_imx6q_tpc_defconfig
> +++ b/configs/kp_imx6q_tpc_defconfig
> @@ -20,7 +20,6 @@ CONFIG_SPL_RAW_IMAGE_SUPPORT=y
> CONFIG_SPL_WATCHDOG_SUPPORT=y
> CONFIG_AUTOBOOT_KEYED=y
> CONFIG_AUTOBOOT_STOP_STR="."
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> # CONFIG_CMD_ELF is not set
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_GPIO=y
> diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
> index 8d43acd480..34acc09317 100644
> --- a/configs/qemu-x86_64_defconfig
> +++ b/configs/qemu-x86_64_defconfig
> @@ -36,7 +36,6 @@ CONFIG_SPL_PCH_SUPPORT=y
> CONFIG_SPL_RTC_SUPPORT=y
> CONFIG_HUSH_PARSER=y
> CONFIG_CMD_CPU=y
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_BOOTEFI_SELFTEST=y
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_IDE=y
> diff --git a/configs/stm32f429-discovery_defconfig b/configs/stm32f429-discovery_defconfig
> index ef0f6f7373..52fa31ffe5 100644
> --- a/configs/stm32f429-discovery_defconfig
> +++ b/configs/stm32f429-discovery_defconfig
> @@ -15,7 +15,6 @@ CONFIG_MISC_INIT_R=y
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_HUSH_PARSER=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> # CONFIG_CMD_SETEXPR is not set
> CONFIG_CMD_TIMER=y
> diff --git a/configs/stm32f429-evaluation_defconfig b/configs/stm32f429-evaluation_defconfig
> index 6a2ed2a9b0..cb11b5230d 100644
> --- a/configs/stm32f429-evaluation_defconfig
> +++ b/configs/stm32f429-evaluation_defconfig
> @@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
> # CONFIG_DISPLAY_CPUINFO is not set
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> CONFIG_CMD_GPT=y
> # CONFIG_RANDOM_UUID is not set
> diff --git a/configs/stm32f469-discovery_defconfig b/configs/stm32f469-discovery_defconfig
> index 0b36c0fc58..5e40df225b 100644
> --- a/configs/stm32f469-discovery_defconfig
> +++ b/configs/stm32f469-discovery_defconfig
> @@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
> # CONFIG_DISPLAY_CPUINFO is not set
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> CONFIG_CMD_GPT=y
> # CONFIG_RANDOM_UUID is not set
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs
2018-12-30 9:11 [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs Heinrich Schuchardt
2019-01-05 1:56 ` Simon Glass
@ 2019-01-07 8:19 ` Patrice CHOTARD
1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2019-01-07 8:19 UTC (permalink / raw)
To: u-boot
Hi Heinrich
On 12/30/18 10:11 AM, Heinrich Schuchardt wrote:
> It should not be necessary to adjust CMD_BOOTEFI_HELLO_COMPILE in config
> files.
>
> arch/arm/lib/crt0_arm_efi.S cannot be compiled in thumbs mode. We can
> disable CMD_BOOTEFI_HELLO_COMPILE for CONFIG_CPU_V7M. So there is no longer
> a need to disable it in stm32 configs.
>
> helloworld.efi can be built without problems on x86_64. So there is no need
> to disable it in chromebook_link64_defconfig and qemu-x86_64_defconfig.
>
> Same is true for ARM V7A. So do not disable CMD_BOOTEFI_HELLO_COMPILE in
> kp_imx6q_tpc_defconfig.
>
> Some architecture checks are already make for EFI_LOADER. There is no need
> to repeat them for CMD_BOOTEFI_HELLO_COMPILE
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cmd/Kconfig | 2 +-
> configs/chromebook_link64_defconfig | 1 -
> configs/kp_imx6q_tpc_defconfig | 1 -
> configs/qemu-x86_64_defconfig | 1 -
> configs/stm32f429-discovery_defconfig | 1 -
> configs/stm32f429-evaluation_defconfig | 1 -
> configs/stm32f469-discovery_defconfig | 1 -
for stm32f429-discovery, stm32f429-evaluation and stm32f469-discovery boards
Reviewed-by: Patrice.Chotard at st.com
Thanks
> 7 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index ea1a325eb3..3ea42e4256 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -226,7 +226,7 @@ config CMD_BOOTEFI
>
> config CMD_BOOTEFI_HELLO_COMPILE
> bool "Compile a standard EFI hello world binary for testing"
> - depends on CMD_BOOTEFI && (ARM || X86 || RISCV)
> + depends on CMD_BOOTEFI && !CPU_V7M && !SANDBOX
> default y
> help
> This compiles a standard EFI hello world application with U-Boot so
> diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig
> index 074d333dd4..12f26570af 100644
> --- a/configs/chromebook_link64_defconfig
> +++ b/configs/chromebook_link64_defconfig
> @@ -38,7 +38,6 @@ CONFIG_SPL_PCH_SUPPORT=y
> CONFIG_SPL_RTC_SUPPORT=y
> CONFIG_HUSH_PARSER=y
> CONFIG_CMD_CPU=y
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_GPIO=y
> CONFIG_CMD_SF=y
> diff --git a/configs/kp_imx6q_tpc_defconfig b/configs/kp_imx6q_tpc_defconfig
> index 5ebbe1dc7c..7689f71101 100644
> --- a/configs/kp_imx6q_tpc_defconfig
> +++ b/configs/kp_imx6q_tpc_defconfig
> @@ -20,7 +20,6 @@ CONFIG_SPL_RAW_IMAGE_SUPPORT=y
> CONFIG_SPL_WATCHDOG_SUPPORT=y
> CONFIG_AUTOBOOT_KEYED=y
> CONFIG_AUTOBOOT_STOP_STR="."
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> # CONFIG_CMD_ELF is not set
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_GPIO=y
> diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
> index 8d43acd480..34acc09317 100644
> --- a/configs/qemu-x86_64_defconfig
> +++ b/configs/qemu-x86_64_defconfig
> @@ -36,7 +36,6 @@ CONFIG_SPL_PCH_SUPPORT=y
> CONFIG_SPL_RTC_SUPPORT=y
> CONFIG_HUSH_PARSER=y
> CONFIG_CMD_CPU=y
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_BOOTEFI_SELFTEST=y
> # CONFIG_CMD_FLASH is not set
> CONFIG_CMD_IDE=y
> diff --git a/configs/stm32f429-discovery_defconfig b/configs/stm32f429-discovery_defconfig
> index ef0f6f7373..52fa31ffe5 100644
> --- a/configs/stm32f429-discovery_defconfig
> +++ b/configs/stm32f429-discovery_defconfig
> @@ -15,7 +15,6 @@ CONFIG_MISC_INIT_R=y
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_HUSH_PARSER=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> # CONFIG_CMD_SETEXPR is not set
> CONFIG_CMD_TIMER=y
> diff --git a/configs/stm32f429-evaluation_defconfig b/configs/stm32f429-evaluation_defconfig
> index 6a2ed2a9b0..cb11b5230d 100644
> --- a/configs/stm32f429-evaluation_defconfig
> +++ b/configs/stm32f429-evaluation_defconfig
> @@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
> # CONFIG_DISPLAY_CPUINFO is not set
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> CONFIG_CMD_GPT=y
> # CONFIG_RANDOM_UUID is not set
> diff --git a/configs/stm32f469-discovery_defconfig b/configs/stm32f469-discovery_defconfig
> index 0b36c0fc58..5e40df225b 100644
> --- a/configs/stm32f469-discovery_defconfig
> +++ b/configs/stm32f469-discovery_defconfig
> @@ -12,7 +12,6 @@ CONFIG_MISC_INIT_R=y
> # CONFIG_DISPLAY_CPUINFO is not set
> CONFIG_BOARD_EARLY_INIT_F=y
> CONFIG_SYS_PROMPT="U-Boot > "
> -# CONFIG_CMD_BOOTEFI_HELLO_COMPILE is not set
> CONFIG_CMD_IMLS=y
> CONFIG_CMD_GPT=y
> # CONFIG_RANDOM_UUID is not set
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-07 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-30 9:11 [U-Boot] [PATCH 1/1] efi_loader: CMD_BOOTEFI_HELLO_COMPILE in configs Heinrich Schuchardt
2019-01-05 1:56 ` Simon Glass
2019-01-07 8:19 ` Patrice CHOTARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.