All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI
@ 2019-01-01 19:17 Jagan Teki
  2019-01-01 19:17 ` [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH Jagan Teki
  2019-01-02 19:19 ` [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki
  0 siblings, 2 replies; 6+ messages in thread
From: Jagan Teki @ 2019-01-01 19:17 UTC (permalink / raw)
  To: u-boot

- v2019.04 for no dm conversion drivers
- v2019.07 for partially converted drivers.

Note: there were many updates on this deadline, so better
not update this again.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- %s/convertion/conversion
- split SPI_FLASH warning in separate patch

 Makefile                       | 11 +++++++++++
 doc/driver-model/MIGRATION.txt | 10 +++++++---
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index a8461dd611..c4d827f259 100644
--- a/Makefile
+++ b/Makefile
@@ -953,6 +953,17 @@ ifeq ($(CONFIG_OF_EMBED),y)
 	@echo >&2 "CONFIG_OF_SEPARATE for boards in mainline."
 	@echo >&2 "See doc/README.fdt-control for more info."
 	@echo >&2 "===================================================="
+endif
+ifeq ($(CONFIG_SPI),y)
+ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board does not use CONFIG_DM_SPI. Please update"
+	@echo >&2 "the board before v2019.04 for no dm conversion"
+	@echo >&2 "and v2019.07 for partially dm converted drivers."
+	@echo >&2 "Failure to update can lead to driver/board removal"
+	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
+	@echo >&2 "===================================================="
+endif
 endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
diff --git a/doc/driver-model/MIGRATION.txt b/doc/driver-model/MIGRATION.txt
index dce4aa3e1d..183d7f5293 100644
--- a/doc/driver-model/MIGRATION.txt
+++ b/doc/driver-model/MIGRATION.txt
@@ -55,9 +55,6 @@ CONFIG_DM_SPI_FLASH
 Board Maintainers should submit the patches for enabling DM_SPI and DM_SPI_FLASH
 to move the migration with in the deadline.
 
-Status: In progress
-Deadline: 2018.09
-
 No dm conversion yet:
 	drivers/spi/cf_spi.c
 	drivers/spi/fsl_espi.c
@@ -69,6 +66,9 @@ No dm conversion yet:
 	drivers/spi/sh_spi.c
 	drivers/spi/soft_spi_legacy.c
 
+	Status: In progress
+	Deadline: 2019.04
+
 Partially converted:
 	drivers/spi/atcspi200_spi.c
 	drivers/spi/davinci_spi.c
@@ -79,6 +79,10 @@ Partially converted:
 	drivers/spi/omap3_spi.c
 	drivers/spi/ti_qspi.c
 
+	Status: In progress
+	Deadline: 2019.07
+
 --
 Jagan Teki <jagan@openedev.com>
+12/24/2018
 03/14/2018
-- 
2.18.0.321.gffc6fa0e3

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH
  2019-01-01 19:17 [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki
@ 2019-01-01 19:17 ` Jagan Teki
  2019-01-05  1:57   ` Simon Glass
  2019-01-02 19:19 ` [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki
  1 sibling, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2019-01-01 19:17 UTC (permalink / raw)
  To: u-boot

Migration plan for DM_SPI_FLASH is v2019.07 since it
depends on DM_SPI migration.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v2:
- none

 Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Makefile b/Makefile
index c4d827f259..3e926d839f 100644
--- a/Makefile
+++ b/Makefile
@@ -964,6 +964,16 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
 	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
 	@echo >&2 "===================================================="
 endif
+endif
+ifeq ($(CONFIG_SPI_FLASH),y)
+ifneq ($(CONFIG_DM_SPI_FLASH)$(CONFIG_OF_CONTROL),yy)
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board does not use CONFIG_DM_SPI_FLASH. Please update"
+	@echo >&2 "the board to use CONFIG_SPI_FLASH before the v2019.07 release."
+	@echo >&2 "Failure to update by the deadline may result in board removal."
+	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
+	@echo >&2 "===================================================="
+endif
 endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
-- 
2.18.0.321.gffc6fa0e3

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI
  2019-01-01 19:17 [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki
  2019-01-01 19:17 ` [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH Jagan Teki
@ 2019-01-02 19:19 ` Jagan Teki
  1 sibling, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2019-01-02 19:19 UTC (permalink / raw)
  To: u-boot

On Wed, Jan 2, 2019 at 12:47 AM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> - v2019.04 for no dm conversion drivers
> - v2019.07 for partially converted drivers.
>
> Note: there were many updates on this deadline, so better
> not update this again.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---

Applied to u-boot-spi/master

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH
  2019-01-01 19:17 ` [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH Jagan Teki
@ 2019-01-05  1:57   ` Simon Glass
  2019-01-05 17:01     ` Jagan Teki
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2019-01-05  1:57 UTC (permalink / raw)
  To: u-boot

Hi Jagan,

On Tue, 1 Jan 2019 at 12:17, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Migration plan for DM_SPI_FLASH is v2019.07 since it
> depends on DM_SPI migration.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v2:
> - none
>
>  Makefile | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c4d827f259..3e926d839f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -964,6 +964,16 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
>         @echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
>         @echo >&2 "===================================================="
>  endif
> +endif
> +ifeq ($(CONFIG_SPI_FLASH),y)

Again i worry what happens if the board does not actually use SPI flash?

> +ifneq ($(CONFIG_DM_SPI_FLASH)$(CONFIG_OF_CONTROL),yy)
> +       @echo >&2 "===================== WARNING ======================"
> +       @echo >&2 "This board does not use CONFIG_DM_SPI_FLASH. Please update"
> +       @echo >&2 "the board to use CONFIG_SPI_FLASH before the v2019.07 release."
> +       @echo >&2 "Failure to update by the deadline may result in board removal."
> +       @echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
> +       @echo >&2 "===================================================="
> +endif
>  endif
>         @# Check that this build does not use CONFIG options that we do not
>         @# know about unless they are in Kconfig. All the existing CONFIG
> --
> 2.18.0.321.gffc6fa0e3
>

Regards,
Simon

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH
  2019-01-05  1:57   ` Simon Glass
@ 2019-01-05 17:01     ` Jagan Teki
  2019-01-07 20:52       ` Simon Glass
  0 siblings, 1 reply; 6+ messages in thread
From: Jagan Teki @ 2019-01-05 17:01 UTC (permalink / raw)
  To: u-boot

On Sat, Jan 5, 2019 at 7:27 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Jagan,
>
> On Tue, 1 Jan 2019 at 12:17, Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > Migration plan for DM_SPI_FLASH is v2019.07 since it
> > depends on DM_SPI migration.
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v2:
> > - none
> >
> >  Makefile | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index c4d827f259..3e926d839f 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -964,6 +964,16 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
> >         @echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
> >         @echo >&2 "===================================================="
> >  endif
> > +endif
> > +ifeq ($(CONFIG_SPI_FLASH),y)
>
> Again i worry what happens if the board does not actually use SPI flash?

If SPI_FLASH not used then it will not enter this loop since its ifeq
(not even to check next ifneq). Did you find any config to enter even
if not used, same case for SPI.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH
  2019-01-05 17:01     ` Jagan Teki
@ 2019-01-07 20:52       ` Simon Glass
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2019-01-07 20:52 UTC (permalink / raw)
  To: u-boot

On Sat, 5 Jan 2019 at 10:01, Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Sat, Jan 5, 2019 at 7:27 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Jagan,
> >
> > On Tue, 1 Jan 2019 at 12:17, Jagan Teki <jagan@amarulasolutions.com> wrote:
> > >
> > > Migration plan for DM_SPI_FLASH is v2019.07 since it
> > > depends on DM_SPI migration.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Changes for v2:
> > > - none
> > >
> > >  Makefile | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index c4d827f259..3e926d839f 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -964,6 +964,16 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
> > >         @echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
> > >         @echo >&2 "===================================================="
> > >  endif
> > > +endif
> > > +ifeq ($(CONFIG_SPI_FLASH),y)
> >
> > Again i worry what happens if the board does not actually use SPI flash?
>
> If SPI_FLASH not used then it will not enter this loop since its ifeq
> (not even to check next ifneq). Did you find any config to enter even
> if not used, same case for SPI.

OK I see.

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-07 20:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-01 19:17 [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki
2019-01-01 19:17 ` [U-Boot] [PATCH v2 2/2] dm: MIGRATION: Update migration plan for DM_SPI_FLASH Jagan Teki
2019-01-05  1:57   ` Simon Glass
2019-01-05 17:01     ` Jagan Teki
2019-01-07 20:52       ` Simon Glass
2019-01-02 19:19 ` [U-Boot] [PATCH v2 1/2] dm: MIGRATION: Update migration plan for SPI Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.