Re: [PATCH v1 1/2] image: Fix typo in boot_get_kbd()

From: Simon Glass <sjg@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ovidiu Panait <ovidiu.panait@windriver.com>, u-boot@lists.denx.de
Subject: Re: [PATCH v1 1/2] image: Fix typo in boot_get_kbd()
Date: Fri, 5 Nov 2021 21:16:25 -0600	[thread overview]
Message-ID: <CAPnjgZ1ar+0h0hwnU+zDP5E1-yrm4fmYj3RhEHs2og4CiEoR=A@mail.gmail.com> (raw)
In-Reply-To: <20211105200952.47866-1-andriy.shevchenko@linux.intel.com>

On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> After the commit 4ed37abc49c2 ("image: Remove ifdefs around
> image_setup_linux() el at"):
>
> common/image-board.c: In function ‘boot_get_kbd’:
> common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’
>   902 |                 do_bdinfo(NULL, 0, 0, NULL);
>       |                 ^~~~~~~~~
> common/image-board.c:901:12: note: to match this ‘(’
>   901 |         if (IS_ENABLED(CONFIG_CMD_BDI)
>       |            ^
> common/image-board.c:906:1: error: expected expression before ‘}’ token
>   906 | }
>       | ^
> common/image-board.c:906:1: warning: control reaches end of non-void function [-Wreturn-type]
>   906 | }
>       | ^
>
> Fix obvious typo.
>
> Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Revert "image: Partially revert too aggressive ifdeferry removal"
>
> This reverts commit 84631af9d0454ff8252c1aebb1e9c232b8077692.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  common/image-board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>