* [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model
@ 2015-12-12 17:04 Vladimir Zapolskiy
2015-12-14 22:13 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Zapolskiy @ 2015-12-12 17:04 UTC (permalink / raw)
To: u-boot
The change ports NXP LPC32xx 14-clock UART device driver to driver
model.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
drivers/serial/lpc32xx_hsuart.c | 103 +++++++++++++++++++-----------
include/dm/platform_data/lpc32xx_hsuart.h | 18 ++++++
2 files changed, 82 insertions(+), 39 deletions(-)
create mode 100644 include/dm/platform_data/lpc32xx_hsuart.h
diff --git a/drivers/serial/lpc32xx_hsuart.c b/drivers/serial/lpc32xx_hsuart.c
index c8926a8..c199c9b 100644
--- a/drivers/serial/lpc32xx_hsuart.c
+++ b/drivers/serial/lpc32xx_hsuart.c
@@ -1,89 +1,114 @@
/*
- * Copyright (C) 2011 Vladimir Zapolskiy <vz@mleia.com>
+ * Copyright (C) 2011-2015 Vladimir Zapolskiy <vz@mleia.com>
*
* SPDX-License-Identifier: GPL-2.0+
*/
#include <common.h>
-#include <asm/arch/cpu.h>
-#include <asm/arch/clk.h>
-#include <asm/arch/uart.h>
-#include <asm/io.h>
+#include <dm.h>
+#include <dm/platform_data/lpc32xx_hsuart.h>
#include <serial.h>
+
+#include <asm/arch/uart.h>
#include <linux/compiler.h>
DECLARE_GLOBAL_DATA_PTR;
-static struct hsuart_regs *hsuart = (struct hsuart_regs *)HS_UART_BASE;
+struct lpc32xx_hsuart_priv {
+ struct hsuart_regs *hsuart;
+};
-static void lpc32xx_serial_setbrg(void)
+static int lpc32xx_serial_setbrg(struct udevice *dev, int baudrate)
{
+ struct lpc32xx_hsuart_priv *priv = dev_get_priv(dev);
+ struct hsuart_regs *hsuart = priv->hsuart;
u32 div;
/* UART rate = PERIPH_CLK / ((HSU_RATE + 1) x 14) */
- div = (get_serial_clock() / 14 + gd->baudrate / 2) / gd->baudrate - 1;
+ div = (get_serial_clock() / 14 + baudrate / 2) / baudrate - 1;
if (div > 255)
div = 255;
writel(div, &hsuart->rate);
+
+ return 0;
}
-static int lpc32xx_serial_getc(void)
+static int lpc32xx_serial_getc(struct udevice *dev)
{
- while (!(readl(&hsuart->level) & HSUART_LEVEL_RX))
- /* NOP */;
+ struct lpc32xx_hsuart_priv *priv = dev_get_priv(dev);
+ struct hsuart_regs *hsuart = priv->hsuart;
+
+ if (!(readl(&hsuart->level) & HSUART_LEVEL_RX))
+ return -EAGAIN;
return readl(&hsuart->rx) & HSUART_RX_DATA;
}
-static void lpc32xx_serial_putc(const char c)
+static int lpc32xx_serial_putc(struct udevice *dev, const char c)
{
- if (c == '\n')
- serial_putc('\r');
+ struct lpc32xx_hsuart_priv *priv = dev_get_priv(dev);
+ struct hsuart_regs *hsuart = priv->hsuart;
+
+ /* Wait for empty FIFO */
+ if (readl(&hsuart->level) & HSUART_LEVEL_TX)
+ return -EAGAIN;
writel(c, &hsuart->tx);
- /* Wait for character to be sent */
- while (readl(&hsuart->level) & HSUART_LEVEL_TX)
- /* NOP */;
+ return 0;
}
-static int lpc32xx_serial_tstc(void)
+static int lpc32xx_serial_pending(struct udevice *dev, bool input)
{
- if (readl(&hsuart->level) & HSUART_LEVEL_RX)
- return 1;
+ struct lpc32xx_hsuart_priv *priv = dev_get_priv(dev);
+ struct hsuart_regs *hsuart = priv->hsuart;
+
+ if (input) {
+ if (readl(&hsuart->level) & HSUART_LEVEL_RX)
+ return 1;
+ } else {
+ if (readl(&hsuart->level) & HSUART_LEVEL_TX)
+ return 1;
+ }
return 0;
}
-static int lpc32xx_serial_init(void)
+static int lpc32xx_serial_init(struct hsuart_regs *hsuart)
{
- lpc32xx_serial_setbrg();
-
/* Disable hardware RTS and CTS flow control, set up RX and TX FIFO */
writel(HSUART_CTRL_TMO_16 | HSUART_CTRL_HSU_OFFSET(20) |
HSUART_CTRL_HSU_RX_TRIG_32 | HSUART_CTRL_HSU_TX_TRIG_0,
&hsuart->ctrl);
+
return 0;
}
-static struct serial_device lpc32xx_serial_drv = {
- .name = "lpc32xx_serial",
- .start = lpc32xx_serial_init,
- .stop = NULL,
+static int lpc32xx_hsuart_probe(struct udevice *dev)
+{
+ struct lpc32xx_hsuart_platdata *platdata = dev_get_platdata(dev);
+ struct lpc32xx_hsuart_priv *priv = dev_get_priv(dev);
+
+ priv->hsuart = (struct hsuart_regs *)platdata->base;
+
+ lpc32xx_serial_init(priv->hsuart);
+
+ return 0;
+}
+
+static const struct dm_serial_ops lpc32xx_hsuart_ops = {
.setbrg = lpc32xx_serial_setbrg,
- .putc = lpc32xx_serial_putc,
- .puts = default_serial_puts,
.getc = lpc32xx_serial_getc,
- .tstc = lpc32xx_serial_tstc,
+ .putc = lpc32xx_serial_putc,
+ .pending = lpc32xx_serial_pending,
};
-void lpc32xx_serial_initialize(void)
-{
- serial_register(&lpc32xx_serial_drv);
-}
-
-__weak struct serial_device *default_serial_console(void)
-{
- return &lpc32xx_serial_drv;
-}
+U_BOOT_DRIVER(lpc32xx_hsuart) = {
+ .name = "lpc32xx_hsuart",
+ .id = UCLASS_SERIAL,
+ .probe = lpc32xx_hsuart_probe,
+ .ops = &lpc32xx_hsuart_ops,
+ .priv_auto_alloc_size = sizeof(struct lpc32xx_hsuart_priv),
+ .flags = DM_FLAG_PRE_RELOC,
+};
diff --git a/include/dm/platform_data/lpc32xx_hsuart.h b/include/dm/platform_data/lpc32xx_hsuart.h
new file mode 100644
index 0000000..fd191b5
--- /dev/null
+++ b/include/dm/platform_data/lpc32xx_hsuart.h
@@ -0,0 +1,18 @@
+/*
+ * Copyright (c) 2015 Vladimir Zapolskiy <vz@mleia.com>
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#ifndef _LPC32XX_HSUART_PLAT_H
+#define _LPC32XX_HSUART_PLAT_H
+
+/**
+ * struct lpc32xx_hsuart_platdata - NXP LPC32xx HSUART platform data
+ *
+ * @base: Base register address
+ */
+struct lpc32xx_hsuart_platdata {
+ unsigned long base;
+};
+
+#endif
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model
2015-12-12 17:04 [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model Vladimir Zapolskiy
@ 2015-12-14 22:13 ` Simon Glass
2015-12-19 20:30 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2015-12-14 22:13 UTC (permalink / raw)
To: u-boot
On 12 December 2015 at 10:04, Vladimir Zapolskiy <vz@mleia.com> wrote:
> The change ports NXP LPC32xx 14-clock UART device driver to driver
> model.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> drivers/serial/lpc32xx_hsuart.c | 103 +++++++++++++++++++-----------
> include/dm/platform_data/lpc32xx_hsuart.h | 18 ++++++
> 2 files changed, 82 insertions(+), 39 deletions(-)
> create mode 100644 include/dm/platform_data/lpc32xx_hsuart.h
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model
2015-12-14 22:13 ` Simon Glass
@ 2015-12-19 20:30 ` Simon Glass
2015-12-19 20:37 ` Vladimir Zapolskiy
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2015-12-19 20:30 UTC (permalink / raw)
To: u-boot
Hi Vladimir,
On 14 December 2015 at 15:13, Simon Glass <sjg@chromium.org> wrote:
> On 12 December 2015 at 10:04, Vladimir Zapolskiy <vz@mleia.com> wrote:
>> The change ports NXP LPC32xx 14-clock UART device driver to driver
>> model.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>> drivers/serial/lpc32xx_hsuart.c | 103 +++++++++++++++++++-----------
>> include/dm/platform_data/lpc32xx_hsuart.h | 18 ++++++
>> 2 files changed, 82 insertions(+), 39 deletions(-)
>> create mode 100644 include/dm/platform_data/lpc32xx_hsuart.h
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
I'm going to hold off applying this for -next right now. Can you
please resend it along with the related patches once you update them?
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model
2015-12-19 20:30 ` Simon Glass
@ 2015-12-19 20:37 ` Vladimir Zapolskiy
0 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2015-12-19 20:37 UTC (permalink / raw)
To: u-boot
Hi Simon,
On 19.12.2015 22:30, Simon Glass wrote:
> Hi Vladimir,
>
> On 14 December 2015 at 15:13, Simon Glass <sjg@chromium.org> wrote:
>> On 12 December 2015 at 10:04, Vladimir Zapolskiy <vz@mleia.com> wrote:
>>> The change ports NXP LPC32xx 14-clock UART device driver to driver
>>> model.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>>> ---
>>> drivers/serial/lpc32xx_hsuart.c | 103 +++++++++++++++++++-----------
>>> include/dm/platform_data/lpc32xx_hsuart.h | 18 ++++++
>>> 2 files changed, 82 insertions(+), 39 deletions(-)
>>> create mode 100644 include/dm/platform_data/lpc32xx_hsuart.h
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I'm going to hold off applying this for -next right now. Can you
> please resend it along with the related patches once you update them?
>
do you want to see the driver update with the mach changes in one series?
FWIW I think this serial driver change is independent and can be applied
first, but for your convenience I'll gather the changes together.
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-19 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-12 17:04 [U-Boot] [PATCH] serial: lpc32xx hsuart: port driver to driver model Vladimir Zapolskiy
2015-12-14 22:13 ` Simon Glass
2015-12-19 20:30 ` Simon Glass
2015-12-19 20:37 ` Vladimir Zapolskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.