All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value
@ 2013-07-17 22:10 Simon Glass
  2013-07-17 22:17 ` Simon Glass
  2013-07-19 13:46 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2013-07-17 22:10 UTC (permalink / raw)
  To: u-boot

The value of this config variable is not available to image.h on the host,
since the board config is not actually included. Bring this in so that
mkimage will be built with image-signing support for sandbox at least.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
 config.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/config.mk b/config.mk
index 81c2584..f71e145 100644
--- a/config.mk
+++ b/config.mk
@@ -213,6 +213,10 @@ endif
 # TODO(sjg at chromium.org): Is this correct on Mac OS?
 ifdef CONFIG_FIT_SIGNATURE
 HOSTLIBS	+= -lssl -lcrypto
+
+# This affects include/image.h, but including the board config file
+# is tricky, so manually define this options here.
+HOSTCFLAGS	+= -DCONFIG_FIT_SIGNATURE
 endif
 
 ifneq ($(CONFIG_SYS_TEXT_BASE),)
-- 
1.8.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value
  2013-07-17 22:10 [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value Simon Glass
@ 2013-07-17 22:17 ` Simon Glass
  2013-07-19 13:46 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2013-07-17 22:17 UTC (permalink / raw)
  To: u-boot

Hi Tom,

On Wed, Jul 17, 2013 at 4:10 PM, Simon Glass <sjg@chromium.org> wrote:

> The value of this config variable is not available to image.h on the host,
> since the board config is not actually included. Bring this in so that
> mkimage will be built with image-signing support for sandbox at least.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
>

This is another bug fix - although I don't have a good explanation for why
I didn't seem to need this when I was testing a few weeks ago.

Regards,
Simon

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value
  2013-07-17 22:10 [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value Simon Glass
  2013-07-17 22:17 ` Simon Glass
@ 2013-07-19 13:46 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2013-07-19 13:46 UTC (permalink / raw)
  To: u-boot

On Wed, Jul 17, 2013 at 03:10:59PM -0700, Simon Glass wrote:

> The value of this config variable is not available to image.h on the host,
> since the board config is not actually included. Bring this in so that
> mkimage will be built with image-signing support for sandbox at least.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130719/b66f6f96/attachment.pgp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-19 13:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 22:10 [U-Boot] [PATCH] mkimage: Use board config to get CONFIG_FIT_SIGNATURE value Simon Glass
2013-07-17 22:17 ` Simon Glass
2013-07-19 13:46 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.