All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video
@ 2021-04-09 16:02 Patrick Delaunay
  2021-04-09 20:58 ` Simon Glass
  2021-04-11 19:10 ` Anatolij Gustschin
  0 siblings, 2 replies; 3+ messages in thread
From: Patrick Delaunay @ 2021-04-09 16:02 UTC (permalink / raw)
  To: u-boot

Update the debug trace for the reserved video memory to KB as indicated
in the message with "%luk"; before the patch the computed size
gd->relocaddr - addr is in bytes.

This patch aligns the debug trace in reserve_video() with others
functions, for example on stm32mp157c-dk2:

  - Reserving 3080192k for video at: dfd00000
  + Reserving 3008k for video at: dfd00000
    Reserving 873k for U-Boot at: dfc25000
    Reserving 32776k for malloc() at: ddc23000
    Reserving 72 Bytes for Board Info at: ddc22fb0
    Reserving 280 Bytes for Global Data at: ddc22e90
    Reserving 119072 Bytes for FDT at: ddc05d70
    Reserving 0x278 Bytes for bootstage at: ddc05af0

Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

 common/board_f.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/board_f.c b/common/board_f.c
index 0cddf0359d..203e965799 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -394,7 +394,7 @@ static int reserve_video(void)
 	if (ret)
 		return ret;
 	debug("Reserving %luk for video at: %08lx\n",
-	      (unsigned long)gd->relocaddr - addr, addr);
+	      ((unsigned long)gd->relocaddr - addr) >> 10, addr);
 	gd->relocaddr = addr;
 #elif defined(CONFIG_LCD)
 #  ifdef CONFIG_FB_ADDR
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video
  2021-04-09 16:02 [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video Patrick Delaunay
@ 2021-04-09 20:58 ` Simon Glass
  2021-04-11 19:10 ` Anatolij Gustschin
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-04-09 20:58 UTC (permalink / raw)
  To: u-boot

On Sat, 10 Apr 2021 at 04:02, Patrick Delaunay
<patrick.delaunay@foss.st.com> wrote:
>
> Update the debug trace for the reserved video memory to KB as indicated
> in the message with "%luk"; before the patch the computed size
> gd->relocaddr - addr is in bytes.
>
> This patch aligns the debug trace in reserve_video() with others
> functions, for example on stm32mp157c-dk2:
>
>   - Reserving 3080192k for video at: dfd00000
>   + Reserving 3008k for video at: dfd00000
>     Reserving 873k for U-Boot at: dfc25000
>     Reserving 32776k for malloc() at: ddc23000
>     Reserving 72 Bytes for Board Info at: ddc22fb0
>     Reserving 280 Bytes for Global Data at: ddc22e90
>     Reserving 119072 Bytes for FDT at: ddc05d70
>     Reserving 0x278 Bytes for bootstage at: ddc05af0
>
> Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
>  common/board_f.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video
  2021-04-09 16:02 [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video Patrick Delaunay
  2021-04-09 20:58 ` Simon Glass
@ 2021-04-11 19:10 ` Anatolij Gustschin
  1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2021-04-11 19:10 UTC (permalink / raw)
  To: u-boot

On Fri, 9 Apr 2021 18:02:06 +0200
Patrick Delaunay patrick.delaunay at foss.st.com wrote:
...
> Fixes: 5630d2fbc50f3035 ("board: Show memory for frame buffers")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  common/board_f.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to u-boot-video/master, thanks!

--
Anatolij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-11 19:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 16:02 [PATCH] board_f: cosmetic: change the debug trace to KB in reserve_video Patrick Delaunay
2021-04-09 20:58 ` Simon Glass
2021-04-11 19:10 ` Anatolij Gustschin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.