[PATCH] cli: Reduce size of readline buffers in SPL

[PATCH] cli: Reduce size of readline buffers in SPL

[Sean Anderson]

Normally, readline is not used int SPL. However, it may be useful to
enable the Freescale DDR interactive mode in SPL, while U-Boot is still
executing from SRAM. The default settings for readline result in a large
buffer being allocated. Reduce the size of the maximum input line, and
the number of lines of scrollback when building for SPL.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 common/cli_readline.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/common/cli_readline.c b/common/cli_readline.c
index c7614a4c90f..2b81763b016 100644
--- a/common/cli_readline.c
+++ b/common/cli_readline.c
@@ -72,8 +72,13 @@ static char *delete_char (char *buffer, char *p, int *colp, int *np, int plen)
 #define getcmd_getch()		getchar()
 #define getcmd_cbeep()		getcmd_putch('\a')
 
+#ifdef CONFIG_SPL_BUILD
+#define HIST_MAX		3
+#define HIST_SIZE		32
+#else
 #define HIST_MAX		20
 #define HIST_SIZE		CONFIG_SYS_CBSIZE
+#endif
 
 static int hist_max;
 static int hist_add_idx;
-- 
2.35.1.1320.gc452695387.dirty

Re: [PATCH] cli: Reduce size of readline buffers in SPL

[Simon Glass]

On Tue, 30 Aug 2022 at 14:40, Sean Anderson <sean.anderson@seco.com> wrote:
>
> Normally, readline is not used int SPL. However, it may be useful to
> enable the Freescale DDR interactive mode in SPL, while U-Boot is still
> executing from SRAM. The default settings for readline result in a large
> buffer being allocated. Reduce the size of the maximum input line, and
> the number of lines of scrollback when building for SPL.
>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
>
>  common/cli_readline.c | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH] cli: Reduce size of readline buffers in SPL

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Tue, Aug 30, 2022 at 04:40:37PM -0400, Sean Anderson wrote:

> Normally, readline is not used int SPL. However, it may be useful to
> enable the Freescale DDR interactive mode in SPL, while U-Boot is still
> executing from SRAM. The default settings for readline result in a large
> buffer being allocated. Reduce the size of the maximum input line, and
> the number of lines of scrollback when building for SPL.
> 
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]