From: sjg at google.com <sjg@google.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 10/13] fdtdec: test: Add carveout tests
Date: Fri, 12 Apr 2019 14:49:55 -0700 [thread overview]
Message-ID: <CAPnjgZ203ePXyi+moiO+ecJ4LS+eL1wuaoNpojxcZB-qTTukDA@mail.gmail.com> (raw)
In-Reply-To: <20190322084538.GC28640@ulmo>
On Fri, Mar 22, 2019 at 03:53:07PM +0800, Simon Glass wrote:
> Hi Thierry,
>
> On Fri, 22 Mar 2019 at 02:10, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Implement carveout tests for 32-bit and 64-bit builds.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > Changes in v2:
> > - new patch
> >
> > lib/fdtdec_test.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 152 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Just an idea - as an alternative you could use the built-in device
> tree as your base rather than creating a new one. But perhaps that
> would only be safe on sandbox?
Yeah, running that test on a live system would mess up the reserved
memory regions. If U-Boot does something based on the reserved-memory
node, or passes it on to the kernel, that's going to cause issues.
The test also uses rather arbitrary values for the carveout, which may
not point at system memory at all.
Thierry
Applied to u-boot-dm, thanks!
next prev parent reply other threads:[~2019-04-12 21:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 18:09 [U-Boot] [PATCH v3 00/13] ARM: tegra: Add support for framebuffer carveouts Thierry Reding
2019-03-21 18:09 ` [U-Boot] [PATCH v3 01/13] libfdt: Add phandle generation helper Thierry Reding
2019-03-22 7:52 ` Simon Glass
2019-03-25 7:27 ` Thierry Reding
2019-03-30 21:18 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:09 ` [U-Boot] [PATCH v3 02/13] fdtdec: Add cpu_to_fdt_{addr, size}() macros Thierry Reding
2019-04-12 21:48 ` Simon Glass
2019-03-21 18:10 ` [U-Boot] [PATCH v3 03/13] fdtdec: Add fdt_{addr, size}_unpack() helpers Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:31 ` Thierry Reding
2019-04-12 21:45 ` Simon Glass
2019-04-15 8:18 ` Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 04/13] fdtdec: Implement fdtdec_set_phandle() Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:34 ` Thierry Reding
2019-03-23 0:52 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 05/13] fdtdec: Implement fdtdec_add_reserved_memory() Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 06/13] fdtdec: Implement carveout support functions Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 07/13] fdtdec: Add Kconfig symbol for tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:50 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 08/13] fdtdec: test: Fix build warning Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 09/13] fdtdec: test: Use compound statement macros Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 10/13] fdtdec: test: Add carveout tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-03-22 8:45 ` Thierry Reding
2019-04-12 21:49 ` sjg at google.com [this message]
2019-03-21 18:10 ` [U-Boot] [PATCH v3 11/13] sandbox: Enable fdtdec tests Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 21:49 ` sjg at google.com
2019-03-21 18:10 ` [U-Boot] [PATCH v3 12/13] p2371-2180: Add support for framebuffer carveouts Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 2:12 ` Simon Glass
2019-04-15 8:20 ` Thierry Reding
2019-03-21 18:10 ` [U-Boot] [PATCH v3 13/13] p2771-0000: " Thierry Reding
2019-03-22 7:53 ` Simon Glass
2019-04-12 2:12 ` Simon Glass
2019-04-12 21:50 ` [U-Boot] [PATCH v3 06/13] fdtdec: Implement carveout support functions sjg at google.com
2019-04-12 21:50 ` [U-Boot] [PATCH v3 05/13] fdtdec: Implement fdtdec_add_reserved_memory() sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ203ePXyi+moiO+ecJ4LS+eL1wuaoNpojxcZB-qTTukDA@mail.gmail.com \
--to=sjg@google.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.