All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7
@ 2017-09-21  8:08 patrice.chotard at st.com
  2017-09-25  2:13 ` Simon Glass
  2017-09-29 20:26 ` [U-Boot] [U-Boot, " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: patrice.chotard at st.com @ 2017-09-21  8:08 UTC (permalink / raw)
  To: u-boot

From: Patrice Chotard <patrice.chotard@st.com>

Add missing .priv_auto_alloc_size() callback.
Previously private struct stm32_clk was not allocate
which leads to unpredictable behaviour

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
 drivers/clk/clk_stm32f7.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/clk/clk_stm32f7.c b/drivers/clk/clk_stm32f7.c
index 7d1e1e8..aa4ad0a 100644
--- a/drivers/clk/clk_stm32f7.c
+++ b/drivers/clk/clk_stm32f7.c
@@ -393,10 +393,11 @@ static const struct udevice_id stm32_clk_ids[] = {
 };
 
 U_BOOT_DRIVER(stm32f7_clk) = {
-	.name		= "stm32f7_clk",
-	.id		= UCLASS_CLK,
-	.of_match	= stm32_clk_ids,
-	.ops		= &stm32_clk_ops,
-	.probe		= stm32_clk_probe,
-	.flags		= DM_FLAG_PRE_RELOC,
+	.name			= "stm32f7_clk",
+	.id			= UCLASS_CLK,
+	.of_match		= stm32_clk_ids,
+	.ops			= &stm32_clk_ops,
+	.probe			= stm32_clk_probe,
+	.priv_auto_alloc_size	= sizeof(struct stm32_clk),
+	.flags			= DM_FLAG_PRE_RELOC,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7
  2017-09-21  8:08 [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7 patrice.chotard at st.com
@ 2017-09-25  2:13 ` Simon Glass
  2017-09-29 20:26 ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2017-09-25  2:13 UTC (permalink / raw)
  To: u-boot

On 21 September 2017 at 02:08,  <patrice.chotard@st.com> wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> Add missing .priv_auto_alloc_size() callback.
> Previously private struct stm32_clk was not allocate
> which leads to unpredictable behaviour
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>  drivers/clk/clk_stm32f7.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [U-Boot, 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7
  2017-09-21  8:08 [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7 patrice.chotard at st.com
  2017-09-25  2:13 ` Simon Glass
@ 2017-09-29 20:26 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-09-29 20:26 UTC (permalink / raw)
  To: u-boot

On Thu, Sep 21, 2017 at 10:08:09AM +0200, patrice.chotard at st.com wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
> 
> Add missing .priv_auto_alloc_size() callback.
> Previously private struct stm32_clk was not allocate
> which leads to unpredictable behaviour
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170929/b37fc0ef/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-29 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21  8:08 [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7 patrice.chotard at st.com
2017-09-25  2:13 ` Simon Glass
2017-09-29 20:26 ` [U-Boot] [U-Boot, " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.