Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file

[Simon Glass <sjg@chromium.org>]

Hi Wolfgang,

On Mon, 18 Oct 2021 at 08:10, Wolfgang Denk <wd@denx.de> wrote:
>
> Dear Tom,
>
> In message <20211018133728.GQ7964@bill-the-cat> you wrote:
> >
> > > And please see also my comments about changing the autostart
> > > functionality for the user.
> >
> > Perhaps we should just make "+" an illegal character in the variable
> > name, for consistency?
>
> And break backward compatibility?  I'd rather see a better
> definition of the syntax of the environment files, plus maybe a more
> powerful parser.
>
> I mean, there is no technical reason to forbid the '+' character -
> and then it's only at the end of the variable name.
>
> Hm... I can't find it right now but did I not also read about other
> restrictions to variable names, like they must noch begin with '_'
> when using this new tool?

Yes but I took that out (I think in v6). I'll update the commit message.

>
>
> I feel it is wrong to place new restrictions on something that was
> constant for 21 years, just because our parser cannot parse it...

We need the + thing and perhaps we should ask people to avoid
punctuation, etc? But for now I'm not requiring it in this series,
apart from +

Regards,
Simon