[U-Boot] [PATCH] buildman: fix to display warning message for missing [toolchain] section

[U-Boot] [PATCH] buildman: fix to display warning message for missing [toolchain] section

[Masahiro Yamada]

Toolchains.__init__ is expected to display a warning message
when the [toolchain] section is missing from ~/.buildman file.
But it never works.
In that case, instead, buildmain fails with an error message
which is difficult to understand:

  Traceback (most recent call last):
    File "tools/buildman/buildman", line 126, in <module>
      control.DoBuildman(options, args)
    File "/home/foo/u-boot/tools/buildman/control.py", line 78, in DoBuildman
      toolchains = toolchain.Toolchains()
    File "/home/foo/u-boot/tools/buildman/toolchain.py", line 106, in __init__
    config_fname)
  NameError: global name 'config_fname' is not defined

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Simon Glass <sjg@chromium.org>
---
 tools/buildman/toolchain.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
index b643386..e392035 100644
--- a/tools/buildman/toolchain.py
+++ b/tools/buildman/toolchain.py
@@ -103,7 +103,7 @@ class Toolchains:
         if not toolchains:
             print ("Warning: No tool chains - please add a [toolchain] section"
                  " to your buildman config file %s. See README for details" %
-                 config_fname)
+                 bsettings.config_fname)
 
         for name, value in toolchains:
             if '*' in value:
-- 
1.9.1

[U-Boot] [PATCH] buildman: fix to display warning message for missing [toolchain] section

[Simon Glass]

On 6 July 2014 18:46, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Toolchains.__init__ is expected to display a warning message
> when the [toolchain] section is missing from ~/.buildman file.
> But it never works.
> In that case, instead, buildmain fails with an error message
> which is difficult to understand:
>
>   Traceback (most recent call last):
>     File "tools/buildman/buildman", line 126, in <module>
>       control.DoBuildman(options, args)
>     File "/home/foo/u-boot/tools/buildman/control.py", line 78, in DoBuildman
>       toolchains = toolchain.Toolchains()
>     File "/home/foo/u-boot/tools/buildman/toolchain.py", line 106, in __init__
>     config_fname)
>   NameError: global name 'config_fname' is not defined
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Simon Glass <sjg@chromium.org>

Acked-by: Simon Glass <sjg@chromium.org>