Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig

[Simon Glass <sjg@chromium.org>]

Hi Pali,

On Sat, 22 Jan 2022 at 06:26, Pali Rohár <pali@kernel.org> wrote:
>
> On Friday 19 November 2021 13:24:01 Simon Glass wrote:
> > This converts the following to Kconfig:
> >    CONFIG_VIDEO_LOGO
> >
> > Note that this option depends on CONFIG_DM_VIDEO now, since cfb_console is
> > deprecated. The only relevant code is now in splash.c
> >
> > Drop the check for DM_VIDEO in that file.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> ...
> >  include/configs/nokia_rx51.h           | 1 -
> ...
> > diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.h
> > index b37e05406e9..afb91d96a54 100644
> > --- a/include/configs/nokia_rx51.h
> > +++ b/include/configs/nokia_rx51.h
> > @@ -75,7 +75,6 @@
> >   * Framebuffer
> >   */
> >  /* Video console */
> > -#define CONFIG_VIDEO_LOGO
> >  #define VIDEO_FB_16BPP_PIXEL_SWAP
> >  #define VIDEO_FB_16BPP_WORD_SWAP
>
> Hello!
>
> This change is now in master branch and it broke support for video logo
> on Nokia N900 :-( It does not work anymore and reason is because
> CONFIG_VIDEO_LOGO was removed from Nokia N900 config files completely,
> despite commit subject says CONFIG_VIDEO_LOGO was converted to Kconfig.
>
> Seems that conversion for Nokia N900 is missing. Could you please look
> at this issue? It is visible also in qemu, so no real hardware is needed
> for reproducing it.

I believe this is because you need to move to DM_VIDEO. Everything
else has, I believe, which is why the migration messages have been
dropped.

+Anatolij Gustschin is looking at removing lcd.c and cfb_console.c I think?

Regards,
Simon