All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/4] usb: dwc2-otg: adjust fifo size via platform data
Date: Sat, 16 Jul 2016 14:59:47 -0600	[thread overview]
Message-ID: <CAPnjgZ2MUWA_gBO0DqNre0ntLPsABJYytNn_vzhB0WLqpusWDw@mail.gmail.com> (raw)
In-Reply-To: <20537904-9c3e-b720-1b21-674dd8277809@denx.de>

Hi Marek,

On 15 July 2016 at 23:43, Marek Vasut <marex@denx.de> wrote:
> On 07/15/2016 05:56 AM, Simon Glass wrote:
>>
>> On 14 July 2016 at 21:20, Simon Glass <sjg@chromium.org> wrote:
>>>
>>> On 14 July 2016 at 00:52, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>>>>
>>>> From: Xu Ziyuan <xzy.xu@rock-chips.com>
>>>>
>>>> The total FIFO size of some SoCs may be different from the existen, this
>>>> patch supports fifo size setting from platform data.
>>>>
>>>> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v4:
>>>> - Rework fifo size getting and setting
>>>> - Update commit message
>>>>
>>>> Changes in v3: None
>>>> Changes in v2:
>>>> - Update detailed commit message
>>>> - Modify the macro's values
>>>>
>>>>  drivers/usb/gadget/dwc2_udc_otg.c      | 22 ++++++++++++++++------
>>>>  drivers/usb/gadget/dwc2_udc_otg_regs.h |  6 +++---
>>>>  include/usb/dwc2_udc.h                 |  3 +++
>>>>  3 files changed, 22 insertions(+), 9 deletions(-)
>>>
>>>
>>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>>
>> Applied to u-boot-rockchip, thanks!
>>
>
> Simon, I see you're now picking generic usb gadget code via platform tree.
> This is NOT OK, there is a tree for usb gadget code and this should go
> through that tree. I would be glad if this didn't repeat.

Ah OK, sorry. I'll leave those alone from now on. Which one is it?

http://www.denx.de/wiki/U-Boot/Custodians

Are the patches OK as applied, or are there more comments?

Regards,
Simon

  reply	other threads:[~2016-07-16 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14  6:52 [U-Boot] [PATCH v4 0/4] rockchip: rk3288: add fastboot support Ziyuan Xu
2016-07-14  6:52 ` [U-Boot] [PATCH v4 1/4] usb: rockchip-phy: implement USB2.0 phy control Ziyuan Xu
2016-07-15  3:20   ` Simon Glass
2016-07-15  3:56     ` Simon Glass
2016-07-14  6:52 ` [U-Boot] [PATCH v4 2/4] usb: dwc2-otg: adjust fifo size via platform data Ziyuan Xu
2016-07-15  3:20   ` Simon Glass
2016-07-15  3:56     ` Simon Glass
2016-07-16  5:43       ` Marek Vasut
2016-07-16 20:59         ` Simon Glass [this message]
2016-07-14  6:52 ` [U-Boot] [PATCH v4 3/4] rockchip: rk3288: add fastboot support Ziyuan Xu
2016-07-14 11:06   ` William.wu
2016-07-14 15:51     ` Ziyuan Xu
2016-07-14 16:26   ` [U-Boot] [PATCH v4.1 " Ziyuan Xu
2016-07-15  3:20     ` Simon Glass
2016-07-15 14:05       ` Ziyuan Xu
2016-07-15 14:38         ` Simon Glass
2016-07-16 22:31       ` Simon Glass
2016-07-14  6:52 ` [U-Boot] [PATCH v4 4/4] usb: dwc2 : invalidate dcache before starting DMA Ziyuan Xu
2016-07-15  3:20   ` Simon Glass
2016-07-15  3:56     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2MUWA_gBO0DqNre0ntLPsABJYytNn_vzhB0WLqpusWDw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.