[PATCH] console: Use flush() before panic and reset

* [PATCH] console: Use flush() before panic and reset
@ 2023-03-15  0:24 Tony Dinh
  2023-03-15 19:43 ` Simon Glass
  2023-03-22 18:05 ` Tom Rini
  0 siblings, 2 replies; 6+ messages in thread
From: Tony Dinh @ 2023-03-15  0:24 UTC (permalink / raw)
  To: Stefan Roese, Pali Roh�r, Tom Rini, Simon Glass,
	U-Boot Mailing List
  Cc: Michael Walle, Tony Dinh

To make sure the panic and the reset messages will go out, console flush() should be used.
Sleep periods do not work in early u-boot phase when timer driver is not initialized yet.

Reference: https://lists.denx.de/pipermail/u-boot/2023-March/512233.html

Signed-off-by: Tony Dinh <mibodhi@gmail.com>
---

 arch/arm/lib/reset.c | 4 ++--
 lib/panic.c          | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/lib/reset.c b/arch/arm/lib/reset.c
index 95169bae1c..3e051e36f1 100644
--- a/arch/arm/lib/reset.c
+++ b/arch/arm/lib/reset.c
@@ -25,6 +25,7 @@
 #include <cpu_func.h>
 #include <irq_func.h>
 #include <linux/delay.h>
+#include <stdio.h>
 
 __weak void reset_misc(void)
 {
@@ -33,8 +34,7 @@ __weak void reset_misc(void)
 int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 {
 	puts ("resetting ...\n");
-
-	mdelay(50);				/* wait 50 ms */
+	flush();
 
 	disable_interrupts();
 
diff --git a/lib/panic.c b/lib/panic.c
index 58382ac4f4..66ae17f3df 100644
--- a/lib/panic.c
+++ b/lib/panic.c
@@ -15,6 +15,7 @@
 #include <command.h>
 #endif
 #include <linux/delay.h>
+#include <stdio.h>
 
 static void panic_finish(void) __attribute__ ((noreturn));
 
@@ -24,7 +25,8 @@ static void panic_finish(void)
 #if defined(CONFIG_PANIC_HANG)
 	hang();
 #else
-	udelay(100000);	/* allow messages to go out */
+	flush();  /* flush the panic message before reset */
+
 	do_reset(NULL, 0, 0, NULL);
 #endif
 	while (1)
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread