From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] clk: scmi: register all scmi clock by name with CCF
Date: Sat, 15 May 2021 09:20:04 -0600 [thread overview]
Message-ID: <CAPnjgZ2UFe8XBSjyrYR6tCYROC1nHB-c0AWxF2wryC-Ly8kB4g@mail.gmail.com> (raw)
In-Reply-To: <20210512145424.13184-1-etienne.carriere@linaro.org>
Hi,
On Wed, 12 May 2021 at 08:55, Etienne Carriere
<etienne.carriere@linaro.org> wrote:
>
> From: Patrick Delaunay <patrick.delaunay@st.com>
>
> This patch implements SCMI APIs to retrieve the number and the name of
> SCMI clocks using SCMI_PROTOCOL_ATTRIBUTES messages.
>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
> drivers/clk/clk_scmi.c | 101 +++++++++++++++++++++++++++++++++++++++
> include/scmi_protocols.h | 43 +++++++++++++++++
> 2 files changed, 144 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
I notice that this code uses pointers to return error codes. We tend
to avoid that in U-Boot and use an integer return instead, with the
pointer returned as a parameter. We have things like log_msg_ret() to
help with that. I don't have strong feelings about this if the goal is
to make the code match linux code. But if this code is for U-Boot
only, please do avoid it.
Regards,
Simon
prev parent reply other threads:[~2021-05-15 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 14:54 [PATCH 1/2] clk: scmi: register all scmi clock by name with CCF Etienne Carriere
2021-05-12 14:54 ` [PATCH 2/2] firmware: scmi: fix sandbox and related test since clock discovery Etienne Carriere
2021-05-15 15:20 ` Simon Glass
2021-05-15 15:20 ` Simon Glass [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ2UFe8XBSjyrYR6tCYROC1nHB-c0AWxF2wryC-Ly8kB4g@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.