* [PATCH] x86: Fix i8259 ifdef include guard
@ 2022-09-26 22:23 Alistair Delva
2022-10-05 0:44 ` Simon Glass
2022-12-14 4:03 ` Bin Meng
0 siblings, 2 replies; 3+ messages in thread
From: Alistair Delva @ 2022-09-26 22:23 UTC (permalink / raw)
To: u-boot; +Cc: Simon Glass, Bin Meng, Nick Desaulniers
When building U-Boot with clang, it notices that the i8259.h include
guard does not work correctly due to a typo. Fix it.
Signed-off-by: Alistair Delva <adelva@google.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
---
arch/x86/include/asm/i8259.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/i8259.h b/arch/x86/include/asm/i8259.h
index b73052a6d2..90f2d3866c 100644
--- a/arch/x86/include/asm/i8259.h
+++ b/arch/x86/include/asm/i8259.h
@@ -7,7 +7,7 @@
/* i8259.h i8259 PIC Registers */
#ifndef _ASMI386_I8259_H_
-#define _ASMI386_I8959_H_
+#define _ASMI386_I8259_H_
/* PIC I/O mapped registers */
#define IRR 0x0 /* Interrupt Request Register */
@@ -73,4 +73,4 @@
int i8259_init(void);
-#endif /* _ASMI386_I8959_H_ */
+#endif /* _ASMI386_I8259_H_ */
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Fix i8259 ifdef include guard
2022-09-26 22:23 [PATCH] x86: Fix i8259 ifdef include guard Alistair Delva
@ 2022-10-05 0:44 ` Simon Glass
2022-12-14 4:03 ` Bin Meng
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-10-05 0:44 UTC (permalink / raw)
To: Alistair Delva; +Cc: u-boot, Bin Meng, Nick Desaulniers
On Mon, 26 Sept 2022 at 16:23, Alistair Delva <adelva@google.com> wrote:
>
> When building U-Boot with clang, it notices that the i8259.h include
> guard does not work correctly due to a typo. Fix it.
>
> Signed-off-by: Alistair Delva <adelva@google.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/x86/include/asm/i8259.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: Fix i8259 ifdef include guard
2022-09-26 22:23 [PATCH] x86: Fix i8259 ifdef include guard Alistair Delva
2022-10-05 0:44 ` Simon Glass
@ 2022-12-14 4:03 ` Bin Meng
1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2022-12-14 4:03 UTC (permalink / raw)
To: Alistair Delva; +Cc: u-boot, Simon Glass, Nick Desaulniers
On Tue, Sep 27, 2022 at 6:23 AM Alistair Delva <adelva@google.com> wrote:
>
> When building U-Boot with clang, it notices that the i8259.h include
> guard does not work correctly due to a typo. Fix it.
>
> Signed-off-by: Alistair Delva <adelva@google.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> ---
> arch/x86/include/asm/i8259.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-14 4:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 22:23 [PATCH] x86: Fix i8259 ifdef include guard Alistair Delva
2022-10-05 0:44 ` Simon Glass
2022-12-14 4:03 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.