* [PATCH] doc: dm: debugging: Fix the steps for activating debug
@ 2020-01-29 17:45 Fabio Estevam
2020-01-30 2:19 ` Simon Glass
2020-02-05 17:55 ` sjg at google.com
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-01-29 17:45 UTC (permalink / raw)
To: u-boot
Following the recommendation of adding '#define DEBUG' at the top
of drivers/core/lists.c does not cause the debug messages to be
shown. Change it to '#define LOG_DEBUG' instead, which actually
makes it work as per doc/README.log.
While at it, provide the full path to lists.c to in order to make
the instructions clearer.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
doc/driver-model/debugging.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/driver-model/debugging.rst b/doc/driver-model/debugging.rst
index 4f4a8d4805..c59bf6763b 100644
--- a/doc/driver-model/debugging.rst
+++ b/doc/driver-model/debugging.rst
@@ -58,5 +58,5 @@ If you are using of-platdata (e.g. CONFIG_SPL_OF_PLATDATA), check that the
driver name is the same as the first compatible string in the device tree (with
invalid-variable characters converted to underscore).
-If you are really stuck, #define DEBUG at the top of lists.c should show you
-what is going on.
+If you are really stuck, putting '#define LOG_DEBUG' at the top of
+drivers/core/lists.c should show you what is going on.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] doc: dm: debugging: Fix the steps for activating debug
2020-01-29 17:45 [PATCH] doc: dm: debugging: Fix the steps for activating debug Fabio Estevam
@ 2020-01-30 2:19 ` Simon Glass
2020-02-05 17:55 ` sjg at google.com
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-01-30 2:19 UTC (permalink / raw)
To: u-boot
On Wed, 29 Jan 2020 at 10:45, Fabio Estevam <festevam@gmail.com> wrote:
>
> Following the recommendation of adding '#define DEBUG' at the top
> of drivers/core/lists.c does not cause the debug messages to be
> shown. Change it to '#define LOG_DEBUG' instead, which actually
> makes it work as per doc/README.log.
>
> While at it, provide the full path to lists.c to in order to make
> the instructions clearer.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> doc/driver-model/debugging.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] doc: dm: debugging: Fix the steps for activating debug
2020-01-29 17:45 [PATCH] doc: dm: debugging: Fix the steps for activating debug Fabio Estevam
2020-01-30 2:19 ` Simon Glass
@ 2020-02-05 17:55 ` sjg at google.com
1 sibling, 0 replies; 3+ messages in thread
From: sjg at google.com @ 2020-02-05 17:55 UTC (permalink / raw)
To: u-boot
On Wed, 29 Jan 2020 at 10:45, Fabio Estevam <festevam@gmail.com> wrote:
>
> Following the recommendation of adding '#define DEBUG' at the top
> of drivers/core/lists.c does not cause the debug messages to be
> shown. Change it to '#define LOG_DEBUG' instead, which actually
> makes it work as per doc/README.log.
>
> While at it, provide the full path to lists.c to in order to make
> the instructions clearer.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> doc/driver-model/debugging.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-05 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 17:45 [PATCH] doc: dm: debugging: Fix the steps for activating debug Fabio Estevam
2020-01-30 2:19 ` Simon Glass
2020-02-05 17:55 ` sjg at google.com
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.