* [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE
@ 2020-10-12 7:47 Patrick Delaunay
2020-10-15 15:05 ` Simon Glass
2020-10-23 0:29 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Patrick Delaunay @ 2020-10-12 7:47 UTC (permalink / raw)
To: u-boot
Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
storage boot initialization is correctly managed by distro boot command
('usb_boot' defined in include/config_distro_bootcmd.h already include
the command 'usb start').
Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
common/Kconfig.boot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/Kconfig.boot b/common/Kconfig.boot
index 4191bfb34d..522f5f3d6a 100644
--- a/common/Kconfig.boot
+++ b/common/Kconfig.boot
@@ -880,7 +880,7 @@ config USE_PREBOOT
config PREBOOT
string "preboot default value"
depends on USE_PREBOOT && !USE_DEFAULT_ENV_FILE
- default "usb start" if USB_KEYBOARD || USB_STORAGE
+ default "usb start" if USB_KEYBOARD
default ""
help
This is the default of "preboot" environment variable.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE
2020-10-12 7:47 [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE Patrick Delaunay
@ 2020-10-15 15:05 ` Simon Glass
2020-10-23 0:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-10-15 15:05 UTC (permalink / raw)
To: u-boot
On Mon, 12 Oct 2020 at 01:48, Patrick Delaunay <patrick.delaunay@st.com> wrote:
>
> Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
> storage boot initialization is correctly managed by distro boot command
> ('usb_boot' defined in include/config_distro_bootcmd.h already include
> the command 'usb start').
>
> Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
> common/Kconfig.boot | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE
2020-10-12 7:47 [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE Patrick Delaunay
2020-10-15 15:05 ` Simon Glass
@ 2020-10-23 0:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-10-23 0:29 UTC (permalink / raw)
To: u-boot
On Mon, Oct 12, 2020 at 09:47:50AM +0200, Patrick Delaunay wrote:
> Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB
> storage boot initialization is correctly managed by distro boot command
> ('usb_boot' defined in include/config_distro_bootcmd.h already include
> the command 'usb start').
>
> Fixes: 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/831ad1e7/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-23 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 7:47 [PATCH] Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE Patrick Delaunay
2020-10-15 15:05 ` Simon Glass
2020-10-23 0:29 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.