[U-Boot] [PATCH] rockchip: firefly: configs: add a new config to keep non-of-platdata

[U-Boot] [PATCH] rockchip: firefly: configs: add a new config to keep non-of-platdata

[Jacob Chen]

The firefly config have been changed to use SPL_BACK_TO_BROM, but we also want keep
CONFIG_SPL_OF_PLATDATA as an example.

So add this separate defconfig to show how both way works.

Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
---

 configs/firefly-nodtb-rk3288_defconfig | 78 ++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 configs/firefly-nodtb-rk3288_defconfig

diff --git a/configs/firefly-nodtb-rk3288_defconfig b/configs/firefly-nodtb-rk3288_defconfig
new file mode 100644
index 0000000..3ed17b4
--- /dev/null
+++ b/configs/firefly-nodtb-rk3288_defconfig
@@ -0,0 +1,78 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_ROCKCHIP_RK3288=y
+CONFIG_TARGET_FIREFLY_RK3288=y
+CONFIG_SPL_STACK_R_ADDR=0x80000
+CONFIG_DEFAULT_DEVICE_TREE="rk3288-firefly"
+CONFIG_SILENT_CONSOLE=y
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTZ=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_GPIO=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_SPL_OF_PLATDATA=y
+CONFIG_REGMAP=y
+CONFIG_SPL_REGMAP=y
+CONFIG_SYSCON=y
+CONFIG_SPL_SYSCON=y
+# CONFIG_SPL_SIMPLE_BUS is not set
+CONFIG_CLK=y
+CONFIG_SPL_CLK=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_LED=y
+CONFIG_LED_GPIO=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_DM_ETH=y
+CONFIG_NETDEVICES=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PINCTRL=y
+CONFIG_SPL_PINCTRL=y
+# CONFIG_SPL_PINCTRL_FULL is not set
+CONFIG_ROCKCHIP_RK3288_PINCTRL=y
+CONFIG_DM_PMIC=y
+# CONFIG_SPL_PMIC_CHILDREN is not set
+CONFIG_PMIC_ACT8846=y
+CONFIG_REGULATOR_ACT8846=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_RAM=y
+CONFIG_SPL_RAM=y
+CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_BASE=0xff690000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550=y
+CONFIG_ROCKCHIP_SERIAL=y
+CONFIG_SYSRESET=y
+CONFIG_DM_VIDEO=y
+CONFIG_DISPLAY=y
+CONFIG_VIDEO_ROCKCHIP=y
+CONFIG_CONSOLE_SCROLL_LINES=10
+CONFIG_USE_TINY_PRINTF=y
+CONFIG_CMD_DHRYSTONE=y
+CONFIG_ERRNO_STR=y
+# CONFIG_SPL_OF_LIBFDT is not set
-- 
1.9.1

[U-Boot] [PATCH] rockchip: firefly: configs: add a new config to keep non-of-platdata

[Simon Glass]

Hi Jacob,

On 20 February 2017 at 03:26, Jacob Chen <jacob2.chen@rock-chips.com> wrote:
> The firefly config have been changed to use SPL_BACK_TO_BROM, but we also want keep
> CONFIG_SPL_OF_PLATDATA as an example.
>
> So add this separate defconfig to show how both way works.
>
> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
> ---
>
>  configs/firefly-nodtb-rk3288_defconfig | 78 ++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 configs/firefly-nodtb-rk3288_defconfig

Thanks for this - can you also please add a MAINTAINERS file?

Regards,
Simon

[U-Boot] [PATCH] rockchip: firefly: configs: add a new config to keep non-of-platdata

[Jacob Chen]

Hi Simon,


2017-02-22 11:59 GMT+08:00 Simon Glass <sjg@chromium.org>:
> Hi Jacob,
>
> On 20 February 2017 at 03:26, Jacob Chen <jacob2.chen@rock-chips.com> wrote:
>> The firefly config have been changed to use SPL_BACK_TO_BROM, but we also want keep
>> CONFIG_SPL_OF_PLATDATA as an example.
>>
>> So add this separate defconfig to show how both way works.
>>
>> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
>> ---
>>
>>  configs/firefly-nodtb-rk3288_defconfig | 78 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 78 insertions(+)
>>  create mode 100644 configs/firefly-nodtb-rk3288_defconfig
>
> Thanks for this - can you also please add a MAINTAINERS file?
>
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Could i just append a line to "board/firefly/firefly-rk3288/MAINTAINERS"?

[U-Boot] [PATCH] rockchip: firefly: configs: add a new config to keep non-of-platdata

[Simon Glass]

Hi Jacob,

On 22 February 2017 at 23:36, Jacob Chen <jacobchen110@gmail.com> wrote:
> Hi Simon,
>
>
> 2017-02-22 11:59 GMT+08:00 Simon Glass <sjg@chromium.org>:
>> Hi Jacob,
>>
>> On 20 February 2017 at 03:26, Jacob Chen <jacob2.chen@rock-chips.com> wrote:
>>> The firefly config have been changed to use SPL_BACK_TO_BROM, but we also want keep
>>> CONFIG_SPL_OF_PLATDATA as an example.
>>>
>>> So add this separate defconfig to show how both way works.
>>>
>>> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
>>> ---
>>>
>>>  configs/firefly-nodtb-rk3288_defconfig | 78 ++++++++++++++++++++++++++++++++++
>>>  1 file changed, 78 insertions(+)
>>>  create mode 100644 configs/firefly-nodtb-rk3288_defconfig
>>
>> Thanks for this - can you also please add a MAINTAINERS file?
>>
>> Regards,
>> Simon
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
> Could i just append a line to "board/firefly/firefly-rk3288/MAINTAINERS"?

Yes that should work. The objective is to not get an error from
buildman about a missing maintainer.

Regards,
Simon