All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04
@ 2015-11-15  6:53 Stephen Warren
  2015-11-16  2:07 ` Tom Rini
  2015-11-18 22:36 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Warren @ 2015-11-15  6:53 UTC (permalink / raw)
  To: u-boot

gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04)
doesn't seem to like initializers for sub-fields of anonymous unions.
Solve this by replacing the initialization with an assignment. This
fixes:

lib/lz4_wrapper.c: In function ?ulz4fn?:
lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializer

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
 lib/lz4_wrapper.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/lz4_wrapper.c b/lib/lz4_wrapper.c
index 0739663fca55..6dc8b764b3f5 100644
--- a/lib/lz4_wrapper.c
+++ b/lib/lz4_wrapper.c
@@ -94,7 +94,9 @@ int ulz4fn(const void *src, size_t srcn, void *dst, size_t *dstn)
 	}
 
 	while (1) {
-		struct lz4_block_header b = { .raw = le32_to_cpu(*(u32 *)in) };
+		struct lz4_block_header b;
+
+		b.raw = le32_to_cpu(*(u32 *)in);
 		in += sizeof(struct lz4_block_header);
 
 		if (in - src + b.size > srcn) {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04
  2015-11-15  6:53 [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04 Stephen Warren
@ 2015-11-16  2:07 ` Tom Rini
  2015-11-16  6:48   ` Stephen Warren
  2015-11-18 22:36 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 6+ messages in thread
From: Tom Rini @ 2015-11-16  2:07 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 14, 2015 at 11:53:49PM -0700, Stephen Warren wrote:

> gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04)
> doesn't seem to like initializers for sub-fields of anonymous unions.
> Solve this by replacing the initialization with an assignment. This
> fixes:
> 
> lib/lz4_wrapper.c: In function ?ulz4fn?:
> lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializer
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>

So Ubuntu 10.04 hit end of life this past April.  I can be convinced but
as I'm personally staring down upgrading my 12.04 machine I need some
reason.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151115/d6e5005d/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04
  2015-11-16  2:07 ` Tom Rini
@ 2015-11-16  6:48   ` Stephen Warren
  2015-11-16 13:07     ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2015-11-16  6:48 UTC (permalink / raw)
  To: u-boot

On 11/15/2015 07:07 PM, Tom Rini wrote:
> On Sat, Nov 14, 2015 at 11:53:49PM -0700, Stephen Warren wrote:
> 
>> gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu
>> 10.04) doesn't seem to like initializers for sub-fields of
>> anonymous unions. Solve this by replacing the initialization with
>> an assignment. This fixes:
>> 
>> lib/lz4_wrapper.c: In function ?ulz4fn?: lib/lz4_wrapper.c:97:
>> error: unknown field ?raw? specified in initializer
>> 
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> 
> So Ubuntu 10.04 hit end of life this past April.  I can be
> convinced but as I'm personally staring down upgrading my 12.04
> machine I need some reason.

For some reason I though the support life was 5 years desktop and
longer for server, but it looks like 5 years was the server period. Oh
well.

I suspect this patch may still be useful though; RHEL5 is still
supported until March 31, 2017[1], and apparently has an even older
compiler (gcc 4.1.x)[2]

[1] https://access.redhat.com/support/policy/updates/errata
[2] https://access.redhat.com/solutions/19458

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04
  2015-11-16  6:48   ` Stephen Warren
@ 2015-11-16 13:07     ` Tom Rini
  2015-11-16 21:07       ` Simon Glass
  0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2015-11-16 13:07 UTC (permalink / raw)
  To: u-boot

On Sun, Nov 15, 2015 at 11:48:38PM -0700, Stephen Warren wrote:
> On 11/15/2015 07:07 PM, Tom Rini wrote:
> > On Sat, Nov 14, 2015 at 11:53:49PM -0700, Stephen Warren wrote:
> > 
> >> gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu
> >> 10.04) doesn't seem to like initializers for sub-fields of
> >> anonymous unions. Solve this by replacing the initialization with
> >> an assignment. This fixes:
> >> 
> >> lib/lz4_wrapper.c: In function ?ulz4fn?: lib/lz4_wrapper.c:97:
> >> error: unknown field ?raw? specified in initializer
> >> 
> >> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > 
> > So Ubuntu 10.04 hit end of life this past April.  I can be
> > convinced but as I'm personally staring down upgrading my 12.04
> > machine I need some reason.
> 
> For some reason I though the support life was 5 years desktop and
> longer for server, but it looks like 5 years was the server period. Oh
> well.
> 
> I suspect this patch may still be useful though; RHEL5 is still
> supported until March 31, 2017[1], and apparently has an even older
> compiler (gcc 4.1.x)[2]
> 
> [1] https://access.redhat.com/support/policy/updates/errata
> [2] https://access.redhat.com/solutions/19458

OK, that works for me, thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151116/1cd00da6/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04
  2015-11-16 13:07     ` Tom Rini
@ 2015-11-16 21:07       ` Simon Glass
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2015-11-16 21:07 UTC (permalink / raw)
  To: u-boot

On 16 November 2015 at 06:07, Tom Rini <trini@konsulko.com> wrote:
> On Sun, Nov 15, 2015 at 11:48:38PM -0700, Stephen Warren wrote:
>> On 11/15/2015 07:07 PM, Tom Rini wrote:
>> > On Sat, Nov 14, 2015 at 11:53:49PM -0700, Stephen Warren wrote:
>> >
>> >> gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu
>> >> 10.04) doesn't seem to like initializers for sub-fields of
>> >> anonymous unions. Solve this by replacing the initialization with
>> >> an assignment. This fixes:
>> >>
>> >> lib/lz4_wrapper.c: In function ?ulz4fn?: lib/lz4_wrapper.c:97:
>> >> error: unknown field ?raw? specified in initializer
>> >>
>> >> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> >
>> > So Ubuntu 10.04 hit end of life this past April.  I can be
>> > convinced but as I'm personally staring down upgrading my 12.04
>> > machine I need some reason.
>>
>> For some reason I though the support life was 5 years desktop and
>> longer for server, but it looks like 5 years was the server period. Oh
>> well.
>>
>> I suspect this patch may still be useful though; RHEL5 is still
>> supported until March 31, 2017[1], and apparently has an even older
>> compiler (gcc 4.1.x)[2]
>>
>> [1] https://access.redhat.com/support/policy/updates/errata
>> [2] https://access.redhat.com/solutions/19458
>
> OK, that works for me, thanks.
>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Acked-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [U-Boot] Fix sandbox build on Ubuntu 10.04
  2015-11-15  6:53 [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04 Stephen Warren
  2015-11-16  2:07 ` Tom Rini
@ 2015-11-18 22:36 ` Tom Rini
  1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2015-11-18 22:36 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 14, 2015 at 11:53:49PM -0700, Stephen Warren wrote:

> gcc 4.4.3 (which is the default native compiler on x86-64 Ubuntu 10.04)
> doesn't seem to like initializers for sub-fields of anonymous unions.
> Solve this by replacing the initialization with an assignment. This
> fixes:
> 
> lib/lz4_wrapper.c: In function ?ulz4fn?:
> lib/lz4_wrapper.c:97: error: unknown field ?raw? specified in initializer
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151118/03f96ea8/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-18 22:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-15  6:53 [U-Boot] [PATCH] Fix sandbox build on Ubuntu 10.04 Stephen Warren
2015-11-16  2:07 ` Tom Rini
2015-11-16  6:48   ` Stephen Warren
2015-11-16 13:07     ` Tom Rini
2015-11-16 21:07       ` Simon Glass
2015-11-18 22:36 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.