* [PATCH] usb: xhci-brcm: Include header file needed for dev_err
@ 2021-10-05 15:20 Stefan Agner
2021-10-05 17:27 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Agner @ 2021-10-05 15:20 UTC (permalink / raw)
To: u-boot; +Cc: seanga2, mbrugger, sjg, Stefan Agner, Bin Meng, Marek Vasut
dev_err seems to be moved to different header file. Include
dm/device_compat.h file to compile properly.
Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
drivers/usb/host/xhci-brcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
index 27c4bbfcba..ee3b55242e 100644
--- a/drivers/usb/host/xhci-brcm.c
+++ b/drivers/usb/host/xhci-brcm.c
@@ -5,6 +5,7 @@
#include <common.h>
#include <dm.h>
+#include <dm/device_compat.h>
#include <fdtdec.h>
#include <usb.h>
#include <asm/io.h>
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: xhci-brcm: Include header file needed for dev_err
2021-10-05 15:20 [PATCH] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
@ 2021-10-05 17:27 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2021-10-05 17:27 UTC (permalink / raw)
To: Stefan Agner
Cc: U-Boot Mailing List, Sean Anderson, Matthias Brugger, Bin Meng,
Marek Vasut
Hi Stefan,
On Tue, 5 Oct 2021 at 09:21, Stefan Agner <stefan@agner.ch> wrote:
>
> dev_err seems to be moved to different header file. Include
> dm/device_compat.h file to compile properly.
>
> Fixes: 69dae8902b16 ("linux/compat.h: Remove redefinition of dev_xxx macros")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>
> drivers/usb/host/xhci-brcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
> index 27c4bbfcba..ee3b55242e 100644
> --- a/drivers/usb/host/xhci-brcm.c
> +++ b/drivers/usb/host/xhci-brcm.c
> @@ -5,6 +5,7 @@
>
> #include <common.h>
> #include <dm.h>
> +#include <dm/device_compat.h>
> #include <fdtdec.h>
> #include <usb.h>
> #include <asm/io.h>
Should go here. Please see https://www.denx.de/wiki/U-Boot/CodingStyle
> --
> 2.33.0
>
Regards,
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-05 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-05 15:20 [PATCH] usb: xhci-brcm: Include header file needed for dev_err Stefan Agner
2021-10-05 17:27 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.