* [PATCH] fs: fix comment typo
@ 2022-08-21 15:25 Roger Knecht
2022-08-22 16:38 ` Simon Glass
0 siblings, 1 reply; 13+ messages in thread
From: Roger Knecht @ 2022-08-21 15:25 UTC (permalink / raw)
To: u-boot; +Cc: Roger Knecht
Fix typo in include/fs.h
Signed-off-by: Roger Knecht <rknecht@pm.me>
---
include/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/fs.h b/include/fs.h
index 2195dc172e..8370d88cb2 100644
--- a/include/fs.h
+++ b/include/fs.h
@@ -46,7 +46,7 @@ int do_fat_fsload(struct cmd_tbl *cmdtp, int flag, int argc,
int do_ext2load(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
/*
- * Tell the fs layer which block device an partition to use for future
+ * Tell the fs layer which block device and partition to use for future
* commands. This also internally identifies the filesystem that is present
* within the partition. The identification process may be limited to a
* specific filesystem type by passing FS_* in the fstype parameter.
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: fix comment typo
2022-08-21 15:25 [PATCH] fs: fix comment typo Roger Knecht
@ 2022-08-22 16:38 ` Simon Glass
0 siblings, 0 replies; 13+ messages in thread
From: Simon Glass @ 2022-08-22 16:38 UTC (permalink / raw)
To: Roger Knecht; +Cc: U-Boot Mailing List
On Sun, 21 Aug 2022 at 16:31, Roger Knecht <rknecht@pm.me> wrote:
>
> Fix typo in include/fs.h
>
> Signed-off-by: Roger Knecht <rknecht@pm.me>
> ---
> include/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-12 8:34 ` Christian Brauner
@ 2023-06-12 9:18 ` Bagas Sanjaya
0 siblings, 0 replies; 13+ messages in thread
From: Bagas Sanjaya @ 2023-06-12 9:18 UTC (permalink / raw)
To: Christian Brauner, Jonathan Corbet
Cc: Shaomin Deng, viro, linux-fsdevel, linux-kernel, Mao Zhu
On 6/12/23 15:34, Christian Brauner wrote:
>> Patch picked up and missing sender SOB added.
>
> I've been informed that I may not be allowed to do that.
> So dropping the sender SOB for now following willy's argument.
OK, thanks for resolving!
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-12 6:34 ` Christian Brauner
@ 2023-06-12 8:34 ` Christian Brauner
2023-06-12 9:18 ` Bagas Sanjaya
0 siblings, 1 reply; 13+ messages in thread
From: Christian Brauner @ 2023-06-12 8:34 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Bagas Sanjaya, Shaomin Deng, viro, linux-fsdevel, linux-kernel, Mao Zhu
On Mon, Jun 12, 2023 at 08:34:53AM +0200, Christian Brauner wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@gmail.com> writes:
> >
> > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> > >> From: Mao Zhu <zhumao001@208suo.com>
> > >>
> > >> Delete duplicated word in comment.
> > >
> > > On what function?
> >
> > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> > contributors into the ground? It appears I do. So:
> >
> > Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> > changelog is fine. We absolutely do not need you playing changelog cop
> > and harassing contributors over this kind of thing.
>
> 100% agreed.
>
> >
> > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> > >
> > > You're carrying someone else's patch, so besides SoB from original
> > > author, you need to also have your own SoB.
> >
> > This, instead, is a valid problem that needs to be fixed.
>
> Patch picked up and missing sender SOB added.
I've been informed that I may not be allowed to do that.
So dropping the sender SOB for now following willy's argument.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 19:50 ` Jonathan Corbet
2023-06-11 20:07 ` Matthew Wilcox
2023-06-12 1:41 ` Bagas Sanjaya
@ 2023-06-12 6:34 ` Christian Brauner
2023-06-12 8:34 ` Christian Brauner
2 siblings, 1 reply; 13+ messages in thread
From: Christian Brauner @ 2023-06-12 6:34 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Bagas Sanjaya, Shaomin Deng, viro, linux-fsdevel, linux-kernel, Mao Zhu
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
> > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> >> From: Mao Zhu <zhumao001@208suo.com>
> >>
> >> Delete duplicated word in comment.
> >
> > On what function?
>
> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> contributors into the ground? It appears I do. So:
>
> Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> changelog is fine. We absolutely do not need you playing changelog cop
> and harassing contributors over this kind of thing.
100% agreed.
>
> >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> >
> > You're carrying someone else's patch, so besides SoB from original
> > author, you need to also have your own SoB.
>
> This, instead, is a valid problem that needs to be fixed.
Patch picked up and missing sender SOB added.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 12:33 [PATCH] fs: Fix " Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya
@ 2023-06-12 6:31 ` Christian Brauner
1 sibling, 0 replies; 13+ messages in thread
From: Christian Brauner @ 2023-06-12 6:31 UTC (permalink / raw)
To: Shaomin Deng
Cc: Christian Brauner, linux-fsdevel, linux-kernel, Mao Zhu, viro,
Jonathan Corbet, Matthew Wilcox
On Sun, 11 Jun 2023 08:33:14 -0400, Shaomin Deng wrote:
> Delete duplicated word in comment.
>
>
Missing sender SOB added.
---
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/1] fs: Fix comment typo
https://git.kernel.org/vfs/vfs/c/dce5a4da3cf5
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 20:07 ` Matthew Wilcox
@ 2023-06-12 2:00 ` Bagas Sanjaya
0 siblings, 0 replies; 13+ messages in thread
From: Bagas Sanjaya @ 2023-06-12 2:00 UTC (permalink / raw)
To: Matthew Wilcox, Jonathan Corbet
Cc: Shaomin Deng, viro, brauner, linux-fsdevel, linux-kernel, Mao Zhu
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
On Sun, Jun 11, 2023 at 09:07:22PM +0100, Matthew Wilcox wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@gmail.com> writes:
> >
> > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> > >> From: Mao Zhu <zhumao001@208suo.com>
> > >>
> > >> Delete duplicated word in comment.
> > >
> > > On what function?
> >
> > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> > contributors into the ground? It appears I do. So:
> >
> > Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> > changelog is fine. We absolutely do not need you playing changelog cop
> > and harassing contributors over this kind of thing.
>
> Amen.
>
Amen too. Hope I can learn from this.
> > >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> > >
> > > You're carrying someone else's patch, so besides SoB from original
> > > author, you need to also have your own SoB.
> >
> > This, instead, is a valid problem that needs to be fixed.
>
> I mean ... yes, technically, it does. But it's a change that deletes
> a word in a comment. Honestly, I'd take the patch without any kind of
> sign-off. It doesn't create any copyright claim, which is the purpose
> of the DCO.
What? Relaxed SoB requirement for trivial patches like this? I thought
that SoB rules also apply to these patches.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-12 1:41 ` Bagas Sanjaya
@ 2023-06-12 1:53 ` Bagas Sanjaya
0 siblings, 0 replies; 13+ messages in thread
From: Bagas Sanjaya @ 2023-06-12 1:53 UTC (permalink / raw)
To: Jonathan Corbet, Shaomin Deng, viro, brauner
Cc: linux-fsdevel, linux-kernel, Mao Zhu
On 6/12/23 08:41, Bagas Sanjaya wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
>> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>>
>>> On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
>>>> From: Mao Zhu <zhumao001@208suo.com>
>>>>
>>>> Delete duplicated word in comment.
>>>
>>> On what function?
>>
>> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
>> contributors into the ground? It appears I do. So:
>>
>> Bagas, *stop* this. It's a typo patch removing an extraneous word. The
>> changelog is fine. We absolutely do not need you playing changelog cop
>> and harassing contributors over this kind of thing.
>
> OK, thanks for reminding me again.
>
> At the time of reviewing, I had bad feeling that @cdjrlc.com people will
> ignore review comments (I betted due to mail setup problem that prevents
> them from properly repling to mailing lists, which is unfortunate). I
> was nitpicking because the diff context doesn't look clear to me (what
> function name?).
>
And no wonder why several maintainers also highlight this (which prompted
me to review that way):
[1]: https://lore.kernel.org/all/162b5545-7d24-3cf2-9158-3100ef644e03@linux.intel.com/
[2]: https://lore.kernel.org/all/3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@HansenPartnership.com/
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 19:50 ` Jonathan Corbet
2023-06-11 20:07 ` Matthew Wilcox
@ 2023-06-12 1:41 ` Bagas Sanjaya
2023-06-12 1:53 ` Bagas Sanjaya
2023-06-12 6:34 ` Christian Brauner
2 siblings, 1 reply; 13+ messages in thread
From: Bagas Sanjaya @ 2023-06-12 1:41 UTC (permalink / raw)
To: Jonathan Corbet, Shaomin Deng, viro, brauner
Cc: linux-fsdevel, linux-kernel, Mao Zhu
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
> > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> >> From: Mao Zhu <zhumao001@208suo.com>
> >>
> >> Delete duplicated word in comment.
> >
> > On what function?
>
> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> contributors into the ground? It appears I do. So:
>
> Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> changelog is fine. We absolutely do not need you playing changelog cop
> and harassing contributors over this kind of thing.
OK, thanks for reminding me again.
At the time of reviewing, I had bad feeling that @cdjrlc.com people will
ignore review comments (I betted due to mail setup problem that prevents
them from properly repling to mailing lists, which is unfortunate). I
was nitpicking because the diff context doesn't look clear to me (what
function name?).
>
> >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> >
> > You're carrying someone else's patch, so besides SoB from original
> > author, you need to also have your own SoB.
>
> This, instead, is a valid problem that needs to be fixed.
OK.
Sorry for my inconvenience.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 19:50 ` Jonathan Corbet
@ 2023-06-11 20:07 ` Matthew Wilcox
2023-06-12 2:00 ` Bagas Sanjaya
2023-06-12 1:41 ` Bagas Sanjaya
2023-06-12 6:34 ` Christian Brauner
2 siblings, 1 reply; 13+ messages in thread
From: Matthew Wilcox @ 2023-06-11 20:07 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Bagas Sanjaya, Shaomin Deng, viro, brauner, linux-fsdevel,
linux-kernel, Mao Zhu
On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
> > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> >> From: Mao Zhu <zhumao001@208suo.com>
> >>
> >> Delete duplicated word in comment.
> >
> > On what function?
>
> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
> contributors into the ground? It appears I do. So:
>
> Bagas, *stop* this. It's a typo patch removing an extraneous word. The
> changelog is fine. We absolutely do not need you playing changelog cop
> and harassing contributors over this kind of thing.
Amen.
> >> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
> >
> > You're carrying someone else's patch, so besides SoB from original
> > author, you need to also have your own SoB.
>
> This, instead, is a valid problem that needs to be fixed.
I mean ... yes, technically, it does. But it's a change that deletes
a word in a comment. Honestly, I'd take the patch without any kind of
sign-off. It doesn't create any copyright claim, which is the purpose
of the DCO.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 12:54 ` Bagas Sanjaya
@ 2023-06-11 19:50 ` Jonathan Corbet
2023-06-11 20:07 ` Matthew Wilcox
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Jonathan Corbet @ 2023-06-11 19:50 UTC (permalink / raw)
To: Bagas Sanjaya, Shaomin Deng, viro, brauner
Cc: linux-fsdevel, linux-kernel, Mao Zhu
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
>> From: Mao Zhu <zhumao001@208suo.com>
>>
>> Delete duplicated word in comment.
>
> On what function?
Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
contributors into the ground? It appears I do. So:
Bagas, *stop* this. It's a typo patch removing an extraneous word. The
changelog is fine. We absolutely do not need you playing changelog cop
and harassing contributors over this kind of thing.
>> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
>
> You're carrying someone else's patch, so besides SoB from original
> author, you need to also have your own SoB.
This, instead, is a valid problem that needs to be fixed.
Thanks,
jon
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] fs: Fix comment typo
2023-06-11 12:33 [PATCH] fs: Fix " Shaomin Deng
@ 2023-06-11 12:54 ` Bagas Sanjaya
2023-06-11 19:50 ` Jonathan Corbet
2023-06-12 6:31 ` Christian Brauner
1 sibling, 1 reply; 13+ messages in thread
From: Bagas Sanjaya @ 2023-06-11 12:54 UTC (permalink / raw)
To: Shaomin Deng, viro, brauner; +Cc: linux-fsdevel, linux-kernel, Mao Zhu
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
> From: Mao Zhu <zhumao001@208suo.com>
>
> Delete duplicated word in comment.
On what function?
>
> Signed-off-by: Mao Zhu <zhumao001@208suo.com>
You're carrying someone else's patch, so besides SoB from original
author, you need to also have your own SoB.
> ---
> include/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index df6c1817906f..aa870b77cc2b 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb);
> void dump_mapping(const struct address_space *);
>
> /*
> - * Userspace may rely on the the inode number being non-zero. For example, glibc
> + * Userspace may rely on the inode number being non-zero. For example, glibc
> * simply ignores files with zero i_ino in unlink() and other places.
> *
> * As an additional complication, if userspace was compiled with
I don't see the function name in above diff (dump_mapping() isn't the
function I mean). Regardless, the fix LGTM.
@cdjrlc.com developers: I'm really, really fed up with you ignoring
review comments. It seems like you have issues on your mail setup. Fix
your mailer! Until then, I just say NAK.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] fs: Fix comment typo
@ 2023-06-11 12:33 Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya
2023-06-12 6:31 ` Christian Brauner
0 siblings, 2 replies; 13+ messages in thread
From: Shaomin Deng @ 2023-06-11 12:33 UTC (permalink / raw)
To: viro, brauner; +Cc: linux-fsdevel, linux-kernel, Mao Zhu
From: Mao Zhu <zhumao001@208suo.com>
Delete duplicated word in comment.
Signed-off-by: Mao Zhu <zhumao001@208suo.com>
---
include/linux/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index df6c1817906f..aa870b77cc2b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2675,7 +2675,7 @@ extern void evict_inodes(struct super_block *sb);
void dump_mapping(const struct address_space *);
/*
- * Userspace may rely on the the inode number being non-zero. For example, glibc
+ * Userspace may rely on the inode number being non-zero. For example, glibc
* simply ignores files with zero i_ino in unlink() and other places.
*
* As an additional complication, if userspace was compiled with
--
2.35.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-06-12 9:25 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-21 15:25 [PATCH] fs: fix comment typo Roger Knecht
2022-08-22 16:38 ` Simon Glass
2023-06-11 12:33 [PATCH] fs: Fix " Shaomin Deng
2023-06-11 12:54 ` Bagas Sanjaya
2023-06-11 19:50 ` Jonathan Corbet
2023-06-11 20:07 ` Matthew Wilcox
2023-06-12 2:00 ` Bagas Sanjaya
2023-06-12 1:41 ` Bagas Sanjaya
2023-06-12 1:53 ` Bagas Sanjaya
2023-06-12 6:34 ` Christian Brauner
2023-06-12 8:34 ` Christian Brauner
2023-06-12 9:18 ` Bagas Sanjaya
2023-06-12 6:31 ` Christian Brauner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.