All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries
@ 2018-06-27 13:38 Adam Sampson
  2018-06-27 13:38 ` [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace Adam Sampson
  2018-06-30  4:19 ` [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Simon Glass
  0 siblings, 2 replies; 6+ messages in thread
From: Adam Sampson @ 2018-06-27 13:38 UTC (permalink / raw)
  To: u-boot

patman's _ReadAliasFile only splits on spaces, not tabs, so the entries
for dinh and maxime weren't being recognised as valid. I'll fix patman
in a separate patch, but this makes all the entries consistent.

Signed-off-by: Adam Sampson <ats@offog.org>
---

 doc/git-mailrc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/git-mailrc b/doc/git-mailrc
index af8e3358a9..3a490beee2 100644
--- a/doc/git-mailrc
+++ b/doc/git-mailrc
@@ -20,7 +20,7 @@ alias alisonwang     Alison Wang <alison.wang@nxp.com>
 alias angelo_ts      Angelo Dureghello <angelo@sysam.it>
 alias bmeng          Bin Meng <bmeng.cn@gmail.com>
 alias danielschwierzeck Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
-alias dinh	     Dinh Nguyen <dinguyen@kernel.org>
+alias dinh           Dinh Nguyen <dinguyen@kernel.org>
 alias hs             Heiko Schocher <hs@denx.de>
 alias iwamatsu       Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
 alias jaehoon        Jaehoon Chung <jh80.chung@samsung.com>
@@ -33,7 +33,7 @@ alias marex          Marek Vasut <marex@denx.de>
 alias mariosix       Mario Six <mario.six@gdsys.cc>
 alias masahiro       Masahiro Yamada <yamada.masahiro@socionext.com>
 alias mateusz        Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
-alias maxime	     Maxime Ripard <maxime.ripard@free-electrons.com>
+alias maxime         Maxime Ripard <maxime.ripard@free-electrons.com>
 alias monstr         Michal Simek <monstr@monstr.eu>
 alias prafulla       Prafulla Wadaskar <prafulla@marvell.com>
 alias prom           Minkyu Kang <mk7.kang@samsung.com>
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace
  2018-06-27 13:38 [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Adam Sampson
@ 2018-06-27 13:38 ` Adam Sampson
  2018-06-30  4:19   ` Simon Glass
  2018-06-30  4:19 ` [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Simon Glass
  1 sibling, 1 reply; 6+ messages in thread
From: Adam Sampson @ 2018-06-27 13:38 UTC (permalink / raw)
  To: u-boot

Previously the first three words in a git-mailrc alias entry could only
be separated by spaces. git-send-email and Mutt both allow arbitrary
whitespace here.

Signed-off-by: Adam Sampson <ats@offog.org>
---

 tools/patman/settings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/patman/settings.py b/tools/patman/settings.py
index 94ea5b5a1b..ca4334426b 100644
--- a/tools/patman/settings.py
+++ b/tools/patman/settings.py
@@ -263,7 +263,7 @@ def _ReadAliasFile(fname):
                 line = line.strip()
                 if not line or line.startswith('#'):
                     continue
-                words = line.split(' ', 2)
+                words = line.split(None, 2)
                 if len(words) < 3 or words[0] != 'alias':
                     if not bad_line:
                         bad_line = "%s:%d:Invalid line '%s'" % (fname, linenum,
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries
  2018-06-27 13:38 [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Adam Sampson
  2018-06-27 13:38 ` [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace Adam Sampson
@ 2018-06-30  4:19 ` Simon Glass
  2018-07-27  0:35   ` Simon Glass
  1 sibling, 1 reply; 6+ messages in thread
From: Simon Glass @ 2018-06-30  4:19 UTC (permalink / raw)
  To: u-boot

On 27 June 2018 at 06:38, Adam Sampson <ats@offog.org> wrote:
> patman's _ReadAliasFile only splits on spaces, not tabs, so the entries
> for dinh and maxime weren't being recognised as valid. I'll fix patman
> in a separate patch, but this makes all the entries consistent.
>
> Signed-off-by: Adam Sampson <ats@offog.org>
> ---
>
>  doc/git-mailrc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace
  2018-06-27 13:38 ` [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace Adam Sampson
@ 2018-06-30  4:19   ` Simon Glass
  2018-07-27  0:35     ` Simon Glass
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Glass @ 2018-06-30  4:19 UTC (permalink / raw)
  To: u-boot

On 27 June 2018 at 06:38, Adam Sampson <ats@offog.org> wrote:
> Previously the first three words in a git-mailrc alias entry could only
> be separated by spaces. git-send-email and Mutt both allow arbitrary
> whitespace here.
>
> Signed-off-by: Adam Sampson <ats@offog.org>
> ---
>
>  tools/patman/settings.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries
  2018-06-30  4:19 ` [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Simon Glass
@ 2018-07-27  0:35   ` Simon Glass
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2018-07-27  0:35 UTC (permalink / raw)
  To: u-boot

On 29 June 2018 at 22:19, Simon Glass <sjg@chromium.org> wrote:
> On 27 June 2018 at 06:38, Adam Sampson <ats@offog.org> wrote:
>> patman's _ReadAliasFile only splits on spaces, not tabs, so the entries
>> for dinh and maxime weren't being recognised as valid. I'll fix patman
>> in a separate patch, but this makes all the entries consistent.
>>
>> Signed-off-by: Adam Sampson <ats@offog.org>
>> ---
>>
>>  doc/git-mailrc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace
  2018-06-30  4:19   ` Simon Glass
@ 2018-07-27  0:35     ` Simon Glass
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2018-07-27  0:35 UTC (permalink / raw)
  To: u-boot

On 29 June 2018 at 22:19, Simon Glass <sjg@chromium.org> wrote:
> On 27 June 2018 at 06:38, Adam Sampson <ats@offog.org> wrote:
>> Previously the first three words in a git-mailrc alias entry could only
>> be separated by spaces. git-send-email and Mutt both allow arbitrary
>> whitespace here.
>>
>> Signed-off-by: Adam Sampson <ats@offog.org>
>> ---
>>
>>  tools/patman/settings.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-27  0:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 13:38 [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Adam Sampson
2018-06-27 13:38 ` [U-Boot] [PATCH 2/2] patman: Split alias entries on arbitrary whitespace Adam Sampson
2018-06-30  4:19   ` Simon Glass
2018-07-27  0:35     ` Simon Glass
2018-06-30  4:19 ` [U-Boot] [PATCH 1/2] git-mailrc: Replace tabs with spaces in alias entries Simon Glass
2018-07-27  0:35   ` Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.