Re: [PATCH v2 1/2] Makefile: Create a file to indicate the config

From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Michal Simek <monstr@monstr.eu>, huang lin <hl@rock-chips.com>,
	Jeffy Chen <jeffy.chen@rock-chips.com>,
	 Kever Yang <kever.yang@rock-chips.com>,
	 Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	 "NXP i . MX U-Boot Team" <uboot-imx@nxp.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	 Wolfgang Denk <wd@denx.de>
Subject: Re: [PATCH v2 1/2] Makefile: Create a file to indicate the config
Date: Mon, 31 Jan 2022 10:27:38 -0700	[thread overview]
Message-ID: <CAPnjgZ38KjA6gswKRWD6KHKmC+uwX5hUOfnR0ko17NTquOoz0Q@mail.gmail.com> (raw)
In-Reply-To: <20220131162138.GA7515@bill-the-cat>

Hi Tom,

On Mon, 31 Jan 2022 at 09:21, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Jan 31, 2022 at 09:13:07AM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Mon, 31 Jan 2022 at 07:24, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Sun, Jan 30, 2022 at 08:52:24AM -0700, Simon Glass wrote:
> > >
> > > > At present it is not actually possible to discover the defconfig file that
> > > > was used to build U-Boot, so far as I can tell. Write this out to a file
> > > > in the build directory, so this is visible.
> > > >
> > > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > I don't think we need this really normally, it's just for the follow-up
> > > patch.
> >
> > I'd argue that it is helpful to have this somewhere. Is there anywhere
> > else in the build directory where it can be discovered?
>
> It's not a guarantee to exist is my first problem.  My minor problems

Do you mean there might not be a defconfig file? Yes I see. But
generally there is, e.g. with buildman.

> are this needs to be in .gitignore and also I think this wasn't ensuring
> output directory not source directory.  But I don't see the use case
> this is filling.  If you're in-tree, you should know what you configured
> and are working on.  If you're out of tree and didn't do any sort of
> naming convention to your objdirs, did you also really care what
> defconfig exactly (I use a mix of named and garbage-named temp dirs)?
> And if you're a tool of some sort, you were told what to use at some
> point I would assume.  Which all gets back to I don't see the use case
> exactly for it.

I was just surprised that there was no way to find it out, that's all.
It seems like a gap. But I agree that if we don't have a specific use
case (e.g. we figure out another way of doing the next patch) then we
could wait.

Regards,
Simon