From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/6] x86: Add header files for Intel Quark SoC defines
Date: Wed, 28 Jan 2015 19:00:51 -0700 [thread overview]
Message-ID: <CAPnjgZ39pmaDtbJi7EQ7WG3vuBhf9svhnGvw+OE_6hM1vPUi4A@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmVGT4=FC=Z1Hrfbd2n=bZd2d1T7PGo4yqg=89f0A75Z7w@mail.gmail.com>
Hi Bin,
On 28 January 2015 at 18:58, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Thu, Jan 29, 2015 at 2:04 AM, Simon Glass <sjg@chromium.org> wrote:
>> Hi Bin,
>>
>> On 28 January 2015 at 07:19, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> device.h for integrated pci devices' bdf on Quark SoC and quark.h for
>>> various memory-mapped and i/o-mapped base addresses within SoC.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>>
>>> arch/x86/include/asm/arch-quark/device.h | 28 ++++++++++++++++
>>> arch/x86/include/asm/arch-quark/quark.h | 57 ++++++++++++++++++++++++++++++++
>>> 2 files changed, 85 insertions(+)
>>> create mode 100644 arch/x86/include/asm/arch-quark/device.h
>>> create mode 100644 arch/x86/include/asm/arch-quark/quark.h
>>>
>>> diff --git a/arch/x86/include/asm/arch-quark/device.h b/arch/x86/include/asm/arch-quark/device.h
>>> new file mode 100644
>>> index 0000000..4af3ded
>>> --- /dev/null
>>> +++ b/arch/x86/include/asm/arch-quark/device.h
>>> @@ -0,0 +1,28 @@
>>> +/*
>>> + * Copyright (C) 2015, Bin Meng <bmeng.cn@gmail.com>
>>> + *
>>> + * SPDX-License-Identifier: GPL-2.0+
>>> + */
>>> +
>>> +#ifndef _QUARK_DEVICE_H_
>>> +#define _QUARK_DEVICE_H_
>>> +
>>> +#include <pci.h>
>>> +
>>> +#define QUARK_HOST_BRIDGE PCI_BDF(0, 0, 0)
>>> +#define QUARK_MMC_SDIO PCI_BDF(0, 20, 0)
>>> +#define QUARK_UART0 PCI_BDF(0, 20, 1)
>>> +#define QUARK_USB_DEVICE PCI_BDF(0, 20, 2)
>>> +#define QUARK_USB_EHCI PCI_BDF(0, 20, 3)
>>> +#define QUARK_USB_OHCI PCI_BDF(0, 20, 4)
>>> +#define QUARK_UART1 PCI_BDF(0, 20, 5)
>>> +#define QUARK_EMAC0 PCI_BDF(0, 20, 6)
>>> +#define QUARK_EMAC1 PCI_BDF(0, 20, 7)
>>> +#define QUARK_SPI0 PCI_BDF(0, 21, 0)
>>> +#define QUARK_SPI1 PCI_BDF(0, 21, 1)
>>> +#define QUARK_I2C_GPIO PCI_BDF(0, 21, 2)
>>> +#define QUARK_PCIE0 PCI_BDF(0, 23, 0)
>>> +#define QUARK_PCIE1 PCI_BDF(0, 23, 1)
>>> +#define QUARK_LEGACY_BRIDGE PCI_BDF(0, 31, 0)
>>> +
>>> +#endif /* _QUARK_DEVICE_H_ */
>>> diff --git a/arch/x86/include/asm/arch-quark/quark.h b/arch/x86/include/asm/arch-quark/quark.h
>>> new file mode 100644
>>> index 0000000..6eef2d1
>>> --- /dev/null
>>> +++ b/arch/x86/include/asm/arch-quark/quark.h
>>> @@ -0,0 +1,57 @@
>>> +/*
>>> + * Copyright (C) 2015, Bin Meng <bmeng.cn@gmail.com>
>>> + *
>>> + * SPDX-License-Identifier: GPL-2.0+
>>> + */
>>> +
>>> +#ifndef _QUARK_H_
>>> +#define _QUARK_H_
>>> +
>>> +/* The following are Memory Base Addresses */
>>> +
>>> +/* DRAM */
>>> +#define DRAM_BASE 0x00000000
>>> +#define DRAM_MAX_SIZE 0x80000000
>>> +
>>> +/* eSRAM */
>>> +#define ESRAM_BASE (DRAM_BASE + DRAM_MAX_SIZE)
>>> +#define ESRAM_SIZE 0x80000
>>> +
>>> +/* SMM Control */
>>> +
>>> +/* PCIe ECAM */
>>> +#define PCIE_ECAM_BASE 0xE0000000
>>
>> Can we use lower case hex?
>>
>
> Sure. But I wonder if there is any coding standard that requires such
> address needs to be in lower case hex?
Only that it's nice to be consistent and I've tried to use lower case in x86.
>
>> I suppose this one will move to Kconfig before we apply it?
>
> Yes, this one can be moved to Kconfig after your Minowmax series.
>
>> What about the others?
>
> These base addresses can be relocatable, just like the PCIe ECAM, but
> requires the person who knows what they exactly mean. These values are
> actually suggested by Intel's UEFI firmware writer guide, so I would
> like to put them just in header file. However it there any rule on
> what needs to be put in Kconfig?
Anything starting with CONFIG is all I am aware of. If they are not
really configurable then it doesn't make sense to put them in Kconfig.
>
>>> +
>>> +/* RCBA */
>>> +#define RCBA_BASE 0xFED1C000
>>> +
>>> +/* Memory BAR Enable */
>>> +#define MEM_BAR_EN 0x00000001
>>> +
>>> +/* 64KiB of RMU binary in flash */
>>> +#define RMU_BINARY_SIZE 0x10000
>>> +
>>> +/* The following are I/O Base Addresses */
>>> +
>>> +/* ACPI PM1 Block */
>>> +#define ACPI_PM1_BASE 0x1000
>>> +
>>> +/* ACPI P Block */
>>> +#define ACPI_P_BASE 0x1010
>>> +
>>> +/* SPI DMA */
>>> +#define SPI_DMA_BASE 0x1020
>>> +
>>> +/* GPIO */
>>> +#define GPIO_BASE 0x1080
>>> +
>>> +/* GPE0 */
>>> +#define GPE0_BASE 0x1100
>>> +
>>> +/* WDT */
>>> +#define WDT_BASE 0x1140
>>> +
>>> +/* I/O BAR Enable */
>>> +#define IO_BAR_EN 0x80000000
>>> +
>>> +#endif /* _QUARK_H_ */
>>> --
Regards,
Simon
next prev parent reply other threads:[~2015-01-29 2:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 15:19 [U-Boot] [RFC PATCH 0/6] x86: New Intel Quark SoC support Bin Meng
2015-01-28 15:19 ` [U-Boot] [RFC PATCH 1/6] x86: Add header files for Intel Quark SoC defines Bin Meng
2015-01-28 18:04 ` Simon Glass
2015-01-29 1:58 ` Bin Meng
2015-01-29 2:00 ` Simon Glass [this message]
2015-01-28 15:19 ` [U-Boot] [RFC PATCH 2/6] x86: quark: Add routines to access message bus registers Bin Meng
2015-01-28 18:04 ` Simon Glass
2015-01-29 2:10 ` Bin Meng
2015-01-28 15:19 ` [U-Boot] [RFC PATCH 3/6] x86: quark: Add Cache-As-RAM initialization Bin Meng
2015-01-28 18:04 ` Simon Glass
2015-01-29 2:12 ` Bin Meng
2015-01-28 15:20 ` [U-Boot] [RFC PATCH 4/6] x86: Add basic Intel Quark processor support Bin Meng
2015-01-28 18:05 ` Simon Glass
2015-01-29 2:17 ` Bin Meng
2015-01-29 2:25 ` Simon Glass
2015-01-28 15:20 ` [U-Boot] [RFC PATCH 5/6] x86: Add basic Intel Galileo board support Bin Meng
2015-01-28 18:05 ` Simon Glass
2015-01-28 15:20 ` [U-Boot] [RFC PATCH 6/6] x86: Enable the Intel quark/galileo build Bin Meng
2015-01-28 18:05 ` Simon Glass
2015-01-28 18:05 ` [U-Boot] [RFC PATCH 0/6] x86: New Intel Quark SoC support Simon Glass
2015-01-29 2:27 ` Bin Meng
2015-01-29 2:30 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ39pmaDtbJi7EQ7WG3vuBhf9svhnGvw+OE_6hM1vPUi4A@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.