All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq
@ 2019-10-22  7:39 Kever Yang
  2019-10-27 16:32 ` Simon Glass
  2019-10-29 23:21 ` sjg at google.com
  0 siblings, 2 replies; 3+ messages in thread
From: Kever Yang @ 2019-10-22  7:39 UTC (permalink / raw)
  To: u-boot

Use log() insted of debug() for uclass_find_device_by_seq function,
since this print is very much and we can filter it out with log()
interface.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2:
- use log_debug() instead of log()

 drivers/core/uclass.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
index b33296542f..3bf6b4cd2d 100644
--- a/drivers/core/uclass.c
+++ b/drivers/core/uclass.c
@@ -17,6 +17,8 @@
 #include <dm/uclass-internal.h>
 #include <dm/util.h>
 
+#define LOG_CATEGORY LOGC_DM
+
 DECLARE_GLOBAL_DATA_PTR;
 
 struct uclass *uclass_find(enum uclass_id key)
@@ -301,7 +303,7 @@ int uclass_find_device_by_seq(enum uclass_id id, int seq_or_req_seq,
 	int ret;
 
 	*devp = NULL;
-	debug("%s: %d %d\n", __func__, find_req_seq, seq_or_req_seq);
+	log_debug("%d %d\n", find_req_seq, seq_or_req_seq);
 	if (seq_or_req_seq == -1)
 		return -ENODEV;
 	ret = uclass_get(id, &uc);
@@ -309,15 +311,16 @@ int uclass_find_device_by_seq(enum uclass_id id, int seq_or_req_seq,
 		return ret;
 
 	uclass_foreach_dev(dev, uc) {
-		debug("   - %d %d '%s'\n", dev->req_seq, dev->seq, dev->name);
+		log_debug("   - %d %d '%s'\n",
+			  dev->req_seq, dev->seq, dev->name);
 		if ((find_req_seq ? dev->req_seq : dev->seq) ==
 				seq_or_req_seq) {
 			*devp = dev;
-			debug("   - found\n");
+			log_debug("   - found\n");
 			return 0;
 		}
 	}
-	debug("   - not found\n");
+	log_debug("   - not found\n");
 
 	return -ENODEV;
 }
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq
  2019-10-22  7:39 [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq Kever Yang
@ 2019-10-27 16:32 ` Simon Glass
  2019-10-29 23:21 ` sjg at google.com
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2019-10-27 16:32 UTC (permalink / raw)
  To: u-boot

On Tue, 22 Oct 2019 at 01:40, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Use log() insted of debug() for uclass_find_device_by_seq function,
> since this print is very much and we can filter it out with log()
> interface.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2:
> - use log_debug() instead of log()
>
>  drivers/core/uclass.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq
  2019-10-22  7:39 [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq Kever Yang
  2019-10-27 16:32 ` Simon Glass
@ 2019-10-29 23:21 ` sjg at google.com
  1 sibling, 0 replies; 3+ messages in thread
From: sjg at google.com @ 2019-10-29 23:21 UTC (permalink / raw)
  To: u-boot

On Tue, 22 Oct 2019 at 01:40, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Use log() insted of debug() for uclass_find_device_by_seq function,
> since this print is very much and we can filter it out with log()
> interface.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2:
> - use log_debug() instead of log()
>
>  drivers/core/uclass.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-29 23:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22  7:39 [U-Boot] [PATCH v2] dm: core: Update log method for uclass_find_device_by_seq Kever Yang
2019-10-27 16:32 ` Simon Glass
2019-10-29 23:21 ` sjg at google.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.