[PATCH v2] binman: Fix replace subcommand help and comments

[PATCH v2] binman: Fix replace subcommand help and comments

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Fix some copy&paste artifacts.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 tools/binman/cmdline.py | 4 ++--
 tools/binman/control.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/binman/cmdline.py b/tools/binman/cmdline.py
index d6156df408..d053d1be90 100644
--- a/tools/binman/cmdline.py
+++ b/tools/binman/cmdline.py
@@ -99,7 +99,7 @@ controlled by a description in the board device tree.'''
     replace_parser.add_argument('-C', '--compressed', action='store_true',
         help='Input data is already compressed if needed for the entry')
     replace_parser.add_argument('-i', '--image', type=str, required=True,
-                                help='Image filename to extract')
+                                help='Image filename to update')
     replace_parser.add_argument('-f', '--filename', type=str,
                                 help='Input filename to read from')
     replace_parser.add_argument('-F', '--fix-size', action='store_true',
@@ -109,7 +109,7 @@ controlled by a description in the board device tree.'''
     replace_parser.add_argument('-m', '--map', action='store_true',
         default=False, help='Output a map file for the updated image')
     replace_parser.add_argument('paths', type=str, nargs='*',
-                                help='Paths within file to extract (wildcard)')
+                                help='Paths within file to replace (wildcard)')
 
     test_parser = subparsers.add_parser('test', help='Run tests')
     test_parser.add_argument('-P', '--processes', type=int,
diff --git a/tools/binman/control.py b/tools/binman/control.py
index 0dbcbc28e9..8b5085152a 100644
--- a/tools/binman/control.py
+++ b/tools/binman/control.py
@@ -343,10 +343,10 @@ def ReplaceEntries(image_fname, input_fname, indir, entry_paths,
 
     Args:
         image_fname: Image filename to process
-        input_fname: Single input ilename to use if replacing one file, None
+        input_fname: Single input filename to use if replacing one file, None
             otherwise
         indir: Input directory to use (for any number of files), else None
-        entry_paths: List of entry paths to extract
+        entry_paths: List of entry paths to replace
         do_compress: True if the input data is uncompressed and may need to be
             compressed if the entry requires it, False if the data is already
             compressed.
-- 
2.31.1

Re: [PATCH v2] binman: Fix replace subcommand help and comments

[Simon Glass]

On Thu, 11 Nov 2021 at 00:13, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Fix some copy&paste artifacts.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  tools/binman/cmdline.py | 4 ++--
>  tools/binman/control.py | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Please add a change log with a v2 patch.

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH v2] binman: Fix replace subcommand help and comments

[Simon Glass]

On Thu, 11 Nov 2021 at 00:13, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Fix some copy&paste artifacts.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  tools/binman/cmdline.py | 4 ++--
>  tools/binman/control.py | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Please add a change log with a v2 patch.

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!