All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] imx: ventana: use stack relocation
@ 2015-05-14 13:22 Tim Harvey
  2015-05-14 14:30 ` Simon Glass
  2015-05-15 14:44 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Tim Harvey @ 2015-05-14 13:22 UTC (permalink / raw)
  To: u-boot

Certain features we desire require a larger stack than is available by using
iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that
we can use these features.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
 configs/gwventana_defconfig                 | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c
index 289a0b8..8d41bb4 100644
--- a/board/gateworks/gw_ventana/gw_ventana_spl.c
+++ b/board/gateworks/gw_ventana/gw_ventana_spl.c
@@ -565,9 +565,6 @@ void board_init_f(ulong dummy)
 
 	/* Clear the BSS. */
 	memset(__bss_start, 0, __bss_end - __bss_start);
-
-	/* load/boot image from boot device */
-	board_init_r(NULL, 0);
 }
 
 void reset_cpu(ulong addr)
diff --git a/configs/gwventana_defconfig b/configs/gwventana_defconfig
index d6bbdc1..b28fe4b 100644
--- a/configs/gwventana_defconfig
+++ b/configs/gwventana_defconfig
@@ -3,3 +3,5 @@ CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL"
 CONFIG_ARM=y
 CONFIG_TARGET_GW_VENTANA=y
 CONFIG_SYS_MALLOC_F=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_ADDR=0x18000000
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] imx: ventana: use stack relocation
  2015-05-14 13:22 [U-Boot] [PATCH] imx: ventana: use stack relocation Tim Harvey
@ 2015-05-14 14:30 ` Simon Glass
  2015-05-15 14:44 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2015-05-14 14:30 UTC (permalink / raw)
  To: u-boot

On 14 May 2015 at 07:22, Tim Harvey <tharvey@gateworks.com> wrote:
> Certain features we desire require a larger stack than is available by using
> iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that
> we can use these features.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
>  configs/gwventana_defconfig                 | 2 ++
>  2 files changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] imx: ventana: use stack relocation
  2015-05-14 13:22 [U-Boot] [PATCH] imx: ventana: use stack relocation Tim Harvey
  2015-05-14 14:30 ` Simon Glass
@ 2015-05-15 14:44 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2015-05-15 14:44 UTC (permalink / raw)
  To: u-boot

Hi Tim,

On 14/05/2015 15:22, Tim Harvey wrote:
> Certain features we desire require a larger stack than is available by using
> iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that
> we can use these features.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
>  configs/gwventana_defconfig                 | 2 ++
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c
> index 289a0b8..8d41bb4 100644
> --- a/board/gateworks/gw_ventana/gw_ventana_spl.c
> +++ b/board/gateworks/gw_ventana/gw_ventana_spl.c
> @@ -565,9 +565,6 @@ void board_init_f(ulong dummy)
>  
>  	/* Clear the BSS. */
>  	memset(__bss_start, 0, __bss_end - __bss_start);
> -
> -	/* load/boot image from boot device */
> -	board_init_r(NULL, 0);
>  }
>  
>  void reset_cpu(ulong addr)
> diff --git a/configs/gwventana_defconfig b/configs/gwventana_defconfig
> index d6bbdc1..b28fe4b 100644
> --- a/configs/gwventana_defconfig
> +++ b/configs/gwventana_defconfig
> @@ -3,3 +3,5 @@ CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL"
>  CONFIG_ARM=y
>  CONFIG_TARGET_GW_VENTANA=y
>  CONFIG_SYS_MALLOC_F=y
> +CONFIG_SPL_STACK_R=y
> +CONFIG_SPL_STACK_R_ADDR=0x18000000
> 

Applied to u-boot-imx, thanks !

Best regards,
     Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-15 14:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-14 13:22 [U-Boot] [PATCH] imx: ventana: use stack relocation Tim Harvey
2015-05-14 14:30 ` Simon Glass
2015-05-15 14:44 ` Stefano Babic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.