Re: [PATCH 3/5] patman: test_util: Use unittest text runner to print test results

From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Walter Lozano <walter.lozano@collabora.com>,
	 Alper Nebi Yasak <alpernebiyasak@gmail.com>
Subject: Re: [PATCH 3/5] patman: test_util: Use unittest text runner to print test results
Date: Tue, 28 Jun 2022 09:38:13 -0400	[thread overview]
Message-ID: <CAPnjgZ3dh55sFOqDYuO_G7RpTb+mYcL1d5aWq=0wHVGZddNRSg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ2xRm7=E1tr19A0xWje35=7H-QULvj7LVa3vP_9FJucaQ@mail.gmail.com>

On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> The python tools' test utilities handle printing test results, but the
> output is quite bare compared to an ordinary unittest run. Delegate
> printing the results to a unittest text runner, which gives us niceties
> like clear separation between each test's result and how long it took to
> run the test suite.
>
> Unfortunately it does not print info for skipped tests by default, but
> this can be handled later by a custom test result subclass. It also does
> not print the tool name; manually print a heading that includes the
> toolname so that the outputs of each tool's tests are distinguishable in
> the CI output.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> ---
>
>  tools/binman/main.py      |  8 ++----
>  tools/buildman/main.py    |  8 ++----
>  tools/dtoc/main.py        |  9 +++---
>  tools/dtoc/test_fdt.py    |  8 +++---
>  tools/patman/main.py      |  8 ++----
>  tools/patman/test_util.py | 58 ++++++++++++++-------------------------
>  6 files changed, 38 insertions(+), 61 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!