Re: [PATCH 2/5] patman: test_util: Handle nonexistent tests while loading tests

From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Walter Lozano <walter.lozano@collabora.com>,
	 Alper Nebi Yasak <alpernebiyasak@gmail.com>
Subject: Re: [PATCH 2/5] patman: test_util: Handle nonexistent tests while loading tests
Date: Tue, 28 Jun 2022 09:38:14 -0400	[thread overview]
Message-ID: <CAPnjgZ0cEin0sogLUhJfRGa2034x52qJN97tDDsBZEyyAtsnqQ@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ17V=gDGV6NBQDcMLk05E+F_QyRFLSq7K9wMnhT-eGCuw@mail.gmail.com>

On Sat, 2 Apr 2022 at 11:06, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> It's possible to request a specific test to run when trying to run a
> python tool's tests. If we request a nonexistent test, the unittest
> loaders generate a fake test that reports this as an error. However, we
> get these fake tests even when the test exists, because test_util can
> load tests from multiple places one by one and the test we want only
> exists in one.
>
> The test_util helpers currently remove these fake tests when printing
> test results, but that's more of a workaround than a proper solution.
> Instead, don't even try to load the missing tests.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> ---
>
>  tools/patman/test_util.py | 21 +++++----------------
>  1 file changed, 5 insertions(+), 16 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!