All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 4/4] dm: gpio: introduce 74x164 driver
Date: Sat, 7 May 2016 13:03:24 -0600	[thread overview]
Message-ID: <CAPnjgZ3pQPqsj0VGvOnYtmdD63NfkXhwiDOGvVy80U68HP9xuA@mail.gmail.com> (raw)
In-Reply-To: <1462240943-488-4-git-send-email-van.freenix@gmail.com>

On 2 May 2016 at 20:02, Peng Fan <van.freenix@gmail.com> wrote:
> Introduce driver to support "fairchild,74hc595" devices.
> 1. Take linux drivers/drivers/gpio/gpio-74x164.c as reference.
> 2. Following the naming used in Linux driver with gen_7x164 as the prefix.
> 3. Enable CONFIG_DM_74X164 to use this driver.
> 4. Follow Documentation/devicetree/bindings/gpio/gpio-74x164.txt to add device
>    nodes
> 5. Tested on i.MX6 UltraLite with 74LV595 using gpio command and oscillograph.
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> V4:
>  Add Simon's review tag.
>
> V3:
>  Use dm_spi_claim_bus and dm_spi_xfer and dm_spi_release_bus
>  Drop spi_slave from struct gen_74x164_priv.
>
> V2:
>  Address Simon's comments:
>  Drop unused dev entry of gen_74x164_priv
>  Rename gen_74x164_info to gen_74x164_priv
>  Change u8 to uint
>  Change EINVAL to ENOSYS
>  Drop dm_gpio_set_value when probe, since GPIOD_IS_OUT_ACTIVE already
>  active the gpio.
>  Drop complicated spi_get_bus_and_cs, use dev_get_parent_priv.
>  To Kconfig help msg, I add 74lv165 and 75hc595, actually, the linux
>  one does not contain manufacture info.
>
>  drivers/gpio/74x164_gpio.c | 193 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/gpio/Kconfig       |   8 ++
>  drivers/gpio/Makefile      |   1 +
>  3 files changed, 202 insertions(+)
>  create mode 100644 drivers/gpio/74x164_gpio.c

Applied to u-boot-dm, thanks!

      reply	other threads:[~2016-05-07 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  2:02 [U-Boot] [PATCH V4 1/4] dm: spi: soft_spi bug fix Peng Fan
2016-05-03  2:02 ` [U-Boot] [PATCH V4 2/4] dm: spi: soft_spi: switch to use linux compatible string Peng Fan
2016-05-07 19:03   ` Simon Glass
2016-05-03  2:02 ` [U-Boot] [PATCH V4 3/4] dm: spi: introduce dm api Peng Fan
2016-05-07 15:11   ` Simon Glass
2016-05-07 19:03     ` Simon Glass
2016-05-03  2:02 ` [U-Boot] [PATCH V4 4/4] dm: gpio: introduce 74x164 driver Peng Fan
2016-05-07 19:03   ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ3pQPqsj0VGvOnYtmdD63NfkXhwiDOGvVy80U68HP9xuA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.