[U-Boot] x86 FSP 2

[U-Boot] x86 FSP 2

[Simon Glass]

Hi Bin,

I'm looking at Apollo Lake and it seems to use a newer FSP version
(2.0). The API differences seem to be fairly minor but the packaging
seems a little more complicated.

I'm thinking of introducing a Kconfig for this and moving the existing
fsp implementation into an arch/x86/lib/fsp1 directory and adding an
fsp2 there also. What do you think? Have you done anything with this
newer version?

Regards,
Simon

[U-Boot] x86 FSP 2

[Bin Meng]

Hi Simon,

On Thu, May 23, 2019 at 8:20 PM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Bin,
>
> I'm looking at Apollo Lake and it seems to use a newer FSP version
> (2.0). The API differences seem to be fairly minor but the packaging
> seems a little more complicated.
>

I have investigated FSP 2.0 architecture before, and IIRC your
understanding is correct. Unfortunately I did not get a chance to
support one of the Apollo Lake CRB.

> I'm thinking of introducing a Kconfig for this and moving the existing
> fsp implementation into an arch/x86/lib/fsp1 directory and adding an
> fsp2 there also. What do you think? Have you done anything with this
> newer version?
>

Sounds good to me. I have a Oxbow Hill CRB here. If it is the same
board you want to support, I can help testing.

Regards,
Bin

[U-Boot] x86 FSP 2

[Simon Glass]

Hi Bin,

On Thu, 23 May 2019 at 08:04, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Thu, May 23, 2019 at 8:20 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Bin,
> >
> > I'm looking at Apollo Lake and it seems to use a newer FSP version
> > (2.0). The API differences seem to be fairly minor but the packaging
> > seems a little more complicated.
> >
>
> I have investigated FSP 2.0 architecture before, and IIRC your
> understanding is correct. Unfortunately I did not get a chance to
> support one of the Apollo Lake CRB.
>
> > I'm thinking of introducing a Kconfig for this and moving the existing
> > fsp implementation into an arch/x86/lib/fsp1 directory and adding an
> > fsp2 there also. What do you think? Have you done anything with this
> > newer version?
> >
>
> Sounds good to me. I have a Oxbow Hill CRB here. If it is the same
> board you want to support, I can help testing.

I'm going to support coral I think, a Chromebook.

You may have seen the binman support for IFWI, etc. I have some
patches to move the FSP code around (u-boot-dm/coral-working). So far
it only boots into TPL. I'm aiming to have some patches for it to boot
to a prompt sometime in late August.

Regards,
Simon

[U-Boot] x86 FSP 2

[Bin Meng]

Hi Simon,

On Wed, Jul 31, 2019 at 10:55 AM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Bin,
>
> On Thu, 23 May 2019 at 08:04, Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Thu, May 23, 2019 at 8:20 PM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > Hi Bin,
> > >
> > > I'm looking at Apollo Lake and it seems to use a newer FSP version
> > > (2.0). The API differences seem to be fairly minor but the packaging
> > > seems a little more complicated.
> > >
> >
> > I have investigated FSP 2.0 architecture before, and IIRC your
> > understanding is correct. Unfortunately I did not get a chance to
> > support one of the Apollo Lake CRB.
> >
> > > I'm thinking of introducing a Kconfig for this and moving the existing
> > > fsp implementation into an arch/x86/lib/fsp1 directory and adding an
> > > fsp2 there also. What do you think? Have you done anything with this
> > > newer version?
> > >
> >
> > Sounds good to me. I have a Oxbow Hill CRB here. If it is the same
> > board you want to support, I can help testing.
>
> I'm going to support coral I think, a Chromebook.
>

That's good to know.

> You may have seen the binman support for IFWI, etc. I have some

Yes, I saw the binman patch series. Sorry I did not have enough time
to look at that series.

> patches to move the FSP code around (u-boot-dm/coral-working). So far
> it only boots into TPL. I'm aiming to have some patches for it to boot
> to a prompt sometime in late August.

Great!

Regards,
Bin

[U-Boot] x86 FSP 2

[Simon Glass]

Hi Bin,

On Tue, 30 Jul 2019 at 21:03, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Wed, Jul 31, 2019 at 10:55 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Bin,
> >
> > On Thu, 23 May 2019 at 08:04, Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > Hi Simon,
> > >
> > > On Thu, May 23, 2019 at 8:20 PM Simon Glass <sjg@chromium.org> wrote:
> > > >
> > > > Hi Bin,
> > > >
> > > > I'm looking at Apollo Lake and it seems to use a newer FSP version
> > > > (2.0). The API differences seem to be fairly minor but the packaging
> > > > seems a little more complicated.
> > > >
> > >
> > > I have investigated FSP 2.0 architecture before, and IIRC your
> > > understanding is correct. Unfortunately I did not get a chance to
> > > support one of the Apollo Lake CRB.
> > >
> > > > I'm thinking of introducing a Kconfig for this and moving the existing
> > > > fsp implementation into an arch/x86/lib/fsp1 directory and adding an
> > > > fsp2 there also. What do you think? Have you done anything with this
> > > > newer version?
> > > >
> > >
> > > Sounds good to me. I have a Oxbow Hill CRB here. If it is the same
> > > board you want to support, I can help testing.
> >
> > I'm going to support coral I think, a Chromebook.
> >
>
> That's good to know.
>
> > You may have seen the binman support for IFWI, etc. I have some
>
> Yes, I saw the binman patch series. Sorry I did not have enough time
> to look at that series.
>
> > patches to move the FSP code around (u-boot-dm/coral-working). So far
> > it only boots into TPL. I'm aiming to have some patches for it to boot
> > to a prompt sometime in late August.
>
> Great!

I have this booting to a prompt but I need to create patches. Still
hoping for late August.

Regards,
Simon