* [PATCH] serial-uclass: fix build warning
@ 2022-02-02 12:55 Heiko Schocher
2022-02-04 15:24 ` Simon Glass
2022-02-08 20:39 ` Simon Glass
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Schocher @ 2022-02-02 12:55 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Heiko Schocher, Andy Shevchenko, Patrice Chotard,
Patrick Delaunay, Simon Glass
if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not,
gcc drops warnings for serial_stub_* functions
that they are defined but not used.
Fix it.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
azure build is clean
https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
drivers/serial/serial-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 96a1cb65ba..362cedd955 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -357,7 +357,6 @@ static void serial_stub_putc(struct stdio_dev *sdev, const char ch)
{
_serial_putc(sdev->priv, ch);
}
-#endif
static void serial_stub_puts(struct stdio_dev *sdev, const char *str)
{
@@ -374,6 +373,7 @@ static int serial_stub_tstc(struct stdio_dev *sdev)
return _serial_tstc(sdev->priv);
}
#endif
+#endif
/**
* on_baudrate() - Update the actual baudrate when the env var changes
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial-uclass: fix build warning
2022-02-02 12:55 [PATCH] serial-uclass: fix build warning Heiko Schocher
@ 2022-02-04 15:24 ` Simon Glass
2022-02-08 20:39 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-02-04 15:24 UTC (permalink / raw)
To: Heiko Schocher
Cc: U-Boot Mailing List, Andy Shevchenko, Patrice Chotard, Patrick Delaunay
On Wed, 2 Feb 2022 at 05:55, Heiko Schocher <hs@denx.de> wrote:
>
> if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not,
> gcc drops warnings for serial_stub_* functions
> that they are defined but not used.
>
> Fix it.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> azure build is clean
> https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
>
> drivers/serial/serial-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial-uclass: fix build warning
2022-02-02 12:55 [PATCH] serial-uclass: fix build warning Heiko Schocher
2022-02-04 15:24 ` Simon Glass
@ 2022-02-08 20:39 ` Simon Glass
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-02-08 20:39 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, Heiko Schocher, Andy Shevchenko,
Patrice Chotard, Patrick Delaunay
On Wed, 2 Feb 2022 at 05:55, Heiko Schocher <hs@denx.de> wrote:
>
> if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not,
> gcc drops warnings for serial_stub_* functions
> that they are defined but not used.
>
> Fix it.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> azure build is clean
> https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
>
> drivers/serial/serial-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-08 20:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 12:55 [PATCH] serial-uclass: fix build warning Heiko Schocher
2022-02-04 15:24 ` Simon Glass
2022-02-08 20:39 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.