[PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[peter.griffin]

Hi Jon,

This patch series adds the OP-TEE recipes from meta-linaro
layer to the meta-arm layer which is the new home for generic
Arm architecture components.

Once these are merged, I will remove them and add a README
in meta-linaro.

Thanks,

Peter.

Peter Griffin (5):
  optee-client.bb: add optee client recipe and patches
  optee-os_git.bb: add optee-os recipe and patches
  optee-examples.bb: add recipe for optee examples
  optee-test_git.bb: add optee-test recipe & patches
  optee-test_git.bb: add python3 backport patch

 meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
 .../optee/optee-client/tee-supplicant.service      | 10 ++++
 meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
 ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
 meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
 .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
 meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
 7 files changed, 267 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
 create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
 create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
 create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
 create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
 create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
 create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb

-- 
2.7.4

[PATCH 1/5] optee-client.bb: add optee client recipe and patches

[Peter Griffin]

This has moved from meta-linaro to meta-arm as this
is the new place for general recipes for Arm arch
and has a mailing list for external contributors.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 meta-arm/recipes-security/optee/optee-client.bb    | 35 ++++++++++++++++++++++
 .../optee/optee-client/tee-supplicant.service      | 10 +++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
 create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service

diff --git a/meta-arm/recipes-security/optee/optee-client.bb b/meta-arm/recipes-security/optee/optee-client.bb
new file mode 100644
index 0000000..519683a
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-client.bb
@@ -0,0 +1,35 @@
+SUMMARY = "OPTEE Client"
+HOMEPAGE = "https://github.com/OP-TEE/optee_client"
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=69663ab153298557a59c67a60a743e5b"
+
+PV = "3.7.0+git${SRCPV}"
+
+inherit python3native systemd
+
+SRC_URI = "git://github.com/OP-TEE/optee_client.git \
+           file://tee-supplicant.service"
+S = "${WORKDIR}/git"
+
+SRCREV = "bc0ec8ce1e4dc5ae23f4737ef659338b7cd408fe"
+
+SYSTEMD_SERVICE_${PN} = "tee-supplicant.service"
+
+do_install() {
+    oe_runmake install
+
+    install -D -p -m0755 ${S}/out/export/usr/sbin/tee-supplicant ${D}${sbindir}/tee-supplicant
+
+    install -D -p -m0644 ${S}/out/export/usr/lib/libteec.so.1.0 ${D}${libdir}/libteec.so.1.0
+    ln -sf libteec.so.1.0 ${D}${libdir}/libteec.so
+    ln -sf libteec.so.1.0 ${D}${libdir}/libteec.so.1
+
+    cp -a ${S}/out/export/usr/include ${D}/usr/
+
+    sed -i -e s:/etc:${sysconfdir}:g \
+           -e s:/usr/bin:${bindir}:g \
+              ${WORKDIR}/tee-supplicant.service
+
+    install -D -p -m0644 ${WORKDIR}/tee-supplicant.service ${D}${systemd_system_unitdir}/tee-supplicant.service
+}
diff --git a/meta-arm/recipes-security/optee/optee-client/tee-supplicant.service b/meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
new file mode 100644
index 0000000..ffb54d3
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
@@ -0,0 +1,10 @@
+[Unit]
+Description=TEE Supplicant
+
+[Service]
+User=root
+EnvironmentFile=-/etc/default/tee-supplicant
+ExecStart=/usr/sbin/tee-supplicant $OPTARGS
+
+[Install]
+WantedBy=basic.target
-- 
2.7.4

[PATCH 2/5] optee-os_git.bb: add optee-os recipe and patches

[Peter Griffin]

This has moved from meta-linaro to meta-arm as this
is the new place for general recipes for Arm arch
and has a mailing list for external contributors.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
 meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
 2 files changed, 82 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
 create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb

diff --git a/meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch b/meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
new file mode 100644
index 0000000..17127d0
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
@@ -0,0 +1,13 @@
+diff --git a/mk/gcc.mk b/mk/gcc.mk
+index fc38c4d..77b8d74 100644
+--- a/mk/gcc.mk
++++ b/mk/gcc.mk
+@@ -12,7 +12,7 @@ nostdinc$(sm)	:= -nostdinc -isystem $(shell $(CC$(sm)) \
+ 			-print-file-name=include 2> /dev/null)
+ 
+ # Get location of libgcc from gcc
+-libgcc$(sm)  	:= $(shell $(CC$(sm)) $(CFLAGS$(arch-bits-$(sm))) $(comp-cflags$(sm)) \
++libgcc$(sm)  	:= $(shell $(CC$(sm)) $(LIBGCC_LOCATE_CFLAGS) $(CFLAGS$(arch-bits-$(sm))) $(comp-cflags$(sm)) \
+ 			-print-libgcc-file-name 2> /dev/null)
+ 
+ # Define these to something to discover accidental use
diff --git a/meta-arm/recipes-security/optee/optee-os_git.bb b/meta-arm/recipes-security/optee/optee-os_git.bb
new file mode 100644
index 0000000..872fd48
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-os_git.bb
@@ -0,0 +1,69 @@
+SUMMARY = "OP-TEE Trusted OS"
+DESCRIPTION = "OPTEE OS"
+
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=c1f21c4f72f372ef38a5a4aee55ec173"
+
+PV="3.7.0+git${SRCPV}"
+
+inherit deploy python3native
+
+DEPENDS = "python3-pycrypto-native python3-pyelftools-native"
+
+SRCREV = "a2fa5018cb595a9cd9ab62e82c7485ca57a62084"
+SRC_URI = "git://github.com/OP-TEE/optee_os.git \
+           file://0001-allow-setting-sysroot-for-libgcc-lookup.patch \
+          "
+
+S = "${WORKDIR}/git"
+
+OPTEEMACHINE ?= "${MACHINE}"
+OPTEEOUTPUTMACHINE ?= "${MACHINE}"
+
+EXTRA_OEMAKE = "PLATFORM=${OPTEEMACHINE} CFG_ARM64_core=y \
+                CROSS_COMPILE_core=${HOST_PREFIX} \
+                CROSS_COMPILE_ta_arm64=${HOST_PREFIX} \
+                NOWERROR=1 \
+                ta-targets=ta_arm64 \
+                LDFLAGS= \
+                LIBGCC_LOCATE_CFLAGS=--sysroot=${STAGING_DIR_HOST} \
+        "
+
+OPTEE_ARCH_armv7a = "arm32"
+OPTEE_ARCH_aarch64 = "arm64"
+
+do_compile() {
+    unset LDFLAGS
+    oe_runmake all CFG_TEE_TA_LOG_LEVEL=0
+}
+
+do_install() {
+    #install core on boot directory
+    install -d ${D}${nonarch_base_libdir}/firmware/
+
+    install -m 644 ${B}/out/arm-plat-${OPTEEOUTPUTMACHINE}/core/*.bin ${D}${nonarch_base_libdir}/firmware/
+    #install TA devkit
+    install -d ${D}/usr/include/optee/export-user_ta/
+
+    for f in  ${B}/out/arm-plat-${OPTEEOUTPUTMACHINE}/export-ta_${OPTEE_ARCH}/* ; do
+        cp -aR  $f  ${D}/usr/include/optee/export-user_ta/
+    done
+}
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+do_deploy() {
+    install -d ${DEPLOYDIR}/optee
+    for f in ${D}${nonarch_base_libdir}/firmware/*; do
+        install -m 644 $f ${DEPLOYDIR}/optee/
+    done
+}
+
+addtask deploy before do_build after do_install
+
+FILES_${PN} = "${nonarch_base_libdir}/firmware/"
+FILES_${PN}-dev = "/usr/include/optee"
+
+INSANE_SKIP_${PN}-dev = "staticdev"
+
+INHIBIT_PACKAGE_STRIP = "1"
-- 
2.7.4

[PATCH 3/5] optee-examples.bb: add recipe for optee examples

[Peter Griffin]

This has moved from meta-linaro to meta-arm as this
is the new place for general recipes for Arm arch
and has a mailing list for external contributors.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 meta-arm/recipes-security/optee/optee-examples.bb | 42 +++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb

diff --git a/meta-arm/recipes-security/optee/optee-examples.bb b/meta-arm/recipes-security/optee/optee-examples.bb
new file mode 100644
index 0000000..aaec4c4
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-examples.bb
@@ -0,0 +1,42 @@
+SUMMARY = "OP-TEE examples"
+HOMEPAGE = "https://github.com/linaro-swg/optee_examples"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=cd95ab417e23b94f381dafc453d70c30"
+
+DEPENDS = "optee-client optee-os python-pycrypto-native"
+
+inherit python3native
+
+SRC_URI = "git://github.com/linaro-swg/optee_examples.git"
+SRCREV = "559b2141c16bf0f57ccd72f60e4deb84fc2a05b0"
+
+S = "${WORKDIR}/git"
+
+OPTEE_CLIENT_EXPORT = "${STAGING_DIR_HOST}${prefix}"
+TEEC_EXPORT = "${STAGING_DIR_HOST}${prefix}"
+TA_DEV_KIT_DIR = "${STAGING_INCDIR}/optee/export-user_ta"
+
+EXTRA_OEMAKE = " TA_DEV_KIT_DIR=${TA_DEV_KIT_DIR} \
+                 OPTEE_CLIENT_EXPORT=${OPTEE_CLIENT_EXPORT} \
+                 TEEC_EXPORT=${TEEC_EXPORT} \
+                 HOST_CROSS_COMPILE=${TARGET_PREFIX} \
+                 TA_CROSS_COMPILE=${TARGET_PREFIX} \
+                 V=1 \
+               "
+
+do_compile() {
+    oe_runmake
+}
+
+do_install () {
+    mkdir -p ${D}${nonarch_base_libdir}/optee_armtz
+    mkdir -p ${D}${bindir}
+    install -D -p -m0755 ${S}/out/ca/* ${D}${bindir}
+    install -D -p -m0444 ${S}/out/ta/* ${D}${nonarch_base_libdir}/optee_armtz
+}
+
+FILES_${PN} += "${nonarch_base_libdir}/optee_armtz/"
+
+# Imports machine specific configs from staging to build
+PACKAGE_ARCH = "${MACHINE_ARCH}"
-- 
2.7.4

[PATCH 4/5] optee-test_git.bb: add optee-test recipe & patches

[Peter Griffin]

This has moved from meta-linaro to meta-arm as this
is the new place for general recipes for Arm arch
and has a mailing list for external contributors.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++++++++
 meta-arm/recipes-security/optee/optee-test_git.bb  | 49 ++++++++++++++++++++++
 2 files changed, 97 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
 create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb

diff --git a/meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch b/meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
new file mode 100644
index 0000000..20f190a
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
@@ -0,0 +1,48 @@
+From 6271160639002a2580d80b75b5397a96d56329f2 Mon Sep 17 00:00:00 2001
+From: Scott Branden <scott.branden@broadcom.com>
+Date: Fri, 27 Dec 2019 12:54:28 -0800
+Subject: [PATCH] use python3 instead of python
+
+use python3 instead of python as python2 is EOL January 2020.
+
+Signed-off-by: Scott Branden <scott.branden@broadcom.com>
+Reviewed-by: Jerome Forissier <jerome@forissier.org>
+Tested-by: Jerome Forissier <jerome@forissier.org> (QEMU, CFG_GCM_NIST_VECTORS=y)
+Upstream-Status: Backport from v3.8.0
+---
+ scripts/file_to_c.py       | 4 ++--
+ scripts/rsp_to_gcm_test.py | 2 +-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/scripts/file_to_c.py b/scripts/file_to_c.py
+index ae16f52..b4ce2a2 100755
+--- a/scripts/file_to_c.py
++++ b/scripts/file_to_c.py
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env python
++#!/usr/bin/env python3
+ # SPDX-License-Identifier: BSD-2-Clause
+ #
+ # Copyright (c) 2018, Linaro Limited
+@@ -29,7 +29,7 @@ def main():
+ 
+     f.write("const uint8_t " + args.name + "[] = {\n")
+     i = 0
+-    for x in array.array("B", inf.read()):
++    for x in array.array("B", map(ord, (inf.read()))):
+         f.write("0x" + '{0:02x}'.format(x) + ",")
+         i = i + 1
+         if i % 8 == 0:
+diff --git a/scripts/rsp_to_gcm_test.py b/scripts/rsp_to_gcm_test.py
+index 0543541..e4418be 100755
+--- a/scripts/rsp_to_gcm_test.py
++++ b/scripts/rsp_to_gcm_test.py
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env python
++#!/usr/bin/env python3
+ 
+ modes = {'encrypt': 0, 'decrypt': 1}
+ 
+-- 
+2.7.4
+
diff --git a/meta-arm/recipes-security/optee/optee-test_git.bb b/meta-arm/recipes-security/optee/optee-test_git.bb
new file mode 100644
index 0000000..a6fae9d
--- /dev/null
+++ b/meta-arm/recipes-security/optee/optee-test_git.bb
@@ -0,0 +1,49 @@
+SUMMARY = "OP-TEE sanity testsuite"
+HOMEPAGE = "https://github.com/OP-TEE/optee_test"
+
+LICENSE = "BSD & GPLv2"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE.md;md5=daa2bcccc666345ab8940aab1315a4fa"
+
+inherit python3native
+
+DEPENDS = "optee-client optee-os python3-pycrypto-native"
+
+PV = "3.7.0+git${SRCPV}"
+
+SRC_URI = "git://github.com/OP-TEE/optee_test.git \
+          "
+S = "${WORKDIR}/git"
+
+SRCREV = "227d6f4c40eaa6f84fe049b9e48c7b27ad7fab08"
+
+OPTEE_CLIENT_EXPORT = "${STAGING_DIR_HOST}${prefix}"
+TEEC_EXPORT         = "${STAGING_DIR_HOST}${prefix}"
+TA_DEV_KIT_DIR      = "${STAGING_INCDIR}/optee/export-user_ta"
+
+EXTRA_OEMAKE = " TA_DEV_KIT_DIR=${TA_DEV_KIT_DIR} \
+                 OPTEE_CLIENT_EXPORT=${OPTEE_CLIENT_EXPORT} \
+                 TEEC_EXPORT=${TEEC_EXPORT} \
+                 CROSS_COMPILE_HOST=${TARGET_PREFIX} \
+                 CROSS_COMPILE_TA=${TARGET_PREFIX} \
+                 V=1 \
+               "
+
+do_compile() {
+    # Top level makefile doesn't seem to handle parallel make gracefully
+    oe_runmake xtest
+    oe_runmake ta
+}
+
+do_install () {
+    install -D -p -m0755 ${S}/out/xtest/xtest ${D}${bindir}/xtest
+
+    # install path should match the value set in optee-client/tee-supplicant
+    # default TEEC_LOAD_PATH is /lib
+    mkdir -p ${D}${nonarch_base_libdir}/optee_armtz/
+    install -D -p -m0444 ${S}/out/ta/*/*.ta ${D}${nonarch_base_libdir}/optee_armtz/
+}
+
+FILES_${PN} += "${nonarch_base_libdir}/optee_armtz/"
+
+# Imports machine specific configs from staging to build
+PACKAGE_ARCH = "${MACHINE_ARCH}"
-- 
2.7.4

[PATCH 5/5] optee-test_git.bb: add python3 backport patch

[Peter Griffin]

python2 is now EOL. This patch updates to python3
but is a backport from v3.8.0 release.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 meta-arm/recipes-security/optee/optee-test_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arm/recipes-security/optee/optee-test_git.bb b/meta-arm/recipes-security/optee/optee-test_git.bb
index a6fae9d..3f431c3 100644
--- a/meta-arm/recipes-security/optee/optee-test_git.bb
+++ b/meta-arm/recipes-security/optee/optee-test_git.bb
@@ -11,6 +11,7 @@ DEPENDS = "optee-client optee-os python3-pycrypto-native"
 PV = "3.7.0+git${SRCPV}"
 
 SRC_URI = "git://github.com/OP-TEE/optee_test.git \
+          file://0001-use-python3-instead-of-python.patch \
           "
 S = "${WORKDIR}/git"
 
-- 
2.7.4

Re: [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Denys Dmytriyenko]

Thanks! And for the entire series:

Tested-by: Denys Dmytriyenko <denys@ti.com>

The only nitpick is that 0001-use-python3-instead-of-python.patch gets 
created in patch #4, but is added to the recipe in patch #5 - should have 
been all in one patch.

-- 
Denys


On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
> Hi Jon,
> 
> This patch series adds the OP-TEE recipes from meta-linaro
> layer to the meta-arm layer which is the new home for generic
> Arm architecture components.
> 
> Once these are merged, I will remove them and add a README
> in meta-linaro.
> 
> Thanks,
> 
> Peter.
> 
> Peter Griffin (5):
>   optee-client.bb: add optee client recipe and patches
>   optee-os_git.bb: add optee-os recipe and patches
>   optee-examples.bb: add recipe for optee examples
>   optee-test_git.bb: add optee-test recipe & patches
>   optee-test_git.bb: add python3 backport patch
> 
>  meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
>  .../optee/optee-client/tee-supplicant.service      | 10 ++++
>  meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
>  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
>  meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
>  .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
>  meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
>  7 files changed, 267 insertions(+)
>  create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
>  create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
>  create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
>  create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
>  create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
>  create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
>  create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb
> 
> -- 
> 2.7.4
> 

Re: [meta-arm] [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Jon Mason]

On Thu, Jan 30, 2020 at 6:47 AM Denys Dmytriyenko <denis@denix.org> wrote:
>
> Thanks! And for the entire series:
>
> Tested-by: Denys Dmytriyenko <denys@ti.com>
>
> The only nitpick is that 0001-use-python3-instead-of-python.patch gets
> created in patch #4, but is added to the recipe in patch #5 - should have
> been all in one patch.

I was thinking the same thing.  I can easily squash all of this into
one patch via git when I merge, if so desired.

Thanks,
Jon

>
> --
> Denys
>
>
> On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
> > Hi Jon,
> >
> > This patch series adds the OP-TEE recipes from meta-linaro
> > layer to the meta-arm layer which is the new home for generic
> > Arm architecture components.
> >
> > Once these are merged, I will remove them and add a README
> > in meta-linaro.
> >
> > Thanks,
> >
> > Peter.
> >
> > Peter Griffin (5):
> >   optee-client.bb: add optee client recipe and patches
> >   optee-os_git.bb: add optee-os recipe and patches
> >   optee-examples.bb: add recipe for optee examples
> >   optee-test_git.bb: add optee-test recipe & patches
> >   optee-test_git.bb: add python3 backport patch
> >
> >  meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
> >  .../optee/optee-client/tee-supplicant.service      | 10 ++++
> >  meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
> >  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
> >  meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
> >  .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
> >  meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
> >  7 files changed, 267 insertions(+)
> >  create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
> >  create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
> >  create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
> >  create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
> >  create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
> >  create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
> >  create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb
> >
> > --
> > 2.7.4
> >
> 

Re: [meta-arm] [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Denys Dmytriyenko]

On Fri, Jan 31, 2020 at 07:54:08AM +0100, Jon Mason wrote:
> On Thu, Jan 30, 2020 at 6:47 AM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > Thanks! And for the entire series:
> >
> > Tested-by: Denys Dmytriyenko <denys@ti.com>
> >
> > The only nitpick is that 0001-use-python3-instead-of-python.patch gets
> > created in patch #4, but is added to the recipe in patch #5 - should have
> > been all in one patch.
> 
> I was thinking the same thing.  I can easily squash all of this into
> one patch via git when I merge, if so desired.

I'm fine with squashing few patches, if you want to. Do you want to squash 4 
and 5 only, or all 5 of them into 1?

Denys


> Thanks,
> Jon
> 
> >
> > --
> > Denys
> >
> >
> > On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
> > > Hi Jon,
> > >
> > > This patch series adds the OP-TEE recipes from meta-linaro
> > > layer to the meta-arm layer which is the new home for generic
> > > Arm architecture components.
> > >
> > > Once these are merged, I will remove them and add a README
> > > in meta-linaro.
> > >
> > > Thanks,
> > >
> > > Peter.
> > >
> > > Peter Griffin (5):
> > >   optee-client.bb: add optee client recipe and patches
> > >   optee-os_git.bb: add optee-os recipe and patches
> > >   optee-examples.bb: add recipe for optee examples
> > >   optee-test_git.bb: add optee-test recipe & patches
> > >   optee-test_git.bb: add python3 backport patch
> > >
> > >  meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
> > >  .../optee/optee-client/tee-supplicant.service      | 10 ++++
> > >  meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
> > >  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
> > >  meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
> > >  .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
> > >  meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
> > >  7 files changed, 267 insertions(+)
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
> > >  create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb
> > >
> > > --
> > > 2.7.4
> > >
> > 

> 

Re: [meta-arm] [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Jon Mason]

On Sat, Feb 1, 2020 at 12:57 AM Denys Dmytriyenko <denis@denix.org> wrote:
>
> On Fri, Jan 31, 2020 at 07:54:08AM +0100, Jon Mason wrote:
> > On Thu, Jan 30, 2020 at 6:47 AM Denys Dmytriyenko <denis@denix.org> wrote:
> > >
> > > Thanks! And for the entire series:
> > >
> > > Tested-by: Denys Dmytriyenko <denys@ti.com>
> > >
> > > The only nitpick is that 0001-use-python3-instead-of-python.patch gets
> > > created in patch #4, but is added to the recipe in patch #5 - should have
> > > been all in one patch.
> >
> > I was thinking the same thing.  I can easily squash all of this into
> > one patch via git when I merge, if so desired.
>
> I'm fine with squashing few patches, if you want to. Do you want to squash 4
> and 5 only, or all 5 of them into 1?

I was meaning all 5 into 1, but 4 & 5 only can be done if that's preferred.

Thanks,
Jon

>
> Denys
>
>
> > Thanks,
> > Jon
> >
> > >
> > > --
> > > Denys
> > >
> > >
> > > On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
> > > > Hi Jon,
> > > >
> > > > This patch series adds the OP-TEE recipes from meta-linaro
> > > > layer to the meta-arm layer which is the new home for generic
> > > > Arm architecture components.
> > > >
> > > > Once these are merged, I will remove them and add a README
> > > > in meta-linaro.
> > > >
> > > > Thanks,
> > > >
> > > > Peter.
> > > >
> > > > Peter Griffin (5):
> > > >   optee-client.bb: add optee client recipe and patches
> > > >   optee-os_git.bb: add optee-os recipe and patches
> > > >   optee-examples.bb: add recipe for optee examples
> > > >   optee-test_git.bb: add optee-test recipe & patches
> > > >   optee-test_git.bb: add python3 backport patch
> > > >
> > > >  meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
> > > >  .../optee/optee-client/tee-supplicant.service      | 10 ++++
> > > >  meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
> > > >  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
> > > >  meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
> > > >  .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
> > > >  meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
> > > >  7 files changed, 267 insertions(+)
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
> > > >  create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb
> > > >
> > > > --
> > > > 2.7.4
> > > >
> > >
>
> >
>
> 

Re: [meta-arm] [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Peter Griffin]

[-- Attachment #1: Type: text/plain, Size: 3463 bytes --]

Hi Jon,

On Sat, 1 Feb 2020 at 15:25, Jon Mason <jdmason@kudzu.us> wrote:

> On Sat, Feb 1, 2020 at 12:57 AM Denys Dmytriyenko <denis@denix.org> wrote:
> >
> > On Fri, Jan 31, 2020 at 07:54:08AM +0100, Jon Mason wrote:
> > > On Thu, Jan 30, 2020 at 6:47 AM Denys Dmytriyenko <denis@denix.org>
> wrote:
> > > >
> > > > Thanks! And for the entire series:
> > > >
> > > > Tested-by: Denys Dmytriyenko <denys@ti.com>
> > > >
> > > > The only nitpick is that 0001-use-python3-instead-of-python.patch
> gets
> > > > created in patch #4, but is added to the recipe in patch #5 - should
> have
> > > > been all in one patch.
> > >
> > > I was thinking the same thing.  I can easily squash all of this into
> > > one patch via git when I merge, if so desired.
> >
> > I'm fine with squashing few patches, if you want to. Do you want to
> squash 4
> > and 5 only, or all 5 of them into 1?
>
> I was meaning all 5 into 1, but 4 & 5 only can be done if that's preferred.
>

Squashing 4 & 5 together makes sense and would be my preference I think
over 1 giant patch.

Thanks,

Peter.

>
> Thanks,
> Jon
>
> >
> > Denys
> >
> >
> > > Thanks,
> > > Jon
> > >
> > > >
> > > > --
> > > > Denys
> > > >
> > > >
> > > > On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
> > > > > Hi Jon,
> > > > >
> > > > > This patch series adds the OP-TEE recipes from meta-linaro
> > > > > layer to the meta-arm layer which is the new home for generic
> > > > > Arm architecture components.
> > > > >
> > > > > Once these are merged, I will remove them and add a README
> > > > > in meta-linaro.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Peter.
> > > > >
> > > > > Peter Griffin (5):
> > > > >   optee-client.bb: add optee client recipe and patches
> > > > >   optee-os_git.bb: add optee-os recipe and patches
> > > > >   optee-examples.bb: add recipe for optee examples
> > > > >   optee-test_git.bb: add optee-test recipe & patches
> > > > >   optee-test_git.bb: add python3 backport patch
> > > > >
> > > > >  meta-arm/recipes-security/optee/optee-client.bb    | 35
> +++++++++++
> > > > >  .../optee/optee-client/tee-supplicant.service      | 10 ++++
> > > > >  meta-arm/recipes-security/optee/optee-examples.bb  | 42
> +++++++++++++
> > > > >  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
> > > > >  meta-arm/recipes-security/optee/optee-os_git.bb    | 69
> ++++++++++++++++++++++
> > > > >  .../0001-use-python3-instead-of-python.patch       | 48
> +++++++++++++++
> > > > >  meta-arm/recipes-security/optee/optee-test_git.bb  | 50
> ++++++++++++++++
> > > > >  7 files changed, 267 insertions(+)
> > > > >  create mode 100644 meta-arm/recipes-security/optee/
> optee-client.bb
> > > > >  create mode 100644
> meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
> > > > >  create mode 100644 meta-arm/recipes-security/optee/
> optee-examples.bb
> > > > >  create mode 100644
> meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
> > > > >  create mode 100644 meta-arm/recipes-security/optee/
> optee-os_git.bb
> > > > >  create mode 100644
> meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
> > > > >  create mode 100644 meta-arm/recipes-security/optee/
> optee-test_git.bb
> > > > >
> > > > > --
> > > > > 2.7.4
> > > > >
> > > >
> >
> > >
> >
> > 
>

[-- Attachment #2: Type: text/html, Size: 5904 bytes --]

Re: [meta-arm] [PATCH 0/5] Add OP-TEE recipes to meta-arm layer

[Jon Mason]

On Sun, Feb 2, 2020 at 7:46 PM Peter Griffin <peter.griffin@linaro.org> wrote:
>
> Hi Jon,
>
> On Sat, 1 Feb 2020 at 15:25, Jon Mason <jdmason@kudzu.us> wrote:
>>
>> On Sat, Feb 1, 2020 at 12:57 AM Denys Dmytriyenko <denis@denix.org> wrote:
>> >
>> > On Fri, Jan 31, 2020 at 07:54:08AM +0100, Jon Mason wrote:
>> > > On Thu, Jan 30, 2020 at 6:47 AM Denys Dmytriyenko <denis@denix.org> wrote:
>> > > >
>> > > > Thanks! And for the entire series:
>> > > >
>> > > > Tested-by: Denys Dmytriyenko <denys@ti.com>
>> > > >
>> > > > The only nitpick is that 0001-use-python3-instead-of-python.patch gets
>> > > > created in patch #4, but is added to the recipe in patch #5 - should have
>> > > > been all in one patch.
>> > >
>> > > I was thinking the same thing.  I can easily squash all of this into
>> > > one patch via git when I merge, if so desired.
>> >
>> > I'm fine with squashing few patches, if you want to. Do you want to squash 4
>> > and 5 only, or all 5 of them into 1?
>>
>> I was meaning all 5 into 1, but 4 & 5 only can be done if that's preferred.
>
>
> Squashing 4 & 5 together makes sense and would be my preference I think
> over 1 giant patch.

The patches were squashed and pushed to the master branch of meta-arm.
Thank you for doing this work.

Thanks,
Jon

> Thanks,
>
> Peter.
>>
>>
>> Thanks,
>> Jon
>>
>> >
>> > Denys
>> >
>> >
>> > > Thanks,
>> > > Jon
>> > >
>> > > >
>> > > > --
>> > > > Denys
>> > > >
>> > > >
>> > > > On Wed, Jan 29, 2020 at 05:38:40PM +0000, Peter Griffin wrote:
>> > > > > Hi Jon,
>> > > > >
>> > > > > This patch series adds the OP-TEE recipes from meta-linaro
>> > > > > layer to the meta-arm layer which is the new home for generic
>> > > > > Arm architecture components.
>> > > > >
>> > > > > Once these are merged, I will remove them and add a README
>> > > > > in meta-linaro.
>> > > > >
>> > > > > Thanks,
>> > > > >
>> > > > > Peter.
>> > > > >
>> > > > > Peter Griffin (5):
>> > > > >   optee-client.bb: add optee client recipe and patches
>> > > > >   optee-os_git.bb: add optee-os recipe and patches
>> > > > >   optee-examples.bb: add recipe for optee examples
>> > > > >   optee-test_git.bb: add optee-test recipe & patches
>> > > > >   optee-test_git.bb: add python3 backport patch
>> > > > >
>> > > > >  meta-arm/recipes-security/optee/optee-client.bb    | 35 +++++++++++
>> > > > >  .../optee/optee-client/tee-supplicant.service      | 10 ++++
>> > > > >  meta-arm/recipes-security/optee/optee-examples.bb  | 42 +++++++++++++
>> > > > >  ...1-allow-setting-sysroot-for-libgcc-lookup.patch | 13 ++++
>> > > > >  meta-arm/recipes-security/optee/optee-os_git.bb    | 69 ++++++++++++++++++++++
>> > > > >  .../0001-use-python3-instead-of-python.patch       | 48 +++++++++++++++
>> > > > >  meta-arm/recipes-security/optee/optee-test_git.bb  | 50 ++++++++++++++++
>> > > > >  7 files changed, 267 insertions(+)
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-client.bb
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-client/tee-supplicant.service
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-examples.bb
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-os/0001-allow-setting-sysroot-for-libgcc-lookup.patch
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-os_git.bb
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-test/0001-use-python3-instead-of-python.patch
>> > > > >  create mode 100644 meta-arm/recipes-security/optee/optee-test_git.bb
>> > > > >
>> > > > > --
>> > > > > 2.7.4
>> > > > >
>> > > >
>> >
>> > >
>> >
>> >