[PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[He Zhe]

systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
in this case, kvm_intel and kvm_amd. One of them must fail on a specific
board and causes the following failure.

This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.

systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
Failed to start Load Kernel Modules.

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
index 9905ed9..c09b07c 100644
--- a/recipes-kernel/linux/linux-yocto_virtualization.inc
+++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
@@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
 
 KERNEL_MODULE_AUTOLOAD += "openvswitch"
 KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
-KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
-KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
 
 # aufs kernel support required for xen-image-minimal
 KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
-- 
2.11.0

[PATCH] libvirt: Remove unsupported configure options and fix warning

[He Zhe]

xen and xen-inotify have been removed from upstream. We change
PACKAGECONFIG accordingly.

pkg_postinst has been deprecated, use pkg_postinst_ontarget instead.

WARNING: wrlinux-image-ovp-kvm-1.0-r0 do_rootfs: Intentionally failing
postinstall scriptlets of ['libvirt'] to defer them to first boot is
deprecated. Please place them into pkg_postinst_ontarget_${PN} ().

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 recipes-extended/libvirt/libvirt_4.3.0.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/recipes-extended/libvirt/libvirt_4.3.0.bb b/recipes-extended/libvirt/libvirt_4.3.0.bb
index edd5261..e6dac5d 100644
--- a/recipes-extended/libvirt/libvirt_4.3.0.bb
+++ b/recipes-extended/libvirt/libvirt_4.3.0.bb
@@ -175,7 +175,7 @@ PRIVATE_LIBS_${PN}-ptest = " \
 PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
                    remote macvtap libvirtd netcf udev python ebtables \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
-                   ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
+                   ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
                   "
 
@@ -183,10 +183,8 @@ PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
 #
 PACKAGECONFIG[qemu] = "--with-qemu,--without-qemu,qemu,"
 PACKAGECONFIG[yajl] = "--with-yajl,--without-yajl,yajl,yajl"
-PACKAGECONFIG[xen] = "--with-xen,--without-xen,xen,"
 PACKAGECONFIG[xenapi] = "--with-xenapi,--without-xenapi,,"
 PACKAGECONFIG[libxl] = "--with-libxl=${STAGING_DIR_TARGET}/lib,--without-libxl,libxl,"
-PACKAGECONFIG[xen-inotify] = "--with-xen-inotify,--without-xen-inotify,xen,"
 PACKAGECONFIG[uml] = "--with-uml, --without-uml,,"
 PACKAGECONFIG[openvz] = "--with-openvz,--without-openvz,,"
 PACKAGECONFIG[vmware] = "--with-vmware,--without-vmware,,"
@@ -305,7 +303,7 @@ do_install_ptest() {
 	done
 }
 
-pkg_postinst_libvirt() {
+pkg_postinst_ontarget_${PN}() {
         if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
                 /etc/init.d/populate-volatile.sh update
         fi
-- 
2.11.0

Re: [PATCH] libvirt: Remove unsupported configure options and fix warning

[He Zhe]

Please ignore.

Zhe

On 2018年07月24日 19:08, He Zhe wrote:
> xen and xen-inotify have been removed from upstream. We change
> PACKAGECONFIG accordingly.
>
> pkg_postinst has been deprecated, use pkg_postinst_ontarget instead.
>
> WARNING: wrlinux-image-ovp-kvm-1.0-r0 do_rootfs: Intentionally failing
> postinstall scriptlets of ['libvirt'] to defer them to first boot is
> deprecated. Please place them into pkg_postinst_ontarget_${PN} ().
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>  recipes-extended/libvirt/libvirt_4.3.0.bb | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-extended/libvirt/libvirt_4.3.0.bb b/recipes-extended/libvirt/libvirt_4.3.0.bb
> index edd5261..e6dac5d 100644
> --- a/recipes-extended/libvirt/libvirt_4.3.0.bb
> +++ b/recipes-extended/libvirt/libvirt_4.3.0.bb
> @@ -175,7 +175,7 @@ PRIVATE_LIBS_${PN}-ptest = " \
>  PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
>                     remote macvtap libvirtd netcf udev python ebtables \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit libcap-ng', '', d)} \
> -                   ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'xen libxl xen-inotify', '', d)} \
> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'xen', 'libxl', '', d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'polkit', '', d)} \
>                    "
>  
> @@ -183,10 +183,8 @@ PACKAGECONFIG ??= "qemu yajl uml openvz vmware vbox esx iproute2 lxc test \
>  #
>  PACKAGECONFIG[qemu] = "--with-qemu,--without-qemu,qemu,"
>  PACKAGECONFIG[yajl] = "--with-yajl,--without-yajl,yajl,yajl"
> -PACKAGECONFIG[xen] = "--with-xen,--without-xen,xen,"
>  PACKAGECONFIG[xenapi] = "--with-xenapi,--without-xenapi,,"
>  PACKAGECONFIG[libxl] = "--with-libxl=${STAGING_DIR_TARGET}/lib,--without-libxl,libxl,"
> -PACKAGECONFIG[xen-inotify] = "--with-xen-inotify,--without-xen-inotify,xen,"
>  PACKAGECONFIG[uml] = "--with-uml, --without-uml,,"
>  PACKAGECONFIG[openvz] = "--with-openvz,--without-openvz,,"
>  PACKAGECONFIG[vmware] = "--with-vmware,--without-vmware,,"
> @@ -305,7 +303,7 @@ do_install_ptest() {
>  	done
>  }
>  
> -pkg_postinst_libvirt() {
> +pkg_postinst_ontarget_${PN}() {
>          if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
>                  /etc/init.d/populate-volatile.sh update
>          fi

Re: [PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[Bruce Ashfield]

merged.

Bruce

On Tue, Jul 24, 2018 at 7:08 AM, He Zhe <zhe.he@windriver.com> wrote:
> systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
> in this case, kvm_intel and kvm_amd. One of them must fail on a specific
> board and causes the following failure.
>
> This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.
>
> systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
> Failed to start Load Kernel Modules.
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>  recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
> index 9905ed9..c09b07c 100644
> --- a/recipes-kernel/linux/linux-yocto_virtualization.inc
> +++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
> @@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
>
>  KERNEL_MODULE_AUTOLOAD += "openvswitch"
>  KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
>
>  # aufs kernel support required for xen-image-minimal
>  KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
> --
> 2.11.0
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[Mark Asselstine]

On Thu, Jul 26, 2018 at 10:41 AM, Bruce Ashfield
<bruce.ashfield@gmail.com> wrote:
> merged.
>
> Bruce
>
> On Tue, Jul 24, 2018 at 7:08 AM, He Zhe <zhe.he@windriver.com> wrote:
>> systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
>> in this case, kvm_intel and kvm_amd. One of them must fail on a specific
>> board and causes the following failure.
>>
>> This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.
>>
>> systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
>> Failed to start Load Kernel Modules.

Nice. I have been wanting to look at why this message was being produced.

I do wonder if this change will cause an issue for folks using
meta-virtualization with sysvinit though. What is the behavior if this
is the case?

Mark

>>
>> Signed-off-by: He Zhe <zhe.he@windriver.com>
>> ---
>>  recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
>> index 9905ed9..c09b07c 100644
>> --- a/recipes-kernel/linux/linux-yocto_virtualization.inc
>> +++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
>> @@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
>>
>>  KERNEL_MODULE_AUTOLOAD += "openvswitch"
>>  KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
>>
>>  # aufs kernel support required for xen-image-minimal
>>  KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
>> --
>> 2.11.0
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization

Re: [PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[He Zhe]

On 2018年07月26日 23:30, Mark Asselstine wrote:
> On Thu, Jul 26, 2018 at 10:41 AM, Bruce Ashfield
> <bruce.ashfield@gmail.com> wrote:
>> merged.
>>
>> Bruce
>>
>> On Tue, Jul 24, 2018 at 7:08 AM, He Zhe <zhe.he@windriver.com> wrote:
>>> systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
>>> in this case, kvm_intel and kvm_amd. One of them must fail on a specific
>>> board and causes the following failure.
>>>
>>> This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.
>>>
>>> systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
>>> Failed to start Load Kernel Modules.
> Nice. I have been wanting to look at why this message was being produced.
>
> I do wonder if this change will cause an issue for folks using
> meta-virtualization with sysvinit though. What is the behavior if this
> is the case?

It's also OK for sysvinit.

With sysvinit, modutils.sh in modutils-initscripts.bb in packagegroup-core-boot.bb
would take care of /etc/modules-load.d. And udev still takes care of kvm-intel and
kvm-amd.

Zhe

>
> Mark
>
>>> Signed-off-by: He Zhe <zhe.he@windriver.com>
>>> ---
>>>  recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>> index 9905ed9..c09b07c 100644
>>> --- a/recipes-kernel/linux/linux-yocto_virtualization.inc
>>> +++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>> @@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
>>>
>>>  KERNEL_MODULE_AUTOLOAD += "openvswitch"
>>>  KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
>>>
>>>  # aufs kernel support required for xen-image-minimal
>>>  KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
>>> --
>>> 2.11.0
>>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end"
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization

Re: [PATCH] linux-yocto: Fix systemd-modules-load.service start failure

[Mark Asselstine]

On Fri, Jul 27, 2018 at 9:42 AM, He Zhe <zhe.he@windriver.com> wrote:
>
>
> On 2018年07月26日 23:30, Mark Asselstine wrote:
>> On Thu, Jul 26, 2018 at 10:41 AM, Bruce Ashfield
>> <bruce.ashfield@gmail.com> wrote:
>>> merged.
>>>
>>> Bruce
>>>
>>> On Tue, Jul 24, 2018 at 7:08 AM, He Zhe <zhe.he@windriver.com> wrote:
>>>> systemd-modules-load.service bindly load whatever in modules-load.d/*.conf,
>>>> in this case, kvm_intel and kvm_amd. One of them must fail on a specific
>>>> board and causes the following failure.
>>>>
>>>> This patches remove them from KERNEL_MODULE_AUTOLOAD and leaves them to udev.
>>>>
>>>> systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
>>>> Failed to start Load Kernel Modules.
>> Nice. I have been wanting to look at why this message was being produced.
>>
>> I do wonder if this change will cause an issue for folks using
>> meta-virtualization with sysvinit though. What is the behavior if this
>> is the case?
>
> It's also OK for sysvinit.
>
> With sysvinit, modutils.sh in modutils-initscripts.bb in packagegroup-core-boot.bb
> would take care of /etc/modules-load.d. And udev still takes care of kvm-intel and
> kvm-amd.

Great. Thanks for checking.

Mark

>
> Zhe
>
>>
>> Mark
>>
>>>> Signed-off-by: He Zhe <zhe.he@windriver.com>
>>>> ---
>>>>  recipes-kernel/linux/linux-yocto_virtualization.inc | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/recipes-kernel/linux/linux-yocto_virtualization.inc b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> index 9905ed9..c09b07c 100644
>>>> --- a/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> +++ b/recipes-kernel/linux/linux-yocto_virtualization.inc
>>>> @@ -10,8 +10,6 @@ KERNEL_FEATURES_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'featu
>>>>
>>>>  KERNEL_MODULE_AUTOLOAD += "openvswitch"
>>>>  KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm', '', d)}"
>>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-amd', '', d)}"
>>>> -KERNEL_MODULE_AUTOLOAD += "${@bb.utils.contains('DISTRO_FEATURES', 'kvm', 'kvm-intel', '', d)}"
>>>>
>>>>  # aufs kernel support required for xen-image-minimal
>>>>  KERNEL_FEATURES_append += "${@bb.utils.contains('DISTRO_FEATURES', 'aufs', ' features/aufs/aufs-enable.scc', '', d)}"
>>>> --
>>>> 2.11.0
>>>>
>>>
>>>
>>> --
>>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>>> thee at its end"
>>> --
>>> _______________________________________________
>>> meta-virtualization mailing list
>>> meta-virtualization@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization